New issue
Advanced search Search tips

Issue 598956 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 595883



Sign in to add a comment

Fix `git bash` alias to run git-bash.exe

Project Member Reported by iannu...@google.com, Mar 30 2016

Issue description

Currently it just runs 'bash' in the same console, which doesn't set up the environment terribly well. It doesn't trap ctrl-C correctly, among other things. git-bash actually has a correctly-sizable UI, allows copy/paste, tab completion, etc.
 
You don't mean this for git-admin, do you?

Comment 2 by iannu...@google.com, Mar 30 2016

Labels: -Infra-Git
nope, sorry
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/0703ea2cc637d755954b58a3c144b767bfc39ee6

commit 0703ea2cc637d755954b58a3c144b767bfc39ee6
Author: iannucci@chromium.org <iannucci@chromium.org>
Date: Fri Apr 01 01:02:42 2016

Multiple improvements to windows bash integration.
  * `git bash` helper now will either:
    * launch an interactive bash prompt in the MinGW Terminal Emulator
    * launch a non-interactive bash shell if arguments are provided
  * `git bash` now includes python, python/Scripts and svn binaries in
    the PATH.
  * depot_tools' colorization now works in MinGW Terminal Emulator
  * batch scripts are now regenerated if any of them is missing.

R=agable@chromium.org, dnj@chromium.org, mmoss@chromium.org
BUG= 598956 

Review URL: https://codereview.chromium.org/1847783002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299616 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/.gitignore
[add] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/bootstrap/win/git-bash.template.sh
[modify] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/bootstrap/win/win_tools.bat
[modify] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/depot-tools-auth.py
[modify] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/gclient.py
[delete] https://crrev.com/c0f8642119883b921f206c12792c2acb19d69768/git-bash
[modify] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/git_cl.py
[modify] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/git_map_branches.py
[modify] https://crrev.com/0703ea2cc637d755954b58a3c144b767bfc39ee6/python_runner.sh

Status: Fixed (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/51bcc4301eed6876b97c9679a0e92da76d8cdd76

commit 51bcc4301eed6876b97c9679a0e92da76d8cdd76
Author: iannucci@chromium.org <iannucci@chromium.org>
Date: Fri Apr 01 01:24:12 2016

Fix bash math for `git bash` alias.

Previous calculation was off-by-one.

TBR=dnj@chromium.org, mmoss@chromium.org
BUG= 598956 

Review URL: https://codereview.chromium.org/1848793004 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299619 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/51bcc4301eed6876b97c9679a0e92da76d8cdd76/bootstrap/win/git-bash.template.sh

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/a218d7e9152e9765097e30406bcd70793306d223

commit a218d7e9152e9765097e30406bcd70793306d223
Author: iannucci@chromium.org <iannucci@chromium.org>
Date: Mon Apr 04 21:22:42 2016

Add bash shell function to make python work like it should.

This uses the virtual /proc filesystem to identify when the user runs
`python` without redirecting stdout/stdin. If this is the case, we run
`python -i` instead. Otherwise, or if there are arguments, we run it
verbatim.

R=dnj@chromium.org
BUG= 598956 

Review URL: https://codereview.chromium.org/1851113003 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299681 0039d316-1c4b-4281-b951-d872f2087c98

[add] https://crrev.com/a218d7e9152e9765097e30406bcd70793306d223/bootstrap/win/profile.d.python.sh
[modify] https://crrev.com/a218d7e9152e9765097e30406bcd70793306d223/bootstrap/win/win_tools.bat

Sign in to add a comment