New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598953 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

SupportedVersion QuicConnectionTests failing under DrMemory

Project Member Reported by benwells@chromium.org, Mar 30 2016

Issue description

Started here: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4473

Which had this CL: https://crrev.com/f2bd55c5ab99300b7df0a97b3d0ef16c9a2e584a

Sample output:
SupportedVersion/QuicConnectionTest.TooManyReceivedPackets/1:
[3476:4348:0325/004037:15233388:ERROR:quic_framer.cc(353)] AppendAckFrameAndTypeByte failed
[3476:4348:0325/004037:15233404:ERROR:quic_packet_creator.cc(428)] Failed to serialize 2 frames.
[3476:4348:0325/004037:15233404:ERROR:quic_packet_creator.cc(332)] Failed to SerializePacket.
unknown file: error:
Unexpected mock function call - returning directly.
Function call: OnConnectionClosed(75, 4-byte object <01-00 00-00>)
Google Mock tried the following 1 expectation, but it didn't match:

c:\b\build\slave\drm-cr\build\src\net\quic\quic_connection_test.cc(1497): EXPECT_CALL(visitor_, OnConnectionClosed(QUIC_TOO_MANY_OUTSTANDING_RECEIVED_PACKETS, ConnectionCloseSource::FROM_SELF))...
Expected arg #0: is equal to 69
Actual: 75
Expected: to be called once
Actual: never called - unsatisfied and active
c:\b\build\slave\drm-cr\build\src\net\quic\quic_connection_test.cc(1497): error: Actual function call count doesn't match EXPECT_CALL(visitor_, OnConnectionClosed(QUIC_TOO_MANY_OUTSTANDING_RECEIVED_PACKETS, ConnectionCloseSource::FROM_SELF))...
Expected: to be called once
Actual: never called - unsatisfied and active
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e7f953abe4f0e0734bbc4693ed836b62ffd36f

commit 19e7f953abe4f0e0734bbc4693ed836b62ffd36f
Author: benwells <benwells@chromium.org>
Date: Wed Mar 30 04:06:57 2016

Exclude a Quic test under DrMemory.

The test is failing there after a recent QUIC update.

TBR=jyasskin@chromium.org
BUG=598953

Review URL: https://codereview.chromium.org/1844733004

Cr-Commit-Position: refs/heads/master@{#383905}

[modify] https://crrev.com/19e7f953abe4f0e0734bbc4693ed836b62ffd36f/tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e7f953abe4f0e0734bbc4693ed836b62ffd36f

commit 19e7f953abe4f0e0734bbc4693ed836b62ffd36f
Author: benwells <benwells@chromium.org>
Date: Wed Mar 30 04:06:57 2016

Exclude a Quic test under DrMemory.

The test is failing there after a recent QUIC update.

TBR=jyasskin@chromium.org
BUG=598953

Review URL: https://codereview.chromium.org/1844733004

Cr-Commit-Position: refs/heads/master@{#383905}

[modify] https://crrev.com/19e7f953abe4f0e0734bbc4693ed836b62ffd36f/tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt

Dang got the suppression wrong. I'll fix that.

jokulik: Could you look at the failure? It started happening after your CL and appears related.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2564a9d0d2d2bbcab9d0377f709d93645fc56ab0

commit 2564a9d0d2d2bbcab9d0377f709d93645fc56ab0
Author: benwells <benwells@chromium.org>
Date: Thu Mar 31 06:44:01 2016

Fix DrMemory exclusion for QuicConnectionTests

TBR=jyasskin@chromium.org
BUG=598953

Review URL: https://codereview.chromium.org/1843393002

Cr-Commit-Position: refs/heads/master@{#384203}

[modify] https://crrev.com/2564a9d0d2d2bbcab9d0377f709d93645fc56ab0/tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt

jokulik / rch : could someone please triage / investigate? Or at least acknowlege you've seen this bug?
Labels: Stability-Memory-DrMemory
Status: Assigned (was: Untriaged)

Sign in to add a comment