Issue 598950 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ yoshiki@chromium.org Last visit > 30 days ago
Closed:	Aug 2016
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

ToastManagerTest.QueueMessage is flakily timing out on ChromeOS valgrind

Project Member Reported by benwells@chromium.org, Mar 30 2016

Issue description

E.g. https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/42125

This is a new test which looks like it has always done this. As the ChromeOS bot in question doesn't appear to use recipes, this causes and exception and the whole bot stops :(

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f7bb2c40bc75848397f32c1b776fe7927ace4d7

commit 2f7bb2c40bc75848397f32c1b776fe7927ace4d7
Author: benwells <benwells@chromium.org>
Date: Wed Mar 30 03:55:29 2016

Exclude flakily timing out test under ChromeOS valgrind.

TBR=jyasskin@chromium.org
BUG= 598950 

Review URL: https://codereview.chromium.org/1840363002

Cr-Commit-Position: refs/heads/master@{#383903}

[modify] https://crrev.com/2f7bb2c40bc75848397f32c1b776fe7927ace4d7/tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f7bb2c40bc75848397f32c1b776fe7927ace4d7

commit 2f7bb2c40bc75848397f32c1b776fe7927ace4d7
Author: benwells <benwells@chromium.org>
Date: Wed Mar 30 03:55:29 2016

Exclude flakily timing out test under ChromeOS valgrind.

TBR=jyasskin@chromium.org
BUG= 598950 

Review URL: https://codereview.chromium.org/1840363002

Cr-Commit-Position: refs/heads/master@{#383903}

[modify] https://crrev.com/2f7bb2c40bc75848397f32c1b776fe7927ace4d7/tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt

Comment 3 by yoshiki@chromium.org, Mar 30 2016

Status: Started (was: Untriaged)

Thank you for filing this.

The working patch, which fixes the possibly timing issue, should fixes this as well: https://codereview.chromium.org/1841563003/.