New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598949 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 598549

Blocking:
issue 600087



Sign in to add a comment

Add tests for YUV image decoding

Project Member Reported by noel@chromium.org, Mar 30 2016

Issue description

YUV decoding is enabled with Ganesh currently on Chrome Android only, and then only if a special <meta> tag, refer to [1] for details.

We should add layout tests for YUV decoding, using the <meta> tag to enable this mode on the Android bots.

[1] https://www.chromium.org/developers/design-documents/chromium-graphics/how-to-get-gpu-rasterization chrome://flags/#enable-gpu-rasterization (or --force-gpu-rasterization from the command line).
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9139d6d428b36f175d9cda8172fa9d025bc48aba

commit 9139d6d428b36f175d9cda8172fa9d025bc48aba
Author: noel <noel@chromium.org>
Date: Wed Mar 30 03:22:31 2016

Add YCbCr image resources for YUV decoding layout tests

Manually recover the images from CL issue 561363002 and submit
those images to LayoutTests/fast/images/resources

TBR=msarett@chromium.org
BUG= 598949 
NOTRY=true

Review URL: https://codereview.chromium.org/1844833002

Cr-Commit-Position: refs/heads/master@{#383900}

[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-420-fast-int-progressive.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-420-float-progressive.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-420-float.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-420-progressive-smooth.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-420-progressive.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-420.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-422-float.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-422.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-440-float.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-440.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-444-float.jpg
[add] https://crrev.com/9139d6d428b36f175d9cda8172fa9d025bc48aba/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-444.jpg

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba0c7e528c319dd596706d576f094e14b1991b54

commit ba0c7e528c319dd596706d576f094e14b1991b54
Author: noel <noel@chromium.org>
Date: Wed Mar 30 19:54:37 2016

Add <meta> tag YUV JPEG image decoding layout tests

Based on the test from CL issue 561363002, here updated to use
the current <meta> viewport tag that enables GPU rasterization
support on Chrome Android, and to include pixel results (which
are added here to prevent paint regressions, at least for this
very small set of YUV JPEG images).

BUG= 598949 

Review URL: https://codereview.chromium.org/1840303003

Cr-Commit-Position: refs/heads/master@{#384062}

[modify] https://crrev.com/ba0c7e528c319dd596706d576f094e14b1991b54/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/ba0c7e528c319dd596706d576f094e14b1991b54/third_party/WebKit/LayoutTests/fast/images/jpeg-ycbcr-vuv-image-decoding.html

Comment 4 by noel@chromium.org, Mar 30 2016

Closed https://codereview.chromium.org/561363002  I should probably rename the layout test to something more sensible ("vuv" doesn't work for me :)

Test coverage could be improved, hard to tell if the ycbcr image corpus #2 gives good coverage, but a least we have some coverage I suppose.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/118b85eb19b9761a27acd727fa03dfce5d00bba3

commit 118b85eb19b9761a27acd727fa03dfce5d00bba3
Author: noel <noel@chromium.org>
Date: Wed Mar 30 21:39:08 2016

Rename YUV JPEG image decoding layout test

Drop the ycbcr from the name, use yuv instead, add a reference
to the bug with details explaining the <meta> tag.

BUG= 598949 

Review URL: https://codereview.chromium.org/1836293004

Cr-Commit-Position: refs/heads/master@{#384099}

[modify] https://crrev.com/118b85eb19b9761a27acd727fa03dfce5d00bba3/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/118b85eb19b9761a27acd727fa03dfce5d00bba3/third_party/WebKit/LayoutTests/fast/images/jpeg-yuv-image-decoding.html

Comment 6 by noel@chromium.org, Mar 30 2016

Cc: wkorman@chromium.org
+Walter, is rebaseline-o-matic active?
It looks like it:

https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/246757/steps/webkit-patch%20auto-rebaseline/logs/stdio

webkitpy.tool.commands.rebaseline: [INFO] compositing/layer-creation/overlap-animation-container.html is waiting for r384058
webkitpy.tool.commands.rebaseline: [INFO] compositing/squashing/squash-transform-repainting-child.html is waiting for r384058
webkitpy.tool.commands.rebaseline: [INFO] compositing/squashing/squash-transform-repainting-transformed-child.html is waiting for r384058
webkitpy.tool.commands.rebaseline: [INFO] compositing/squashing/squash-transform.html is waiting for r384058
webkitpy.tool.commands.rebaseline: [INFO] fast/images/jpeg-yuv-image-decoding.html is waiting for r384099

Comment 8 by noel@chromium.org, Mar 30 2016

OK good .. I was looking at http://blinkrebaseline.appspot.com and maybe that's the wrong place to look these days.  Anyho, we're good here.
No problem, yes, we've moved the bot to run on a builder now as:

% ./Tools/Scripts/webkit-patch auto-rebaseline -v

whereas previously it ran on a workstation via:

% ./Tools/Scripts/webkit-patch rebaseline-o-matic -v

The latter has logging capture that rolls into blinkrebaseline.appspot.com and the former does not. So to check status now you have to go look at the most recent builder output under:

https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic

Comment 10 by noel@chromium.org, Mar 30 2016

Thanks, I updated the docs [1] with the new URL to be used to check rebaseliner status.

[1] https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-tests/testexpectations

Comment 11 by noel@chromium.org, Mar 30 2016

Blockedon: 598549

Comment 13 by noel@chromium.org, Mar 31 2016

Status: Fixed (was: Untriaged)

Comment 14 by noel@chromium.org, Apr 4 2016

Blocking: 600087

Sign in to add a comment