New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598941 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

depot_tools programs on windows do not update when running `gclient` under msys bash

Project Member Reported by iannu...@google.com, Mar 30 2016

Issue description

This means that users who use msysbash for everything will never get updated git binaries.

This is related to issue 598931 because depot_tools programs sometimes prefer the bundled binaries over e.g. git available in PATH.
 

Comment 1 by iannu...@google.com, Mar 30 2016

From the other issue:

It looks like there used to be some vestigial support for CYGWIN to run the tools updater when running gclient under CYGWIN (but not MINGW): https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/update_depot_tools#31

We could make this work for mingw as well, but it still wouldn't solve this problem if the user has their versions of these tools on PATH ahead of depot_tools.

Comment 2 by iannu...@google.com, Mar 30 2016

Unfortunately, it looks like some tools (like 'find') are being found by the update bat scripts (e.g. it's expecting the builtin)

Comment 3 by iannu...@google.com, Mar 30 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/02ef57e288c377d577bbecc0574e91e8ff94e051

commit 02ef57e288c377d577bbecc0574e91e8ff94e051
Author: iannucci@chromium.org <iannucci@chromium.org>
Date: Wed Mar 30 01:46:41 2016

Make git binary tools auto update on mingw

R=dnj@chromium.org, pkasting@chromium.org
BUG= 598941 

Review URL: https://codereview.chromium.org/1845493003 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299556 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/02ef57e288c377d577bbecc0574e91e8ff94e051/bootstrap/win/win_tools.bat
[modify] https://crrev.com/02ef57e288c377d577bbecc0574e91e8ff94e051/update_depot_tools

Comment 5 by iannu...@google.com, Mar 30 2016

This seems to be working now, though we discovered that there are (at least) 3 different ways to run bash, and only 2 of them work, so I'm going to make a followup fix to add a warning if we detect the third case.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/cf231ddddbeaa1309bc5cef400443011677e3e77

commit cf231ddddbeaa1309bc5cef400443011677e3e77
Author: iannucci@chromium.org <iannucci@chromium.org>
Date: Wed Mar 30 02:45:15 2016

Add warning when running gclient under MSYS shell.

R=dnj@chromium.org, pkasting@chromium.org
BUG= 598941 

Review URL: https://codereview.chromium.org/1847433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299559 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/cf231ddddbeaa1309bc5cef400443011677e3e77/update_depot_tools

Comment 7 by iannu...@google.com, Mar 30 2016

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/02ef57e288c377d577bbecc0574e91e8ff94e051

commit 02ef57e288c377d577bbecc0574e91e8ff94e051
Author: iannucci@chromium.org <iannucci@chromium.org>
Date: Wed Mar 30 01:46:41 2016

Make git binary tools auto update on mingw

R=dnj@chromium.org, pkasting@chromium.org
BUG= 598941 

Review URL: https://codereview.chromium.org/1845493003 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299556 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/02ef57e288c377d577bbecc0574e91e8ff94e051/bootstrap/win/win_tools.bat
[modify] https://crrev.com/02ef57e288c377d577bbecc0574e91e8ff94e051/update_depot_tools

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/cf231ddddbeaa1309bc5cef400443011677e3e77

commit cf231ddddbeaa1309bc5cef400443011677e3e77
Author: iannucci@chromium.org <iannucci@chromium.org>
Date: Wed Mar 30 02:45:15 2016

Add warning when running gclient under MSYS shell.

R=dnj@chromium.org, pkasting@chromium.org
BUG= 598941 

Review URL: https://codereview.chromium.org/1847433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299559 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/cf231ddddbeaa1309bc5cef400443011677e3e77/update_depot_tools

Components: Infra>Git
Labels: -Infra-Git
Labels: -Infra

Sign in to add a comment