New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 598933 link

Starred by 1 user
Status: Fixed
Owner:
█ marcinjb@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
█ sriramsr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Restart Blimp engine within Docker container if it exits cleanly

Project Member Reported by marcinjb@chromium.org, Mar 30 2016 
Currently, if the Blimp engine exits cleanly (ie. with a zero return code), the entire Docker container it runs in gets torn down.  This is actually expected behavior (happening when a connection gets torn down), and causes our Docker containers to get restarted too much.

Instead, we should restart the engine within the Docker container if there's a clean exit.  If the engine ever exits with a nonzero return code, however, we should bomb out.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e8f69e15bd7e054e4c3cbb5e6b70870adb1951e

commit 7e8f69e15bd7e054e4c3cbb5e6b70870adb1951e
Author: marcinjb <marcinjb@chromium.org>
Date: Wed Mar 30 23:13:27 2016

Restart the engine within the docker container when appropriate.

It's possible for the engine to exit successfully right now (when a
connection is lost). The current state of start_engine.sh will cause
the Docker container to exit in this case, which isn't desired behavior.

This patch changes the behavior so that the engine will continuously be
restarted within the Docker container so long as it exits cleanly. If the
engine exits with a nonzero code (or if stunnel bombs out), the Docker
container will be torn down.

BUG= 598933 

Review URL: https://codereview.chromium.org/1844733003

Cr-Commit-Position: refs/heads/master@{#384139}

[modify] https://crrev.com/7e8f69e15bd7e054e4c3cbb5e6b70870adb1951e/blimp/engine/start_engine.sh

Comment 2 by marcinjb@chromium.org, Mar 30 2016

Status: Fixed (was: Started)

Comment 3 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment