New issue
Advanced search Search tips

Issue 598931 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 595883



Sign in to add a comment

depot_tools programs on windows sometimes prefer the bundled binary tools over tools available in the msys PATH

Project Member Reported by iannu...@google.com, Mar 30 2016

Issue description

Currently the git-<something> tools in depot_tools will end up invoking the bundled version of git, even when running from a custom msys environment. This can lead to version skew if the user has their msys environment set up with version Y, but depot_tools has a bundled version X.

Within an msys environment, all of the tools (python, git, svn), should probably use the msys-provided versions of them, as the user has opted to not use the bundled tools in depot_tools.
 

Comment 1 by iannu...@google.com, Mar 30 2016

Cc: aga...@chromium.org mmoss@chromium.org

Comment 2 by iannu...@google.com, Mar 30 2016

It looks like there used to be some vestigial support for CYGWIN to run the tools updater when running gclient under CYGWIN (but not MINGW): https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/update_depot_tools#31

We could make this work for mingw as well, but it still wouldn't solve this problem if the user has their versions of these tools on PATH ahead of depot_tools.
I'm confused.  I thought this bug was about invoking the PATH-based git from git-XXX tools (comment 0), rather than having anything to do with the tools updater (comment 2).  How are these two connected?

Comment 4 by iannu...@google.com, Mar 30 2016

yes, sorry, I posted the update in the wrong bug. I'll file a second one for #2.

Comment 5 by iannu...@google.com, Mar 30 2016

Summary: depot_tools programs on windows sometimes prefer the bundled binary tools over tools available in the msys PATH (was: Msys and depot_tools)

Comment 6 by iannu...@google.com, Mar 30 2016

It's related to  issue 598941  because running `gclient` under msys doesn't currently update the bundled binary tools.

Comment 7 by iannu...@google.com, Mar 30 2016

Blocking: 595883

Comment 8 by iannu...@google.com, Mar 30 2016

Blockedon: 595883
Blocking: -595883
Oops. This isn't a blocker, but I want to block it on 595883 instead.

Comment 9 by stip@chromium.org, Mar 30 2016

Labels: -Infra Infra-Platform
Moving to infra-platform.
Components: Infra>Git
Labels: -Infra-Git
Components: Infra>Platform
Labels: -Infra-Platform
Components: -Infra>Platform Infra>SDK
Components: -Infra>Git
Labels: Infra-DX
Not a git admin bug.
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 3 2016

Labels: Hotlist-Google
Labels: Pri-2
Labels: Type-Bug
Status: Available (was: Untriaged)
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4d3ca91d85b14adea9aea8da561c97968c4f58c

commit d4d3ca91d85b14adea9aea8da561c97968c4f58c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Aug 02 21:56:22 2017

Add Debian Stretch sysroot creator

BUG=598931
R=thestig@chromium.org

Change-Id: I0469f7a8e047556d23e387bd7193a4c529195b20
Reviewed-on: https://chromium-review.googlesource.com/598941
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491517}
[add] https://crrev.com/d4d3ca91d85b14adea9aea8da561c97968c4f58c/build/linux/sysroot_scripts/debian-archive-stretch-stable.gpg
[add] https://crrev.com/d4d3ca91d85b14adea9aea8da561c97968c4f58c/build/linux/sysroot_scripts/sysroot-creator-stretch.sh

Project Member

Comment 19 by sheriffbot@chromium.org, Aug 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
oof. yeah this one is still important.

Sign in to add a comment