New issue
Advanced search Search tips

Issue 598930 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 594021



Sign in to add a comment

WebGL 2.0 primitiverestart.html conformance test failures on Mac OS X with AMD GPUs

Project Member Reported by kbr@chromium.org, Mar 30 2016

Issue description

The following sub-tests of the deqp/functional/gles3/primitiverestart.html test are failing on the new Mac OS X Retina laptops with AMD GPUs:

primitive_restart.basic.3.unsigned_byte.draw_elements
primitive_restart.basic.3.unsigned_byte.draw_elements_instanced
primitive_restart.basic.3.unsigned_byte.draw_range_elements
primitive_restart.basic.3.unsigned_short.draw_elements
primitive_restart.basic.3.unsigned_short.draw_elements_instanced
primitive_restart.basic.3.unsigned_short.draw_range_elements
primitive_restart.basic.3.unsigned_int.draw_elements
primitive_restart.basic.3.unsigned_int.draw_elements_instanced
primitive_restart.basic.3.unsigned_int.draw_range_elements
primitive_restart.basic.6.unsigned_byte.draw_elements
primitive_restart.basic.6.unsigned_byte.draw_elements_instanced
primitive_restart.basic.6.unsigned_byte.draw_range_elements
primitive_restart.basic.6.unsigned_short.draw_elements
primitive_restart.basic.6.unsigned_short.draw_elements_instanced
primitive_restart.basic.6.unsigned_short.draw_range_elements
primitive_restart.basic.6.unsigned_int.draw_elements
primitive_restart.basic.6.unsigned_int.draw_elements_instanced
primitive_restart.basic.6.unsigned_int.draw_range_elements
primitive_restart.duplicate_restarts.6.unsigned_byte.draw_elements
primitive_restart.duplicate_restarts.6.unsigned_byte.draw_elements_instanced
primitive_restart.duplicate_restarts.6.unsigned_byte.draw_range_elements
primitive_restart.duplicate_restarts.6.unsigned_short.draw_elements
primitive_restart.duplicate_restarts.6.unsigned_short.draw_elements_instanced
primitive_restart.duplicate_restarts.6.unsigned_short.draw_range_elements
primitive_restart.duplicate_restarts.6.unsigned_int.draw_elements
primitive_restart.duplicate_restarts.6.unsigned_int.draw_elements_instanced
primitive_restart.duplicate_restarts.6.unsigned_int.draw_range_elements

These failures are blocking https://codereview.chromium.org/1822643002/ , which enables primitive restart for WebGL 2.0, from landing. Let's suppress these failures only on this configuration for the moment, and investigate more deeply afterward.

 

Comment 1 by kbr@chromium.org, Mar 30 2016

Note: once the WebGL conformance tests are rolled forward to https://chromium.googlesource.com/external/khronosgroup/webgl/+/70cabc7cdf85c3ec875190433d84034dcee1c94b , the names of the failing tests will be:

primitive_restart.basic.lines.unsigned_byte.draw_elements
primitive_restart.basic.lines.unsigned_byte.draw_elements_instanced
primitive_restart.basic.lines.unsigned_byte.draw_range_elements
primitive_restart.basic.lines.unsigned_short.draw_elements
primitive_restart.basic.lines.unsigned_short.draw_elements_instanced
primitive_restart.basic.lines.unsigned_short.draw_range_elements
primitive_restart.basic.lines.unsigned_int.draw_elements
primitive_restart.basic.lines.unsigned_int.draw_elements_instanced
primitive_restart.basic.lines.unsigned_int.draw_range_elements
primitive_restart.basic.triangles.unsigned_byte.draw_elements
primitive_restart.basic.triangles.unsigned_byte.draw_elements_instanced
primitive_restart.basic.triangles.unsigned_byte.draw_range_elements
primitive_restart.basic.triangles.unsigned_short.draw_elements
primitive_restart.basic.triangles.unsigned_short.draw_elements_instanced
primitive_restart.basic.triangles.unsigned_short.draw_range_elements
primitive_restart.basic.triangles.unsigned_int.draw_elements
primitive_restart.basic.triangles.unsigned_int.draw_elements_instanced
primitive_restart.basic.triangles.unsigned_int.draw_range_elements
primitive_restart.duplicate_restarts.triangles.unsigned_byte.draw_elements
primitive_restart.duplicate_restarts.triangles.unsigned_byte.draw_elements_instanced
primitive_restart.duplicate_restarts.triangles.unsigned_byte.draw_range_elements
primitive_restart.duplicate_restarts.triangles.unsigned_short.draw_elements
primitive_restart.duplicate_restarts.triangles.unsigned_short.draw_elements_instanced
primitive_restart.duplicate_restarts.triangles.unsigned_short.draw_range_elements
primitive_restart.duplicate_restarts.triangles.unsigned_int.draw_elements
primitive_restart.duplicate_restarts.triangles.unsigned_int.draw_elements_instanced
primitive_restart.duplicate_restarts.triangles.unsigned_int.draw_range_elements

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56aae8327a6d2e3fa4863339be9f8abeaea47680

commit 56aae8327a6d2e3fa4863339be9f8abeaea47680
Author: yunchao.he <yunchao.he@intel.com>
Date: Wed Mar 30 08:32:32 2016

[Command buffer] Enable primitive restart for WebGL 2.
This change also fixed bugs in primitiverestart.html in WebGL deqp tests.

Some code come from kbr@chromium.org's
https://codereview.chromium.org/1813163003/

BUG= 594021 ,  295792 ,  598930 
TEST=deqp/functional/gles3/primitiverestart.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1822643002

Cr-Commit-Position: refs/heads/master@{#383931}

[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/buffer_manager.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/buffer_manager.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/buffer_manager_unittest.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/context_state.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/generate_bindings.py
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_api_autogen_gl.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_gl.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_gl.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_mock.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_mock.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_mock_autogen_gl.h

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56aae8327a6d2e3fa4863339be9f8abeaea47680

commit 56aae8327a6d2e3fa4863339be9f8abeaea47680
Author: yunchao.he <yunchao.he@intel.com>
Date: Wed Mar 30 08:32:32 2016

[Command buffer] Enable primitive restart for WebGL 2.
This change also fixed bugs in primitiverestart.html in WebGL deqp tests.

Some code come from kbr@chromium.org's
https://codereview.chromium.org/1813163003/

BUG= 594021 ,  295792 ,  598930 
TEST=deqp/functional/gles3/primitiverestart.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1822643002

Cr-Commit-Position: refs/heads/master@{#383931}

[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/buffer_manager.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/buffer_manager.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/buffer_manager_unittest.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/context_state.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/generate_bindings.py
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_api_autogen_gl.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_gl.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_gl.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_mock.cc
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_bindings_autogen_mock.h
[modify] https://crrev.com/56aae8327a6d2e3fa4863339be9f8abeaea47680/ui/gl/gl_mock_autogen_gl.h

Comment 4 by zmo@chromium.org, Dec 20 2016

Status: Verified (was: Available)
Fixed in 10.12.2.  I resolved the Apple Radar (28184344).
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1733d120eb79e2d8d49b18892e60ee1297f646f7

commit 1733d120eb79e2d8d49b18892e60ee1297f646f7
Author: zmo <zmo@chromium.org>
Date: Thu Jun 08 23:24:48 2017

Update WebGL2 conformance test expectations for Mac bots.

BUG= 598930 , 617290 , 618464 ,630800, 641149 , 643866 , 645298 , 646182 , 654187 , 663188 ,665197, 665656 , 676848 , 679682 , 679684 , 679686 , 679687 , 679689 , 679690 , 679691 , 680278 , 684903 
TEST=mac bots on GPU FYI waterfall
TBR=kbr@chromium.org,kainino@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2931993002
Cr-Commit-Position: refs/heads/master@{#478121}

[modify] https://crrev.com/1733d120eb79e2d8d49b18892e60ee1297f646f7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Sign in to add a comment