Issue metadata
Sign in to add a comment
|
[REGRESSION] DevTools: cannot accept property edits with mouse click |
||||||||||||||||||||||
Issue descriptionChrome Version : 50.0.2661.49 What steps will reproduce the problem? 1. Navigate to google.com 2. Open DevTools, select "body" in elements panel 3. Start editing name of the "background: #fff" property 4. Put "color" instead 5. Mouse click outside of editable field Expected: the new value gets committed Actual: the old value gets restored Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.110 Safari/537.36
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd commit 5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd Author: lushnikov <lushnikov@chromium.org> Date: Wed Mar 30 01:21:45 2016 DevTools: [SSP] accept editing on mouse click This behavior was regressed back in http://crrev.com/1649533003. BUG= 598919 R=pfeldman, dgozman Review URL: https://codereview.chromium.org/1846433002 Cr-Commit-Position: refs/heads/master@{#383889} [modify] https://crrev.com/5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd commit 5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd Author: lushnikov <lushnikov@chromium.org> Date: Wed Mar 30 01:21:45 2016 DevTools: [SSP] accept editing on mouse click This behavior was regressed back in http://crrev.com/1649533003. BUG= 598919 R=pfeldman, dgozman Review URL: https://codereview.chromium.org/1846433002 Cr-Commit-Position: refs/heads/master@{#383889} [modify] https://crrev.com/5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Apr 1 2016
Verified working as expected on Mac Chrome Canary
,
Apr 1 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Apr 1 2016
Please merge your change to M50 branch 2661 by 5:00 PM on Monday, 04/04/16 so we can take it for next week beta. Thank you.
,
Apr 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/883dbb3191fbcd5c1c8f29ecc37b5e6f63f21fb7 commit 883dbb3191fbcd5c1c8f29ecc37b5e6f63f21fb7 Author: Andrey Lushnikov <lushnikov@chromium.org> Date: Fri Apr 01 22:28:19 2016 DevTools: [SSP] accept editing on mouse click This behavior was regressed back in http://crrev.com/1649533003. BUG= 598919 R=pfeldman, dgozman Review URL: https://codereview.chromium.org/1846433002 Cr-Commit-Position: refs/heads/master@{#383889} (cherry picked from commit 5d556d4423750cbbcc7d8ac7cd28c1e3b5f6c9fd) Review URL: https://codereview.chromium.org/1847303005 . Cr-Commit-Position: refs/branch-heads/2661@{#463} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/883dbb3191fbcd5c1c8f29ecc37b5e6f63f21fb7/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Apr 1 2016
,
Apr 6 2016
Retested the above on Ubuntu 14.04 with chrome version '50.0.2661.66'(378081) and working as intended, the new values gets committed. Hence marking the same as TE-Verified-50.0.2661.66.
,
Sep 29 2016
,
Sep 29 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lushnikov@chromium.org
, Mar 30 2016