Get rid of android recipe_autogen recipes |
||||||||
Issue descriptionthey're recipes that still rely on bb_run_bot.py :( build/scripts/slave/recipes$ grep bb_run_bot ./* -rl ./chromium.fyi.misc_block.recipe_autogen.expected/Android_Asan_Builder_Tests__dbg_.json ./chromium.fyi.misc_block.recipe_autogen.expected/Android_ChromeDriver_Tests__dbg_.json ./chromium.fyi.misc_block.recipe_autogen.py ./chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_5_.json ./chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_6_.json ./chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_9_.json ./chromium.gpu.recipe_autogen.py
,
Mar 30 2016
,
Mar 30 2016
Issue 551137 has been merged into this issue.
,
Mar 30 2016
I'll take chromium.gpu, and bpastene@ will take chromium.fyi.
,
Mar 30 2016
I'll work on fyi today.
,
Mar 30 2016
Just checking: this involved extracting the logic out of bb_run_bot into the recipe, correct?
,
Mar 30 2016
Yeah, it will. bb_run_bot should not be called from recipes.
,
Mar 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25aea02e9f3b8e141c4c9eb2db34c3aa165a40f7 commit 25aea02e9f3b8e141c4c9eb2db34c3aa165a40f7 Author: bpastene <bpastene@chromium.org> Date: Thu Mar 31 01:13:09 2016 List src-side tests for Android Asan Builder Tests on chromium.fyi. BUG= 598907 Review URL: https://codereview.chromium.org/1849493002 Cr-Commit-Position: refs/heads/master@{#384181} [modify] https://crrev.com/25aea02e9f3b8e141c4c9eb2db34c3aa165a40f7/testing/buildbot/chromium.fyi.json
,
Mar 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/ce7b8d5ce7fbee31d0f88e14cc45fc9894326cde commit ce7b8d5ce7fbee31d0f88e14cc45fc9894326cde Author: bpastene@chromium.org <bpastene@chromium.org> Date: Thu Mar 31 01:20:06 2016 Switch Android Asan Builder Tests on chromium.fyi to chromium recipe. Src-side tests here: https://codereview.chromium.org/1849493002/ Added mb configs here: https://codereview.chromium.org/1830423002 BUG= 598907 Review URL: https://codereview.chromium.org/1848513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299578 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/ce7b8d5ce7fbee31d0f88e14cc45fc9894326cde/masters/master.chromium.fyi/master.cfg [modify] https://crrev.com/ce7b8d5ce7fbee31d0f88e14cc45fc9894326cde/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [add] https://crrev.com/ce7b8d5ce7fbee31d0f88e14cc45fc9894326cde/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json
,
Mar 31 2016
Ping mikecase@: what's the status of the chromedriver recipe mentioned in comment #1? Are you still working on it? If not, let me know and I'll pick it up.
,
Mar 31 2016
I'll stopped working on it because I thought the auto-gen recipes made my work no longer necessary. I can pick it back up and I'll prioritize working on it.
,
Apr 7 2016
,
Apr 27 2016
,
Jun 2 2016
mikecase@: looks like the GPU bots have been converted and only chromedriver is left. Have you had a chance to look into it?
,
Jun 3 2016
I have a CL slowly getting through code review for it. Got distracted by another project, but after I finish it, I'll return to the Chromedriver recipe. https://codereview.chromium.org/1274723004
,
Jun 27 2016
,
Jun 27 2016
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/8d17b9874ec74054e26e9bb273f27da529379baf commit 8d17b9874ec74054e26e9bb273f27da529379baf Author: stip <stip@chromium.org> Date: Tue Jul 12 17:53:18 2016 Switch chromedriver to new recipe, remove bb_run_bot references from build/. BUG= 598907 , 619045 Review-Url: https://codereview.chromium.org/2143503002 [modify] https://crrev.com/8d17b9874ec74054e26e9bb273f27da529379baf/masters/master.chromium.fyi/master.cfg [modify] https://crrev.com/8d17b9874ec74054e26e9bb273f27da529379baf/scripts/master/recipe_converter.py [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.expected/Android_ChromeDriver_Tests__dbg_.json [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.expected/builder_not_in_dispatch_directory.json [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_5_.json [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_6_.json [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_9_.json [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/builder_not_in_dispatch_directory.json [delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.py
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/f5f911ec72c893d9ce8150547ca4fe4a7f02e3a1 commit f5f911ec72c893d9ce8150547ca4fe4a7f02e3a1 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Jul 12 18:32:20 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/8d17b9874ec74054e26e9bb273f27da529379baf Switch chromedriver to new recipe, remove bb_run_bot references from build/. (stip@chromium.org) https://crrev.com/43666ad9e598889b78bef2adef20c135c238e7db Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/875a01234f836b09184a2844415ce07cc508db11 Enable Gerrit CQ on depot_tools project. (tandrii@chromium.org) R=tandrii@chromium.org,stip@chromium.org,andybons@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org BUG= 598907 , 619045 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2143103002 [modify] https://crrev.com/f5f911ec72c893d9ce8150547ca4fe4a7f02e3a1/infra/config/recipes.cfg
,
Jul 28 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jbudorick@chromium.org
, Mar 29 2016