New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598907 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
gone, assign your bugs elsewhere :)
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Get rid of android recipe_autogen recipes

Project Member Reported by jbudorick@chromium.org, Mar 29 2016

Issue description

they're recipes that still rely on bb_run_bot.py :(

build/scripts/slave/recipes$ grep bb_run_bot ./* -rl
./chromium.fyi.misc_block.recipe_autogen.expected/Android_Asan_Builder_Tests__dbg_.json
./chromium.fyi.misc_block.recipe_autogen.expected/Android_ChromeDriver_Tests__dbg_.json
./chromium.fyi.misc_block.recipe_autogen.py
./chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_5_.json
./chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_6_.json
./chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_9_.json
./chromium.gpu.recipe_autogen.py
 
Cc: mikec...@chromium.org
+mikecase, who had a partial recipe for chromedriver implemented prior to the autogen stuff.

Comment 2 by stip@chromium.org, Mar 30 2016

Cc: bpastene@chromium.org
Owner: stip@chromium.org
Cc: siev...@chromium.org jbudorick@chromium.org stip@chromium.org luqui@chromium.org kbr@chromium.org martiniss@chromium.org
 Issue 551137  has been merged into this issue.

Comment 4 by stip@chromium.org, Mar 30 2016

I'll take chromium.gpu, and bpastene@ will take chromium.fyi.
I'll work on fyi today.

Comment 6 by stip@chromium.org, Mar 30 2016

Just checking: this involved extracting the logic out of bb_run_bot into the recipe, correct?
Yeah, it will. bb_run_bot should not be called from recipes.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25aea02e9f3b8e141c4c9eb2db34c3aa165a40f7

commit 25aea02e9f3b8e141c4c9eb2db34c3aa165a40f7
Author: bpastene <bpastene@chromium.org>
Date: Thu Mar 31 01:13:09 2016

List src-side tests for Android Asan Builder Tests on chromium.fyi.

BUG= 598907 

Review URL: https://codereview.chromium.org/1849493002

Cr-Commit-Position: refs/heads/master@{#384181}

[modify] https://crrev.com/25aea02e9f3b8e141c4c9eb2db34c3aa165a40f7/testing/buildbot/chromium.fyi.json

Ping mikecase@: what's the status of the chromedriver recipe mentioned in comment #1? Are you still working on it? If not, let me know and I'll pick it up.
I'll stopped working on it because I thought the auto-gen recipes made my work no longer necessary. I can pick it back up and I'll prioritize working on it.

Comment 12 by stip@chromium.org, Apr 7 2016

Status: Started (was: Untriaged)
Components: Infra>Client>Android
Labels: -Infra-Android

Comment 14 by stip@chromium.org, Jun 2 2016

mikecase@: looks like the GPU bots have been converted and only chromedriver is left. Have you had a chance to look into it?
I have a CL slowly getting through code review for it. Got distracted by another project, but after I finish it, I'll return to the Chromedriver recipe.
https://codereview.chromium.org/1274723004
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/8d17b9874ec74054e26e9bb273f27da529379baf

commit 8d17b9874ec74054e26e9bb273f27da529379baf
Author: stip <stip@chromium.org>
Date: Tue Jul 12 17:53:18 2016

Switch chromedriver to new recipe, remove bb_run_bot references from build/.

BUG= 598907 , 619045 

Review-Url: https://codereview.chromium.org/2143503002

[modify] https://crrev.com/8d17b9874ec74054e26e9bb273f27da529379baf/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/8d17b9874ec74054e26e9bb273f27da529379baf/scripts/master/recipe_converter.py
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.expected/Android_ChromeDriver_Tests__dbg_.json
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.expected/builder_not_in_dispatch_directory.json
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_5_.json
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_6_.json
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/Android_Debug__Nexus_9_.json
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.expected/builder_not_in_dispatch_directory.json
[delete] https://crrev.com/67cab3707a85c6a649e98c310447506e084846a1/scripts/slave/recipes/chromium.gpu.recipe_autogen.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/f5f911ec72c893d9ce8150547ca4fe4a7f02e3a1

commit f5f911ec72c893d9ce8150547ca4fe4a7f02e3a1
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 12 18:32:20 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8d17b9874ec74054e26e9bb273f27da529379baf Switch chromedriver to new recipe, remove bb_run_bot references from build/. (stip@chromium.org)
  https://crrev.com/43666ad9e598889b78bef2adef20c135c238e7db Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/875a01234f836b09184a2844415ce07cc508db11 Enable Gerrit CQ on depot_tools project. (tandrii@chromium.org)

R=tandrii@chromium.org,stip@chromium.org,andybons@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 598907 , 619045 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2143103002

[modify] https://crrev.com/f5f911ec72c893d9ce8150547ca4fe4a7f02e3a1/infra/config/recipes.cfg

Comment 20 by stip@chromium.org, Jul 28 2016

Status: Fixed (was: Started)

Sign in to add a comment