New issue
Advanced search Search tips

Issue 598901 link

Starred by 4 users
Status: Verified
Owner:
michae...@chromium.org
Closed: Jul 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocking:
issue 546834
issue 614589



Sign in to add a comment

[Device] Update icons

Project Member Reported by bettes@chromium.org, Mar 29 2016 
*CROS ONLY*

Confirm the following icons are being used: 

Touchpad: icons:touch-app
Keyboard: WAI (hardware:keyboard)
Display: hardware:desktop-windows
Battery: device:battery-std
Mouse and touchpad: hardware:mouse

Let me know if there are other devices to consider.
Screen Shot 2016-03-29 at 4.08.44 PM.png
42.4 KB View Download

Comment 1 by michae...@chromium.org, May 15 2016

Blocking: 546834
Labels: OS-Chrome
Status: Started (was: Assigned)

Comment 2 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-Device

Comment 3 by tbuck...@chromium.org, May 24 2016

Labels: -Pri-2 Pri-1

Comment 4 by tbuck...@chromium.org, May 25 2016

Labels: Hotlist-MD-DevBlocker

Comment 5 by tbuck...@chromium.org, May 25 2016

Blocking: 614589

Comment 6 by tbuck...@chromium.org, May 25 2016

Labels: -Hotlist-MD-DevBlocker
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b

commit fe807f4f43fc317d93df7a8e48a7c62caf42fb4b
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Jul 19 22:16:38 2016

MD Settings: Add mouse settings, update pointer settings

Adds mouse settings and touchpad sensitivity settings.

Updates the pointer icon and title in the device page based on whether a
mouse, touchpad, or both are connected. Shows headers separating the
mouse and touchpad sections on the pointers subpage when both are visible.

If the subpage is open and all mice/touchpads are disconnected, the subpage
closes.

Also address some flakiness I found in the tests.

Screenshots in the bug.

BUG= 612986 , 598901 
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2110833003
Cr-Commit-Position: refs/heads/master@{#406396}

[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/app/settings_strings.grdp
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/compiled_resources2.gyp
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/device_page_browser_proxy.js
[add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/pointers.html
[add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/pointers.js
[delete] https://crrev.com/5aa2d8c58b4dbb74437652c32dcdfec5a323db44/chrome/browser/resources/settings/device_page/touchpad.html
[delete] https://crrev.com/5aa2d8c58b4dbb74437652c32dcdfec5a323db44/chrome/browser/resources/settings/device_page/touchpad.js
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/settings_resources.grd
[add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.cc
[add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.h
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/test/data/webui/settings/device_page_tests.js

Comment 8 by michae...@chromium.org, Jul 21 2016

Status: Fixed (was: Started)
battery/power isn't implemented yet, but the rest are now correct. thanks!

Comment 9 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 10 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 11 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 12 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 13 by rookrishna@chromium.org, Feb 6 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment