New issue
Advanced search Search tips

Issue 598897 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Use stricter Python style checks in webkitpy.

Project Member Reported by qyears...@chromium.org, Mar 29 2016

Issue description

There are more pylint checks which can be enabled in webkitpy/pylintrc which could potentially be helpful --; some pylint checks that are currently disabled that we may want to enable include:

# C0103: Invalid name (list of exceptions can be set)
# C0301: Line too long (max length can be set)
# C0302: Too many lines in module (max length can be set)
# I0010: Unable to consider inline option (possibly improperly formatted pylint: disable pragma)
# R0801: Similar lines in other files
# W0212: Access to a protected member (with underscore) of a client class
# W0402: Uses of a deprecated module
# W0404: Reimported module (imported multiple times)
# W0603: Using the global statement
# W0703: Broad except statement (except Exception)
# W1201: Logging statements that don't format string format arguments as logging function parameters

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc&l=67

Additionally, the pylint runner function in webkitpy.style.checkers.python only prints errors, not warnings, so pylint warnings are currently ignored in practice; but as long as all of the warnings are things that we want to pay attention to, then it may be helpful to print warnings too.

Any thoughts (or checks above that aren't worth enabling)?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b75beff33786a002c942e2a571e87c9a0b344f86

commit b75beff33786a002c942e2a571e87c9a0b344f86
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Mar 30 17:25:38 2016

Use newline-separated human-readable pylint check names in webkitpy/pylintrc.

Reason: This may make it easier to see what's disabled and enable some of the checks.

BUG= 598897 

Review URL: https://codereview.chromium.org/1845453002

Cr-Commit-Position: refs/heads/master@{#384015}

[modify] https://crrev.com/b75beff33786a002c942e2a571e87c9a0b344f86/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b75beff33786a002c942e2a571e87c9a0b344f86

commit b75beff33786a002c942e2a571e87c9a0b344f86
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Mar 30 17:25:38 2016

Use newline-separated human-readable pylint check names in webkitpy/pylintrc.

Reason: This may make it easier to see what's disabled and enable some of the checks.

BUG= 598897 

Review URL: https://codereview.chromium.org/1845453002

Cr-Commit-Position: refs/heads/master@{#384015}

[modify] https://crrev.com/b75beff33786a002c942e2a571e87c9a0b344f86/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc

Status: Assigned (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a8ce44839c159ddfd9090db7ba88f89d6ef517

commit b6a8ce44839c159ddfd9090db7ba88f89d6ef517
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Mar 31 16:16:55 2016

Remove unused imports in webkitpy.

This was done with `autoflake -i --remove-all-unused-imports`,
with minor editing afterwards, including in common/net/__init__.py,
where importing is done in order to expose a public API.

BUG= 598897 

Review URL: https://codereview.chromium.org/1847613002

Cr-Commit-Position: refs/heads/master@{#384300}

[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/filereader_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/style/optparser.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/main.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/__init__.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/abstractstep.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a

commit 8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a
Author: wkorman <wkorman@chromium.org>
Date: Thu Mar 31 23:39:15 2016

Revert of Remove unused imports in webkitpy. (patchset #1 id:1 of https://codereview.chromium.org/1847613002/ )

Reason for revert:
http://crbug.com/599579 - Breaks auto-rebaseline bot.

Original issue's description:
> Remove unused imports in webkitpy.
>
> This was done with `autoflake -i --remove-all-unused-imports`,
> with minor editing afterwards, including in common/net/__init__.py,
> where importing is done in order to expose a public API.
>
> BUG= 598897 
>
> Committed: https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517
> Cr-Commit-Position: refs/heads/master@{#384300}

TBR=dpranke@chromium.org,ojan@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 598897 

Review URL: https://codereview.chromium.org/1846093002

Cr-Commit-Position: refs/heads/master@{#384432}

[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/filereader_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/style/optparser.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/main.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/__init__.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/abstractstep.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/8f90bed6f466420c92ab2a6ef5eb7625a7a27d9a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Comment 6 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest Blink>Infra
Blink>ToolsTest renamed to Blink>Infra
Project Member

Comment 9 by bugdroid1@chromium.org, May 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489de09049a465bb7d3bdc908d04acd6821ae519

commit 489de09049a465bb7d3bdc908d04acd6821ae519
Author: qyearsley <qyearsley@chromium.org>
Date: Sat May 07 18:23:03 2016

Empty webkitpy/common/net/buildbot/__init__.py and  update imports.

BUG= 598897 

Review-Url: https://codereview.chromium.org/1953463002
Cr-Commit-Position: refs/heads/master@{#392265}

[modify] https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[rename] https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
[delete] https://crrev.com/4373cd5db37927e07c87a3faf513682c88c13063/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py
[rename] https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py
[rename] https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py
[modify] https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
[modify] https://crrev.com/489de09049a465bb7d3bdc908d04acd6821ae519/third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py

Project Member

Comment 10 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76

commit 33305ad2a855ad0269e5b33bc1948e8c7d8e7a76
Author: qyearsley <qyearsley@chromium.org>
Date: Wed May 11 21:53:52 2016

Remove unused imports in webkitpy with using autoflake.

This is a slightly more conservative re-do of
https://codereview.chromium.org/1847613002.

For this CL, I ran `autoflake -r -i webkitpy` and then undid any changes
to anything in thirdparty or __init__.py files (which can be dealt
with separately).

After https://codereview.chromium.org/1847613002, the
problem that happened was due to removing the imports in
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py,
which made it so that multicommandtool was unable to find the subclasses
of Command, which broke webkit-patch (which is used by the auto-rebaseline
bot).

This CL doesn't remove anything from webkitpy/tool/commands/__init__.py
or webkitpy/tool/main.py.

BUG= 598897 

Review-Url: https://codereview.chromium.org/1950213002
Cr-Commit-Position: refs/heads/master@{#393077}

[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/filereader_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/style/optparser.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c236f5f3e81f364347723909d45971eb713400

commit 32c236f5f3e81f364347723909d45971eb713400
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Jun 02 17:10:42 2016

Run format-webkit on webkitpy code (without string conversion).

This is a follow-up to http://crrev.com/1839193004; the auto-formatting done
by this CL is similar to that done in that CL, except ./format-webkitpy calls
autopep8 with --aggressive.

Specifically:

  ./format-webkitpy --leave-strings-alone --no-backups $(find . -name '*.py' | grep -v thirdparty)

Also ran the same command on the Python files in Tools/Scripts.

BUG= 598897 

Review-Url: https://codereview.chromium.org/2014063002
Cr-Commit-Position: refs/heads/master@{#397453}

[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/lint-test-expectations
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/print-json-test-results
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/print-stale-test-expectations-entries
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/print-test-ordering
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/run-bindings-tests
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkit-patch
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/logtesting.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/systemhost_mock.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/formatter/main.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_input.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_results.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/xml.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/filereader.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/filereader_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/filter.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/filter_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/style/optparser.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commandtest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/helpcommand.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py
[modify] https://crrev.com/32c236f5f3e81f364347723909d45971eb713400/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3621e6f24d746662472d3e14db605d4dbb66e7c5

commit 3621e6f24d746662472d3e14db605d4dbb66e7c5
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jun 03 04:52:06 2016

Fix pylint unused-* warnings in webkitpy/tool.

This includes:
  unused-variable
  unused-argument
  unused-import

In some cases, unused arguments are there for method because the argument is required by the superclass or may be used in subclasses; in these cases I added a pylint disable pragma comment.

BUG= 598897 

Review-Url: https://codereview.chromium.org/2019923002
Cr-Commit-Position: refs/heads/master@{#397636}

[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py
[modify] https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5277f6feda049f0941928ae198ed8fed41e15a2

commit b5277f6feda049f0941928ae198ed8fed41e15a2
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jun 17 05:44:33 2016

Use an explicit list of webkit-patch commands instead of using auto-discovery.

This is a followup to http://crrev.com/1950773002 and related CLs,
which removed remove imports from other __init__.py files; after this,
all of the __init__.py files in webkitpy are empty.

Before this CL, webkit-patch relies on all commands being imported (by
importing the package webkitpy.tool.commands) and then discovering all
subclasses of command using the magic method __subclasses__.

This CL makes it so that commands that are part of webkit-patch are
explicitly listed, and there is no class discovery.

BUG= 598897 

Review-Url: https://codereview.chromium.org/2070333003
Cr-Commit-Position: refs/heads/master@{#400369}

[modify] https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py
[modify] https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool.py
[modify] https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py
[modify] https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0afd0716fe7c94d890cf94b8771692bd827884e

commit e0afd0716fe7c94d890cf94b8771692bd827884e
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Jun 17 06:18:10 2016

Revert of Use an explicit list of webkit-patch commands instead of using auto-discovery. (patchset #2 id:20001 of https://codereview.chromium.org/2070333003/ )

Reason for revert:
Broke rebaseline-o-matic because commands are not bound to tool.

Original issue's description:
> Use an explicit list of webkit-patch commands instead of using auto-discovery.
>
> This is a followup to http://crrev.com/1950773002 and related CLs,
> which removed remove imports from other __init__.py files; after this,
> all of the __init__.py files in webkitpy are empty.
>
> Before this CL, webkit-patch relies on all commands being imported (by
> importing the package webkitpy.tool.commands) and then discovering all
> subclasses of command using the magic method __subclasses__.
>
> This CL makes it so that commands that are part of webkit-patch are
> explicitly listed, and there is no class discovery.
>
> BUG= 598897 
>
> Committed: https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2
> Cr-Commit-Position: refs/heads/master@{#400369}

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 598897 

Review-Url: https://codereview.chromium.org/2075073002
Cr-Commit-Position: refs/heads/master@{#400376}

[modify] https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py
[modify] https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool.py
[modify] https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py
[modify] https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b8faf8a0ea9a61359b5866cacec5d6da573c82a

commit 1b8faf8a0ea9a61359b5866cacec5d6da573c82a
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jun 17 20:23:16 2016

Reland of Use an explicit list of webkit-patch commands instead of using auto-discovery. (patchset #1 id:1 of https://codereview.chromium.org/2075073002/ )

Reason for revert:
I believe the problem was that the commands weren't passed to the MultiCommandTool constructor, so command.bind_to_tool(multi_command_tool) wasn't called for the commands.

Original issue's description:
> Revert of Use an explicit list of webkit-patch commands instead of using auto-discovery. (patchset #2 id:20001 of https://codereview.chromium.org/2070333003/ )
>
> Reason for revert:
> Broke rebaseline-o-matic because commands are not bound to tool.
>
> Original issue's description:
> > Use an explicit list of webkit-patch commands instead of using auto-discovery.
> >
> > This is a followup to http://crrev.com/1950773002 and related CLs,
> > which removed remove imports from other __init__.py files; after this,
> > all of the __init__.py files in webkitpy are empty.
> >
> > Before this CL, webkit-patch relies on all commands being imported (by
> > importing the package webkitpy.tool.commands) and then discovering all
> > subclasses of command using the magic method __subclasses__.
> >
> > This CL makes it so that commands that are part of webkit-patch are
> > explicitly listed, and there is no class discovery.
> >
> > BUG= 598897 
> >
> > Committed: https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2
> > Cr-Commit-Position: refs/heads/master@{#400369}
>
> TBR=dpranke@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 598897 
>
> Committed: https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e
> Cr-Commit-Position: refs/heads/master@{#400376}

TBR=dpranke@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 598897 

Review-Url: https://codereview.chromium.org/2073893004
Cr-Commit-Position: refs/heads/master@{#400487}

[modify] https://crrev.com/1b8faf8a0ea9a61359b5866cacec5d6da573c82a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py
[modify] https://crrev.com/1b8faf8a0ea9a61359b5866cacec5d6da573c82a/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool.py
[modify] https://crrev.com/1b8faf8a0ea9a61359b5866cacec5d6da573c82a/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py
[modify] https://crrev.com/1b8faf8a0ea9a61359b5866cacec5d6da573c82a/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79192ab645a00c75263cc7175e962c0cbba1c187

commit 79192ab645a00c75263cc7175e962c0cbba1c187
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Jul 26 15:57:17 2016

Enable stricter pylint checks.

The webkitpy presubmit only checks modified lines, so if we enable some pylint checks that the codebase doesn't currently conform to, that will be OK -- this just means that as code is edited in the future, it can slowly be changed to pass these checks, and we can refine the pylint checks over time.

BUG= 598897 

Review-Url: https://codereview.chromium.org/2120083002
Cr-Commit-Position: refs/heads/master@{#407816}

[modify] https://crrev.com/79192ab645a00c75263cc7175e962c0cbba1c187/third_party/WebKit/Tools/Scripts/webkitpy/pylintrc

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c097eab9977221aff1c8155c9f907fdb529dd92

commit 0c097eab9977221aff1c8155c9f907fdb529dd92
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jul 29 21:08:58 2016

Change logging statements to not use the "%" operator.

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2, \3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2, \3)/

BUG= 598897 

Review-Url: https://codereview.chromium.org/2188623002
Cr-Commit-Position: refs/heads/master@{#408745}

[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_mock.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/style/filereader.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/style/main.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/style/patchreader.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
[modify] https://crrev.com/0c097eab9977221aff1c8155c9f907fdb529dd92/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46515a0de0eae9c36d27ec55ed41d7b07dee335f

commit 46515a0de0eae9c36d27ec55ed41d7b07dee335f
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Aug 09 17:34:45 2016

Remove usage of wildcard imports from webkitpy.

This fixes all of the "unused-wildcard-import" pylint warnings, which
were recently enabled in http://crrev.com/2120083002.

The rationale for enabling this warning is that wildcard imports can make
it less clear where all of the imported names come from. Explicitly listing
all names to import makes it a bit clearer.

BUG= 598897 

Review-Url: https://codereview.chromium.org/2201653002
Cr-Commit-Position: refs/heads/master@{#410728}

[modify] https://crrev.com/46515a0de0eae9c36d27ec55ed41d7b07dee335f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py
[modify] https://crrev.com/46515a0de0eae9c36d27ec55ed41d7b07dee335f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
[modify] https://crrev.com/46515a0de0eae9c36d27ec55ed41d7b07dee335f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py
[modify] https://crrev.com/46515a0de0eae9c36d27ec55ed41d7b07dee335f/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py
[modify] https://crrev.com/46515a0de0eae9c36d27ec55ed41d7b07dee335f/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

Labels: -Type-Bug Type-Feature
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Summary: Use stricter Python style checks in webkitpy. (was: Use stricter Python style checks in webkitpy)
To make this clearer, I'd like to file a separate issue to track clean-up changes made to make the codebase comply with all style checks: bug 643937.

Meanwhile, as of r407816, this issue can be considered fixed, since stricter pylint checks are now enabled for new code in webkitpy.

Sign in to add a comment