New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598894 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Android: Revisit RWHVAndroid surface locking and visibility logic and add tests

Project Member Reported by siev...@chromium.org, Mar 29 2016

Issue description

The logic related to dealing with the visible frontbuffer/compositing surface (i.e. the current SurfaceLayer + tiles) interacts with
- the readback system incl. locking API (for async etc1 compression of tabs being hidden)
- the activity state (paused vs. running)
- the window visibility

We try to do the right thing wrt ensuring renderers are hidden when it makes sense but try to minimize glitches by keeping the frontbuffer in some cases.

It was recently observed that we might not handle all transitions correctly. Also, with custom tabs and attaching to different WindowAndroids (through which the signals go) there are new sequences which are not tested and might not work as expected. Overall the logic looks very brittle.

We should revisit this and add some tests (content_unittests, i.e. we can probably do a unit test for RWHVAndroid where we mock the signals from WindowAndroid).


 
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 30 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by cmasso@google.com, Mar 14 2018

Labels: -Type-Bug Type-Task

Comment 3 by cmasso@google.com, Mar 14 2018

Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment