New issue
Advanced search Search tips

Issue 598891 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

cr_cronet.py does not start EmbeddedTestServer using --additional-apk

Project Member Reported by xunji...@chromium.org, Mar 29 2016

Issue description

1. Sync to ToT
2. run CronetUrlRequestContextTest tests using cr_cronet.py
3. Will get following error:
org.chromium.net.test.EmbeddedTestServer$EmbeddedTestServerFailure: Unable to bind to the EmbeddedTestServer service.

Need to modify cr_cronet.py to launch the additional apk in which EmbeddedTestServer is in.


 
Components: Internals>Network>Library
Cc: pauljensen@chromium.org
Paul, you mentioned that you had a patch to do this. Do you want to take this?
Cc: -pauljensen@chromium.org
Owner: pauljensen@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4208479e0d831431c74fb2a61599d35738b9f0ec

commit 4208479e0d831431c74fb2a61599d35738b9f0ec
Author: pauljensen <pauljensen@chromium.org>
Date: Wed Apr 06 13:43:31 2016

[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

Without this many Cronet tests will fail.

BUG= 598891 

Review URL: https://codereview.chromium.org/1843183002

Cr-Commit-Position: refs/heads/master@{#385448}

[modify] https://crrev.com/4208479e0d831431c74fb2a61599d35738b9f0ec/components/cronet/tools/cr_cronet.py

Status: Fixed (was: Started)

Sign in to add a comment