New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598885 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: locations don't work when source map contains empty mapping array

Project Member Reported by kozyatinskiy@chromium.org, Mar 29 2016

Issue description

BlackboxManager produces exception when loaded source map contains empty mappings array.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2baf75826c17f0470fc5f30a7bad569648059364

commit 2baf75826c17f0470fc5f30a7bad569648059364
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Mar 30 01:24:35 2016

[DevTools] Check mappings.length in  BlackboxManager on SourceMap loaded

R=pfeldman@chromium.org
BUG= 598885 

Review URL: https://codereview.chromium.org/1837283002

Cr-Commit-Position: refs/heads/master@{#383892}

[modify] https://crrev.com/2baf75826c17f0470fc5f30a7bad569648059364/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Labels: Merge-Request-50
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2baf75826c17f0470fc5f30a7bad569648059364

commit 2baf75826c17f0470fc5f30a7bad569648059364
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Mar 30 01:24:35 2016

[DevTools] Check mappings.length in  BlackboxManager on SourceMap loaded

R=pfeldman@chromium.org
BUG= 598885 

Review URL: https://codereview.chromium.org/1837283002

Cr-Commit-Position: refs/heads/master@{#383892}

[modify] https://crrev.com/2baf75826c17f0470fc5f30a7bad569648059364/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Comment 4 Deleted

Status: Assigned (was: Fixed)

Comment 6 by tin...@google.com, Mar 31 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 4 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57f2207071dbad1d29471f622ab3299fb025c3da

commit 57f2207071dbad1d29471f622ab3299fb025c3da
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Apr 04 17:22:10 2016

[DevTools] Check mappings.length in  BlackboxManager on SourceMap loaded

R=pfeldman@chromium.org
BUG= 598885 

Review URL: https://codereview.chromium.org/1837283002

Cr-Commit-Position: refs/heads/master@{#383892}
(cherry picked from commit 2baf75826c17f0470fc5f30a7bad569648059364)

Review URL: https://codereview.chromium.org/1856053002 .

Cr-Commit-Position: refs/branch-heads/2661@{#475}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/57f2207071dbad1d29471f622ab3299fb025c3da/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Status: Fixed (was: Assigned)

Sign in to add a comment