MD Settings: make sliders consistent |
||||||||||||||
Issue descriptionThere's no spec for the material slider, and the "preview" cards show conflicting options: * Customize fonts: labels underneath slider, uses pips for snap points * Device: labels left and right of slider, doesn't use pips for snap points * Displays: no labels, uses pips for snap points Is one of these preferred? Could we get some guidance, and eventually a spec?
,
Mar 30 2016
For Device: * auto-repeat options have not been implemented. You can check out the slider in Options though. Delay before repeat has 7 options: [2000, 1500, 1000, 500, 300, 200, 150] in ms Auto-repeat rate has 9 options, the numbers are actually the repeat interval (1/rate): [2000, 1000, 500, 300, 200, 100, 50, 30, 20] in ms The slider in Options just uses equal spacing between ticks, rather than correlating with what the actual numbers are -- so the slider looks as if the values were 1-9. I think that's reasonable given the range of values.
,
May 14 2016
,
May 24 2016
,
May 24 2016
My preference is to: * show pips when there are < 10 distinct values we should snap to (delay before repeat, auto-repeat rate, mouse/trackpad speed) but hide them when there are more (font size) * show labels underneath the slider (Tiny/Huge for font size, Short/Long for delay before repeat, Slow/Fast for auto-repeat rate, etc) * remove the fill color, since it doesn't really make sense in any of these contexts Also, the display resolution should continue to be a dropdown as it is today (instead of a slider as in the mocks).
,
May 24 2016
And by "remove the fill color", I mean keep the circle blue but make the color of the line to the left/right of the circle gray.
,
May 27 2016
For the record, tom's comments in #5 seem reasonable to me. At this point, is there still need for a spec?
,
May 27 2016
,
May 27 2016
I'm in the middle of landing sliders for device settings, trying to keep them consistent with what we already have. I'll update them in another pass to conform to Tom's new guidelines. I'll upload a screenshot when it's ready.
,
May 27 2016
,
Jun 29 2016
issue 612986 has screenshots of the new device subpage with sliders, they're mostly consistent with what we already have. setting issue to Available to go through and update the sliders with Tom's comments.
,
Jun 29 2016
,
Jun 29 2016
tbuckley@: are these changes still valid? - pips for < 10 values only - labels underneath - remove fill color
,
Jun 29 2016
Yep!
,
Jul 11 2016
,
Oct 14 2016
,
Nov 22 2016
,
Dec 10 2016
,
Dec 19 2016
,
Dec 20 2016
CL is up: https://codereview.chromium.org/2587913007/ Screenshots: Customize Fonts: https://screenshot.googleplex.com/f1VSc2tC6n4.png Touchpad: https://screenshot.googleplex.com/4az9WVo5qKd.png Display: https://screenshot.googleplex.com/Md7RXSkPuMs.png
,
Dec 20 2016
And last but not least: Keyboard: https://screenshot.googleplex.com/yu0xvVH2b2Y.png And that's all of our sliders.
,
Dec 20 2016
Thanks Steven! Per #5, we should show labels on the "Customize fonts" sliders (Tiny/Huge), and we'd like to use a dropdown instead of a slider for Display resolution.
,
Dec 20 2016
Tom, could you for the slider to dropdown request separately? That one is a bigger change. Thanks.
,
Dec 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26b1599ba3f24f4124d8d78227fb815dc1c2e696 commit 26b1599ba3f24f4124d8d78227fb815dc1c2e696 Author: stevenjb <stevenjb@chromium.org> Date: Tue Dec 27 20:53:03 2016 MD Settings: cr-slider: Make slider appearance consistent and clean up. This CL: * Switches display.html to use cr-slider (was only use of paper-slider) * Changes styling of cr-slider as follows: ** Slider bar is grey instead of active (left) portion being blue. ** Knob is always blue (even at leftmost position) ** Ticks are shown automatically if there are < 10 ** Labels are shown as part of cr-slider and shown below the slider See issue for screenshots. BUG= 598879 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2587913007 Cr-Commit-Position: refs/heads/master@{#440785} [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/compiled_resources2.gyp [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/display.js [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/keyboard.html [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/pointers.html [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/test/data/webui/cr_elements/cr_slider_tests.js [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/test/data/webui/settings/device_page_tests.js [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/ui/webui/resources/cr_elements/cr_slider/cr_slider.html [modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
,
Dec 28 2016
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by bettes@chromium.org
, Mar 29 2016