New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598879 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

MD Settings: make sliders consistent

Project Member Reported by michae...@chromium.org, Mar 29 2016

Issue description

There's no spec for the material slider, and the "preview" cards show conflicting options:

* Customize fonts: labels underneath slider, uses pips for snap points
* Device: labels left and right of slider, doesn't use pips for snap points
* Displays: no labels, uses pips for snap points

Is one of these preferred? Could we get some guidance, and eventually a spec?
 

Comment 1 by bettes@chromium.org, Mar 29 2016

Cc: dschuyler@chromium.org
Dave pointed the inconsistency before, thanks for bringing this issue back up. Generally, if we do use labels for desktop sliders, we should standardize one style for all areas of settings. With that said, some of these might be best served with a dropdown and not a slider. 

Customize fonts: 
* My mocks are out-of-date for this section. You should refer to dave's implementation for the latest: one slider to control all fonts. 

- how many intervals are there in "font size" and what's the numeric value of each? 

Device: 
- How do I surface the "enable auto-repeat" setting? Has this been implemented yet? 
- Are pips needed for this setting? If so, how many intervals and there numeric value

Displays: 
- how many intervals are there in "font size" and what's the numeric value of each? 

For Device:

* auto-repeat options have not been implemented. You can check out the slider in Options though.
Delay before repeat has 7 options: [2000, 1500, 1000, 500, 300, 200, 150] in ms
Auto-repeat rate has 9 options, the numbers are actually the repeat interval (1/rate): [2000, 1000, 500, 300, 200, 100, 50, 30, 20] in ms

The slider in Options just uses equal spacing between ticks, rather than correlating with what the actual numbers are -- so the slider looks as if the values were 1-9. I think that's reasonable given the range of values.
Blocking: 611949
Labels: Hotlist-MD-Settings-Bluetooth
My preference is to:
* show pips when there are < 10 distinct values we should snap to (delay before repeat, auto-repeat rate, mouse/trackpad speed) but hide them when there are more (font size)
* show labels underneath the slider (Tiny/Huge for font size, Short/Long for delay before repeat, Slow/Fast for auto-repeat rate, etc)
* remove the fill color, since it doesn't really make sense in any of these contexts

Also, the display resolution should continue to be a dropdown as it is today (instead of a slider as in the mocks).
And by "remove the fill color", I mean keep the circle blue but make the color of the line to the left/right of the circle gray.

Comment 7 by bettes@chromium.org, May 27 2016

For the record, tom's comments in #5 seem reasonable to me. At this point, is there still need for a spec? 

Comment 8 by bettes@chromium.org, May 27 2016

Status: Started (was: Assigned)
I'm in the middle of landing sliders for device settings, trying to keep them consistent with what we already have. I'll update them in another pass to conform to Tom's new guidelines.

I'll upload a screenshot when it's ready.
Owner: michae...@chromium.org
Summary: MD Settings: make sliders consistent (was: MD Settings: need consistent material slider design)
Status: Available (was: Started)
 issue 612986  has screenshots of the new device subpage with sliders, they're mostly consistent with what we already have. setting issue to Available to go through and update the sliders with Tom's comments.

Comment 12 by dbeam@chromium.org, Jun 29 2016

Cc: dbeam@chromium.org

Comment 13 by dbeam@chromium.org, Jun 29 2016

Cc: tbuck...@chromium.org
tbuckley@: are these changes still valid?

- pips for < 10 values only
- labels underneath
- remove fill color
Yep!
Labels: -Hotlist-MD-Settings-Bluetooth Hotlist-MD-Settings-General
Cc: michae...@chromium.org
Owner: steve...@chromium.org
Status: Assigned (was: Available)
Labels: M-57
Blocking: 671375
Status: Started (was: Assigned)
And last but not least:

Keyboard: https://screenshot.googleplex.com/yu0xvVH2b2Y.png

And that's all of our sliders.

Thanks Steven! Per #5, we should show labels on the "Customize fonts" sliders (Tiny/Huge), and we'd like to use a dropdown instead of a slider for Display resolution.
Tom, could you for the slider to dropdown request separately? That one is a
bigger change. Thanks.
Project Member

Comment 24 by bugdroid1@chromium.org, Dec 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b1599ba3f24f4124d8d78227fb815dc1c2e696

commit 26b1599ba3f24f4124d8d78227fb815dc1c2e696
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Dec 27 20:53:03 2016

MD Settings: cr-slider: Make slider appearance consistent and clean up.

This CL:
* Switches display.html to use cr-slider (was only use of paper-slider)
* Changes styling of cr-slider as follows:
** Slider bar is grey instead of active (left) portion being blue.
** Knob is always blue (even at leftmost position)
** Ticks are shown automatically if there are < 10
** Labels are shown as part of cr-slider and shown below the slider

See issue for screenshots.

BUG= 598879 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2587913007
Cr-Commit-Position: refs/heads/master@{#440785}

[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/compiled_resources2.gyp
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/device_page/pointers.html
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/test/data/webui/cr_elements/cr_slider_tests.js
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
[modify] https://crrev.com/26b1599ba3f24f4124d8d78227fb815dc1c2e696/ui/webui/resources/cr_elements/cr_slider/cr_slider.js

Status: Fixed (was: Started)

Sign in to add a comment