Improve CVC detection in order to increase the rate at which we can offer to upload credit cards |
|||||||||
Issue descriptionWhen the autofill component detects that a user entered a credit card in a form, it offers to save that card locally for the user. We're experimenting with having it offer to upload to Google Payments instead if the user has the Payments integration setting enabled. Uploading requires that we also have detected an address and a CVC in the checkout flow. Currently, the most frequent impediment to offering upload is the lack of a detected CVC. If we can improve the rate at which we correctly classify CVC fields, we can improve the rate at which we offer upload.
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c17f62a8425b4e4547255495073e673312a86b6 commit 8c17f62a8425b4e4547255495073e673312a86b6 Author: sebsg <sebsg@chromium.org> Date: Wed Mar 16 18:00:04 2016 Added the following cvc regexes to make the heuristics work on sites of the top 100. "security.?number", "card.?pin" and "c-v-v" to fix net-a-porter.com, efollet.com and m.jcp.com respectively. BUG= 595096 TEST=FormStructureBrowserTest Review URL: https://codereview.chromium.org/1807463003 Cr-Commit-Position: refs/heads/master@{#381493} [rename] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/141_checkout_cc_keurig.com.html [add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/142_cc_checkout_netaporter.com.html [add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/143_cc_checkout_efollet.com.html [add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/input/144_cc_checkout_m_jcp.com.html [add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/141_checkout_cc_keurig.com.out [add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/142_cc_checkout_netaporter.com.out [add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/143_cc_checkout_efollet.com.out [add] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/chrome/test/data/autofill/heuristics/output/144_cc_checkout_m_jcp.com.out [modify] https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6/components/autofill/core/browser/autofill_regex_constants.cc
,
Mar 29 2016
,
Mar 30 2016
Could you please let me know whether this change is for all OS or any specific OS?
,
Mar 30 2016
,
Mar 30 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 31 2016
Please merge your change to M50 branch 2661 by Friday 5:00 PM PST so we can take it for next week beta.
,
Apr 1 2016
It turns out that the first CL above depends on https://codereview.chromium.org/1754793003/. I'd like to add that to the merge request. It's a huge delta but in reality is a one line change. Everything else is a new pair of test files (input and expected output). I checked with the author of the CLs (sebsg) and he agreed that both are safe to merge.
,
Apr 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5a83da5b2571eeb25b61f4b4bd6424b0695fb33 commit d5a83da5b2571eeb25b61f4b4bd6424b0695fb33 Author: sebsg <sebsg@chromium.org> Date: Fri Mar 04 15:22:41 2016 [Autofill] Fix heuristics to detect cc-number on united.com. The reason was that one of the cc-number fields has type="password", and we didn't support this type for cc-number fields. BUG= 591166 Review URL: https://codereview.chromium.org/1754793003 Cr-Commit-Position: refs/heads/master@{#379287} [add] https://crrev.com/d5a83da5b2571eeb25b61f4b4bd6424b0695fb33/chrome/test/data/autofill/heuristics/input/138_cc_checkout_united.com.html [add] https://crrev.com/d5a83da5b2571eeb25b61f4b4bd6424b0695fb33/chrome/test/data/autofill/heuristics/output/138_cc_checkout_united.com.out [delete] https://crrev.com/b9fa69cad6684fcc4d045dae9ba097ae5ff77773/chrome/test/data/autofill/heuristics/output/27_checkout_cc_keurig.com.out [modify] https://crrev.com/d5a83da5b2571eeb25b61f4b4bd6424b0695fb33/components/autofill/core/browser/credit_card_field.cc
,
Apr 2 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Apr 4 2016
Please merge your change to M50 branch 2661 by 5:00 PM on Monday, 04/04/16 so we can take it for next week beta. Thank you.
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71634987bfffd49d609d37ae4a9747c17b6e291e commit 71634987bfffd49d609d37ae4a9747c17b6e291e Author: Justin Donnelly <jdonnelly@chromium.org> Date: Mon Apr 04 17:32:09 2016 [Autofill] Fix heuristics to detect cc-number on united.com. The reason was that one of the cc-number fields has type="password", and we didn't support this type for cc-number fields. BUG= 591166 , 598873 Review URL: https://codereview.chromium.org/1754793003 Cr-Commit-Position: refs/heads/master@{#379287} (cherry picked from commit d5a83da5b2571eeb25b61f4b4bd6424b0695fb33) Review URL: https://codereview.chromium.org/1859633002 . Cr-Commit-Position: refs/branch-heads/2661@{#476} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [add] https://crrev.com/71634987bfffd49d609d37ae4a9747c17b6e291e/chrome/test/data/autofill/heuristics/input/138_cc_checkout_united.com.html [add] https://crrev.com/71634987bfffd49d609d37ae4a9747c17b6e291e/chrome/test/data/autofill/heuristics/output/138_cc_checkout_united.com.out [modify] https://crrev.com/71634987bfffd49d609d37ae4a9747c17b6e291e/components/autofill/core/browser/credit_card_field.cc
,
Apr 4 2016
The other two merges: https://codereview.chromium.org/1860613002/ https://codereview.chromium.org/1856093002/
,
Apr 4 2016
,
Jun 27 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jdonnelly@chromium.org
, Mar 29 2016