The MSAN bots are probably ready to graduate from the memory.fyi waterfall to the memory waterfall. This bug will track the requirements and progress for this move. Outstanding issues off the top of my head: - It looks like we have MSAN trybots ( bug 433971 ) but they probably do not run by default. They should if they are going to become tree closers. Additional machine capacity may be needed. - Update https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium and http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff to reflect this move. - It would be nice to fix bug 526188 - ASAN/MSAN should run webkit_tests (or blink_tests or whatever they are called)
Note: I'd love this to happen, really! My team is ready to help on the msan side, but we don't have cycles for heavy lifting on the Chromium side.
Issue 700574 has been merged into this issue.
The bot will keep breaking until this happens :-(
I asked infra-dev for help here: https://groups.google.com/a/chromium.org/forum/#!topic/infra-dev/lSskem7yroY
We may be able to do this ourselves. One potentially tricky thing is this is removing the last bots from memory.full.
I'll do this today. I need some easy CLs to knock off ...
Thanks! FWIW, the cc_unittests redness is bug 709341 / bug 710484 . There's always 1 or 2 flaky browser_tests tests as well.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9acab5dd4495ba6eae78c05659ea09bb601405df commit 9acab5dd4495ba6eae78c05659ea09bb601405df Author: dpranke <dpranke@chromium.org> Date: Wed Apr 12 20:24:22 2017 Add new builders to the chromium.memory config files. We're shutting down the chromium.memory.full waterfall and moving the builders to the chromium.memory waterfall. This CL adds the entries for the new builders on chromium.memory and should be landed first. Once the build-side CL to actually switch the masters lands, and the masters are restarted, we can land the follow-up CL to remove the old entries. R=phajdan.jr@chromium.org, qyearsley@chromium.org BUG= 598859 Review-Url: https://codereview.chromium.org/2817623002 Cr-Commit-Position: refs/heads/master@{#464133} [modify] https://crrev.com/9acab5dd4495ba6eae78c05659ea09bb601405df/testing/buildbot/chromium.memory.json [modify] https://crrev.com/9acab5dd4495ba6eae78c05659ea09bb601405df/tools/mb/mb_config.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/c0e30882b56926a2669b333716cadeb907b7cc33 commit c0e30882b56926a2669b333716cadeb907b7cc33 Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Apr 13 01:38:40 2017 Migrate remaining builders from chromium.memory.full to chromium.memory. There are only the MSAN builders left on chromium.memory, and they aren't really being monitored. They are stable enough that we should just run them on the main chromium.memory waterfall, and shut down the chromium.memory.full master. As part of this, I'm also renaming the builders to be consistent: Chromium Linux MSan Builder -> Linux MSAN Builder Linux MSan Tests -> Linux MSan Tests Chromium Linux ChromeOS MSan Builder -> Linux ChromiumOS MSan Builder Linux ChromeOS MSan Tests -> Linux ChromiumOS MSan Tests R=phajdan.jr@chromium.org, qyearsley@chromium.org BUG= 598859 Change-Id: Id3c7f3c0d795aa098e3badebb746a98d9de6ee09 Reviewed-on: https://chromium-review.googlesource.com/474989 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/masters/master.chromium.memory.full/notifier_cfg.py [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/masters/master.chromium.memory.full/slaves.cfg [rename] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_MSan_Builder.json [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium.expected/msan.json [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_ChromeOS_MSan_Tests.json [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/masters/master.chromium.memory/master_linux_cfg.py [copy] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ChromiumOS_MSan_Builder.json [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium.py [rename] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_MSan_Tests.json [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/tests/masters_test.py [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipe_modules/chromium_tests/trybots.py [copy] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ChromiumOS_MSan_Tests.json [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/scripts/slave/recipe_modules/chromium_tests/chromium_memory_full.py [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_ChromeOS_MSan_Builder.json [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/masters/master.chromium.memory.full/OWNERS [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/masters/master.chromium.memory.full/master.cfg [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/masters/master.chromium.memory/slaves.cfg [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_msan_rel_ng.json [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_msan_rel_ng.json [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/recipe_modules/chromium_tests/builders.py [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/masters/master.chromium.memory.full/Makefile [delete] https://crrev.com/e2df708329ae1c2fffa2ac7d0f7bf6c59773f409/masters/master.chromium.memory.full/master_site_config.py [modify] https://crrev.com/c0e30882b56926a2669b333716cadeb907b7cc33/scripts/slave/logdog-params.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/cf5c90b08d2b52070905b94ab81d1abbea8925fc commit cf5c90b08d2b52070905b94ab81d1abbea8925fc Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Apr 13 01:49:03 2017 Remove chromium.memory.full from the buildbot headers. Now that we've removed the master, we no longer need it in the headers of every page :). Also remove other remaining references to memory.full. R=dnj@chromium.org BUG= 598859 Change-Id: Idffde80596691c720cdce85c5548dc826bf8d9d0 Reviewed-on: https://chromium-review.googlesource.com/476172 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/cf5c90b08d2b52070905b94ab81d1abbea8925fc/masters/master.chromium/templates/announce.html [modify] https://crrev.com/cf5c90b08d2b52070905b94ab81d1abbea8925fc/scripts/slave/recipe_modules/chromium_swarming/api.py [modify] https://crrev.com/cf5c90b08d2b52070905b94ab81d1abbea8925fc/scripts/slave/gatekeeper.json [modify] https://crrev.com/cf5c90b08d2b52070905b94ab81d1abbea8925fc/scripts/slave/bot_update.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/d3b1e00bd6d93cdbb865b49e9262d2c84777621b commit d3b1e00bd6d93cdbb865b49e9262d2c84777621b Author: Dirk Pranke <dpranke@google.com> Date: Thu Apr 13 01:52:50 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/515476f7f324e44875417190e2a6f63425273b96 commit 515476f7f324e44875417190e2a6f63425273b96 Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Apr 13 20:00:41 2017 Fix parent buildername for Linux ChromiumOS MSan Tests. This should fix the builder/tester split that I broke when I moved the builders onto the chromium.memory waterfall. TBR=thakis@chromium.org BUG= 598859 Change-Id: I1cb9cbd6c9506bf828a426497befe452b6493257 Reviewed-on: https://chromium-review.googlesource.com/477251 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/515476f7f324e44875417190e2a6f63425273b96/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ChromiumOS_MSan_Builder.json [modify] https://crrev.com/515476f7f324e44875417190e2a6f63425273b96/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a77f67e8518b816756cbc169f8985cbe34cf45d5 commit a77f67e8518b816756cbc169f8985cbe34cf45d5 Author: dpranke <dpranke@chromium.org> Date: Fri Apr 14 23:20:27 2017 Remove src-side configs for memory.full builders. Now that the chromium.memory.full master has been merged into chromium.memory, we can remove the old entries from the src-side config files. R=qyearsley@chromium.org, phajdan.jr@chromium.org BUG= 598859 Review-Url: https://codereview.chromium.org/2814983002 Cr-Commit-Position: refs/heads/master@{#464821} [delete] https://crrev.com/635372d1d6a0318a44dbc1be736d8060a126d68a/testing/buildbot/chromium.memory.full.json [modify] https://crrev.com/a77f67e8518b816756cbc169f8985cbe34cf45d5/tools/mb/mb_config.pyl
Comment 1 by kcc@chromium.org
, Mar 29 2016