New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598854 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue crashpad:192

Blocking:
issue 568664
issue 597454
issue 746518



Sign in to add a comment

Convert crash keys to new Crashpad-based API

Project Member Reported by marcinjb@chromium.org, Mar 29 2016

Issue description

Currently, the main source of truth of crash keys resides in //chrome/common/crash_keys.cc (specifically, in crash_keys::RegisterChromeCrashKeys()).  All sorts of keys are stuffed in there, including keys from //chrome, //media and //content.

To support projects that will use crash reporting but don't want to depend on //chrome, we should have each component that has crash keys define their own collections of keys.  I envision this as something where each component will return (or append to) a vector of base::debug::CrashKeys that are used in that directory hierarchy.  Proposed structure:

//content/common/crash_keys.{h,cc}
//media/base/crash_keys.{h,cc}
//chrome/common/crash_keys.{h,cc}

For a first pass (this issue), the cleanup will be limited to pulling apart the large crash key declaration currently in crash_keys::RegisterChromeCrashKeys().

(Some background reading: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/2NVBSWHUAP0)
 

Comment 1 by sanfin@chromium.org, Apr 13 2016

Cc: sanfin@chromium.org
Cc: halliwell@chromium.org
Labels: -Pri-3 Pri-2
Just discovered this affects Cast receiver.  Do you have an ETA on submitting the proposed fixes?  Also, let us know if it would be useful for us to help out.
Sorry for dropping this on the ground for the last week.

I've got a preliminary change going at http://crrev.com/1849413003, but I'm still wrangling with some Windows compile error.  If you all have an idea how to fix that up, that'd be wonderful.  I think there's a few build file cleanups that I can do, but I feel like that's the general shape of my approach.

If all goes well, I hope to get back to this full time next week.
Thanks for the update!  Seems like the build logs are gone now, I kicked off a new one :)
I'm back at it now.  Just sync'd and reran the trybots, so you should see the failure now (it's coming from win_chromium_compile_dbg_ng)

Comment 6 by rsesek@chromium.org, Apr 26 2016

The win_clang bot has much better diagnostics (not surprising!):

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\slave\cache\cipd\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/media/base/crash_keys/crash_keys.obj.rsp /c ../../media/base/crash_keys.cc /Foobj/media/base/crash_keys/crash_keys.obj /Fd"obj/media/base/crash_keys_cc.pdb"
../../media/base/crash_keys.cc(22,6):  error: 'crash_keys::AppendMediaCrashKeys' redeclared without 'dllimport' attribute: previous 'dllimport' ignored [-Werror,-Winconsistent-dllimport]
void AppendMediaCrashKeys(std::vector<base::debug::CrashKey>* keys) {
     ^
../..\media/base/crash_keys.h(23,19):  note: previous declaration is here
MEDIA_EXPORT void AppendMediaCrashKeys(
                  ^
../..\media/base/crash_keys.h(23,1):  note: previous attribute is here
MEDIA_EXPORT void AppendMediaCrashKeys(
^
../..\media/base/media_export.h(17,33):  note: expanded from macro 'MEDIA_EXPORT'
#define MEDIA_EXPORT __declspec(dllimport)
                                ^
This may be because of the source_set you're using in GN.
Well, at first I was all happy with clang (<3 clang) and went about fixing that compiler error.  Unfortunately, my success with win_clang does not seem to have carried over to win_chromium_compile_dbg_ng, which still has the following error:

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\slave\cache\cipd\goma/gomacc "E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\media\base\chrome_nacl_win64.crash_keys.obj.rsp /c ..\..\media\base\crash_keys.cc /Foobj\media\base\chrome_nacl_win64.crash_keys.obj /Fdobj\chrome\chrome_nacl_win64.cc.pdb 
e:\b\build\slave\win\build\src\media\base\crash_keys.cc(22): error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\media\base\crash_keys.cc(22): warning C4273: 'crash_keys::AppendMediaCrashKeys': inconsistent dll linkage
e:\b\build\slave\win\build\src\media\base\crash_keys.h(23): note: see previous definition of 'AppendMediaCrashKeys'

This is definitely at the very edges of my ability to trace through build system configuration. My current guess is that this traces back to the "chrome_nacl_win64" target found in //chrome/chrome_exe.gypi.  I *think* I'm missing some "defines" magic somewhere for the media and the content crash keys in some gypi file, but I totally have no idea if that's correct, or if it is, how to fix it.

Thoughts?

Comment 8 Deleted

(eesh something ate my last comment)

I don't know if you can use source_sets and FOO_EXPORT together. Since source_set basically carries forward the .o files to a library/executable boundary, the _IMPLEMENTATION and _EXPORT won't mix well together. I'm not an expert in Windows or the component build, but I think if you intend to export something as a module, you need to create a real library.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc10609fc3bd28b6763f8302904d1e75febcfd5d

commit bc10609fc3bd28b6763f8302904d1e75febcfd5d
Author: sanfin <sanfin@google.com>
Date: Fri Sep 16 17:15:03 2016

[chromecast] update workaround in cast_crash_keys

BUG= 598854 

Review-Url: https://codereview.chromium.org/2345193002
Cr-Commit-Position: refs/heads/master@{#419198}

[modify] https://crrev.com/bc10609fc3bd28b6763f8302904d1e75febcfd5d/chromecast/crash/cast_crash_keys.cc

Cc: hashimoto@chromium.org
I'm going to take a stab at this for the keys in components/discardable_memory, which my reviewer in https://codereview.chromium.org/2718123003/ requested.

I'm not going to do the yak shave for the rest of them, but if I can get this working it might supply a pattern for fixing the other ones.

Actually, I wouldn't spend time on this project. We have designs for removing the pre-registration requirement, which I'd like to implement in the intermediate-term.
How long is intermediate-term? This has recently caused problems on Cast targets again, and I'd like to know how long I will have to keep updating our local registration function to sync with Chrome's. :)
I'd like to do it within the next month or three.
So ATM the preferred way to add a new crash key user is duplicating crash key constants with a TODO pointing this issue?
Re: #15: Yes, please continue doing that for the time being.
OK, I'll abandon my CL. Thanks for the update.

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71906ce9957150b6fab9e906bfce22285eccc6f9

commit 71906ce9957150b6fab9e906bfce22285eccc6f9
Author: sanfin <sanfin@chromium.org>
Date: Wed Mar 08 23:11:38 2017

[Chromecast] Add new crash keys from chrome/common.

Whenever new crash keys are registered in chrome/common, we must
copy them in chromecast/crash/; otherwise a DCHECK fails
whenever any component tries to set a crash key value that has
not been registered.

BUG= 598854 
TEST=Cherry-pick to internal branch, build internal apk, run on device

Review-Url: https://codereview.chromium.org/2733123002
Cr-Commit-Position: refs/heads/master@{#455582}

[modify] https://crrev.com/71906ce9957150b6fab9e906bfce22285eccc6f9/chrome/common/crash_keys.cc
[modify] https://crrev.com/71906ce9957150b6fab9e906bfce22285eccc6f9/chromecast/crash/BUILD.gn
[modify] https://crrev.com/71906ce9957150b6fab9e906bfce22285eccc6f9/chromecast/crash/DEPS
[modify] https://crrev.com/71906ce9957150b6fab9e906bfce22285eccc6f9/chromecast/crash/cast_crash_keys.cc

Blockedon: crashpad:192
Cc: marcinjb@chromium.org
Owner: rsesek@chromium.org
Components: -Internals>Core Internals>CrashReporting
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/933fc26fd26475553860c2332bc10f0d4cfcb7a3

commit 933fc26fd26475553860c2332bc10f0d4cfcb7a3
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Nov 03 16:58:22 2017

Update Crashpad to b6a3d913421eb1f0ad05cc5dce6fde0c1342f71c

4d7d4dd56cf0 Flip gtest _EQ parameter order in
             minidump_annotation_writer_test.cc
79e2dd843e1f Include string annotation objects when uploading crash
             reports
b6a3d913421e Read annotation objects from the client when producing
             snapshots

Bug:  598854 
Change-Id: I0e70a536c1fed194d2ebabb44766451a593b212b
Reviewed-on: https://chromium-review.googlesource.com/753703
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513805}
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/README.chromium
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/handler/handler_test.gyp
[add] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/handler/minidump_to_upload_parameters.cc
[add] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/handler/minidump_to_upload_parameters.h
[add] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/handler/minidump_to_upload_parameters_test.cc
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/minidump/minidump_annotation_writer_test.cc
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/933fc26fd26475553860c2332bc10f0d4cfcb7a3/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/987912a57b375eecf6c200f0915d6de7fb2f00fa

commit 987912a57b375eecf6c200f0915d6de7fb2f00fa
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Nov 03 20:08:35 2017

Register the Crashpad AnnotationList so that clients can use it.

This also declares a temporary test annotation to verify that the
new system works end-to-end.

Bug:  598854 
Change-Id: Ice996ff772a486691eb8636841fef52a738fa1c0
Reviewed-on: https://chromium-review.googlesource.com/753810
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513887}
[modify] https://crrev.com/987912a57b375eecf6c200f0915d6de7fb2f00fa/components/crash/content/app/crashpad.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/breakpad/breakpad/+/8a0edac9abfec72e0a86aebd6a0a38761c7c8962

commit 8a0edac9abfec72e0a86aebd6a0a38761c7c8962
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 07 23:24:48 2017

Add index-based set functionality to NonAllocatingMap.

This enables repeatedly setting a value based on index, which avoids a
linear scan of the entry table after the first SetKeyValue().

Bug:  chromium:598854 
Change-Id: I9964670a09dcd8ff76180d031a373f20990bf4d8
Reviewed-on: https://chromium-review.googlesource.com/757579
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/8a0edac9abfec72e0a86aebd6a0a38761c7c8962/src/common/simple_string_dictionary.h
[modify] https://crrev.com/8a0edac9abfec72e0a86aebd6a0a38761c7c8962/src/common/simple_string_dictionary_unittest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c538f652fecf52a1751eff4a250c28569c2d837b

commit c538f652fecf52a1751eff4a250c28569c2d837b
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Nov 08 11:16:55 2017

Roll src/third_party/breakpad/breakpad/ 3bbf3fb0d..8a0edac9a (1 commit)

https://chromium.googlesource.com/breakpad/breakpad.git/+log/3bbf3fb0db6d..8a0edac9abfe

$ git log 3bbf3fb0d..8a0edac9a --date=short --no-merges --format='%ad %ae %s'
2017-11-07 rsesek Add index-based set functionality to NonAllocatingMap.

Created with:
  roll-dep src/third_party/breakpad/breakpad

Bug:  598854 
Change-Id: Iea8b632f90e435cea5f7533c2bbcfa19ad3b1422
Reviewed-on: https://chromium-review.googlesource.com/757740
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514797}
[modify] https://crrev.com/c538f652fecf52a1751eff4a250c28569c2d837b/DEPS

Status: Started (was: Assigned)
Summary: Convert crash keys to new Crashpad-based API (was: Break apart crash key definitions so they're not all defined in //chrome)
Retitling this to reflect what is going to happen:

On platforms where Crashpad is the crash reporter, we will use the new Annotations system (see  issue crashpad:192 ). On platforms still using Breakpad, there will be a source/API-compatible interface that wires in to the existing SimpleStringDictionary storage that is currently used for crash keys. The new API does not require centralized registration: the annotations/crash keys are declared in the file or function in which they are used, and each object allocates its own storage for the value.
Blocking: 746518
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58cb7e29a4e6f415d8178192ac55b5624c31ed5d

commit 58cb7e29a4e6f415d8178192ac55b5624c31ed5d
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Nov 16 22:02:04 2017

Update Crashpad to a7453394d6ed712a56c000dafa465857f9eee970

6dd2be7c44a9 Stop providing unimplemented stubs for
             util/mach/exc_server_variants.cc
f09257b17c36 Remove more unneeded MIG server stubs
a7453394d6ed Provide a StringPiece getter and setter for
             StringAnnotation

Bug:  598854 
Change-Id: I402e191195c90891c0f44e73334cfceed2f61568
Reviewed-on: https://chromium-review.googlesource.com/774912
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517204}
[modify] https://crrev.com/58cb7e29a4e6f415d8178192ac55b5624c31ed5d/third_party/crashpad/README.chromium
[modify] https://crrev.com/58cb7e29a4e6f415d8178192ac55b5624c31ed5d/third_party/crashpad/crashpad/client/annotation.h
[modify] https://crrev.com/58cb7e29a4e6f415d8178192ac55b5624c31ed5d/third_party/crashpad/crashpad/client/annotation_test.cc
[modify] https://crrev.com/58cb7e29a4e6f415d8178192ac55b5624c31ed5d/third_party/crashpad/crashpad/util/mach/child_port_server.cc
[modify] https://crrev.com/58cb7e29a4e6f415d8178192ac55b5624c31ed5d/third_party/crashpad/crashpad/util/mach/exc_server_variants.cc
[modify] https://crrev.com/58cb7e29a4e6f415d8178192ac55b5624c31ed5d/third_party/crashpad/crashpad/util/mach/mig.py
[modify] https://crrev.com/58cb7e29a4e6f415d8178192ac55b5624c31ed5d/third_party/crashpad/crashpad/util/mach/notify_server.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f117f26d776f0ba5657451d89800f556a30c3f3

commit 6f117f26d776f0ba5657451d89800f556a30c3f3
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Nov 20 00:56:36 2017

Introduce the new CrashKeyString API.

This will replace the base/debug/crash_logging.h interface with an API
that is based off Crashpad's Annotations ( https://crbug.com/crashpad/192 ).

Platforms that use Crashpad for crash reporting will indirectly use the
new Annotation API. Platforms still using Breakpad are provided a
source-compatible API that stores the data in the old NonAllocatingMap/
SimpleStringDictionary.

The InitializedArray template is courtesy of sdy@chromium.org.

Bug:  598854 
Change-Id: Ic1b13ed9b3d504a1f90e119fa816d74fe3bdbff5
Reviewed-on: https://chromium-review.googlesource.com/757637
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517740}
[modify] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/content/app/breakpad_linux_impl.h
[modify] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/content/browser/crash_handler_host_linux.h
[modify] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/DEPS
[modify] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/BUILD.gn
[add] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/crash_key.h
[add] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/crash_key_breakpad.cc
[add] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/crash_key_breakpad_unittest.cc
[add] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/crash_key_crashpad.cc
[add] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/crash_key_internal.h
[add] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/crash_key_stubs.cc
[add] https://crrev.com/6f117f26d776f0ba5657451d89800f556a30c3f3/components/crash/core/common/crash_key_unittest.cc

Blocking: 568664
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d89a06202b8798b2eba8856043488735cd8ffce1

commit d89a06202b8798b2eba8856043488735cd8ffce1
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Nov 20 22:54:05 2017

Initialize the new crash key system in all crash reporter clients.

This also converts the "num-switches" key to use the new crash key
system, to test that it works end-to-end on all platforms.

Bug:  598854 
Change-Id: I9591a70562adc4767500ac05cb3e2a2e93d0b533
Reviewed-on: https://chromium-review.googlesource.com/777902
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517968}
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/chrome/common/crash_keys_unittest.cc
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/chromecast/app/BUILD.gn
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/components/crash/core/common/crash_keys.h
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/components/crash/core/common/crash_keys_unittest.cc
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/content/shell/BUILD.gn
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/headless/BUILD.gn
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/headless/DEPS
[modify] https://crrev.com/d89a06202b8798b2eba8856043488735cd8ffce1/headless/lib/headless_content_main_delegate.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2fb3840ffe90a3f716925784ab7e29439cd2a72

commit c2fb3840ffe90a3f716925784ab7e29439cd2a72
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 21 15:07:09 2017

Cull registered-but-unused crash keys from the registration lists.

Tbr: rohitrao@chromium.org
Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7113ea9e653d5ef0f3c214469db1acaaff44defe
Reviewed-on: https://chromium-review.googlesource.com/780520
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518250}
[modify] https://crrev.com/c2fb3840ffe90a3f716925784ab7e29439cd2a72/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/c2fb3840ffe90a3f716925784ab7e29439cd2a72/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/c2fb3840ffe90a3f716925784ab7e29439cd2a72/chrome/common/crash_keys.cc
[modify] https://crrev.com/c2fb3840ffe90a3f716925784ab7e29439cd2a72/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/c2fb3840ffe90a3f716925784ab7e29439cd2a72/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/c2fb3840ffe90a3f716925784ab7e29439cd2a72/components/crash/core/common/crash_keys.h
[modify] https://crrev.com/c2fb3840ffe90a3f716925784ab7e29439cd2a72/ios/chrome/browser/crash_report/crash_keys.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8358924a33bf0bddc08520dff5c3c9f4aa73675e

commit 8358924a33bf0bddc08520dff5c3c9f4aa73675e
Author: Matt Giuca <mgiuca@chromium.org>
Date: Wed Nov 22 01:38:51 2017

Revert "Add a utility to format a base::debug::StackTrace for CrashKeyString."

This reverts commit f12be75c72b03200901e84da7a066c4b0a1c9217.

Reason for revert: New test crashes on chromium.win/Win7.
Bug:  787669 

Original change's description:
> Add a utility to format a base::debug::StackTrace for CrashKeyString.
> 
> Bug:  598854 
> Change-Id: Ie92935f4919e57cae338c33750458c0509a93627
> Reviewed-on: https://chromium-review.googlesource.com/782040
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518381}

TBR=rsesek@chromium.org,mark@chromium.org

Change-Id: Ibfa0b31f290fe2f99dc90791b79240b1dd71121d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  598854 
Reviewed-on: https://chromium-review.googlesource.com/784170
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518492}
[modify] https://crrev.com/8358924a33bf0bddc08520dff5c3c9f4aa73675e/components/crash/core/common/BUILD.gn
[delete] https://crrev.com/9a0cfb428cf07e2ccdd2aeb4968c3c323fb3e40e/components/crash/core/common/crash_key.cc
[modify] https://crrev.com/8358924a33bf0bddc08520dff5c3c9f4aa73675e/components/crash/core/common/crash_key.h
[modify] https://crrev.com/8358924a33bf0bddc08520dff5c3c9f4aa73675e/components/crash/core/common/crash_key_unittest.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac34ddc366b5308df6a61b3cf8df4586ee680cb5

commit ac34ddc366b5308df6a61b3cf8df4586ee680cb5
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 28 17:37:21 2017

Reland "Add a utility to format a base::debug::StackTrace for CrashKeyString."

This is a reland of f12be75c72b03200901e84da7a066c4b0a1c9217
Original change's description:
> Add a utility to format a base::debug::StackTrace for CrashKeyString.
>
> Bug:  598854 
> Change-Id: Ie92935f4919e57cae338c33750458c0509a93627
> Reviewed-on: https://chromium-review.googlesource.com/782040
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518381}

Bug:  598854 ,  787669 
Change-Id: I81fef0cba08240ee288d4e3db3c3bcf4ff130219
Reviewed-on: https://chromium-review.googlesource.com/793930
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519727}
[modify] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/BUILD.gn
[add] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/crash_key.cc
[modify] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/crash_key.h
[modify] https://crrev.com/ac34ddc366b5308df6a61b3cf8df4586ee680cb5/components/crash/core/common/crash_key_unittest.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c14690fa286204103105300ccd36e80ad744843

commit 6c14690fa286204103105300ccd36e80ad744843
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 28 19:58:28 2017

Update Crashpad to af28b83eb7b6c5009c3ba1ccb440653df10fd7a0

ee84ce22bb89 fuchsia: Set kOS in MinidumpMiscInfoDebugBuildString
1020a6147d3d fuchsia: Use crashpad_info section matching Linux/Android
             for now
050d111bf986 fuchsia: Set METRICS_OS_NAME
4ee20f583191 Add Fuchsia clang and sdk to DEPS
0d05b0d59e19 fuchsia: Use RandBytes UUID generator
af28b83eb7b6 In Annotation::SetSize, use AnnotationList::Register rather
             than Get

Bug:  598854 
Change-Id: Iccbc85ad93f03385bf0b4623f48046050f424062
Reviewed-on: https://chromium-review.googlesource.com/794036
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519807}
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/README.chromium
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/.gitignore
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/client/annotation.cc
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/client/crashpad_info.cc
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/minidump/minidump_misc_info_writer.cc
[add] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/third_party/fuchsia/README.crashpad
[add] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/third_party/fuchsia/toolchain.ensure
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/util/misc/metrics.cc
[modify] https://crrev.com/6c14690fa286204103105300ccd36e80ad744843/third_party/crashpad/crashpad/util/misc/uuid.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bf2df677f90493018b6bf27742fca29719c0b0d

commit 5bf2df677f90493018b6bf27742fca29719c0b0d
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Nov 30 00:26:11 2017

Provide a new //base-level API for crash keys v2.

The new, preferred crash key API is located at
//components/crash/core/common:crash_key, but not all clients of the
crash key system can have a direct dependency on that.

In this CL, a new base/debug/crash_logging.h API is created to indirect
to the new v2 API. It is less featured and flexible than the crash
component API. This will fully replace the existing API still located
in that file.

Bug:  598854 
Change-Id: Ifabd12f80d1a858ff61b999eba956d6cd5113784
Reviewed-on: https://chromium-review.googlesource.com/795230
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520333}
[modify] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/base/debug/crash_logging.cc
[modify] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/base/debug/crash_logging.h
[modify] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/base/debug/crash_logging_unittest.cc
[modify] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/components/crash/core/common/BUILD.gn
[add] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/components/crash/core/common/crash_key_base_support.cc
[add] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/components/crash/core/common/crash_key_base_support.h
[modify] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/components/crash/core/common/crash_key_crashpad.cc
[modify] https://crrev.com/5bf2df677f90493018b6bf27742fca29719c0b0d/components/crash/core/common/crash_key_unittest.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67651912f8d43be928b9b719def816e545ff7441

commit 67651912f8d43be928b9b719def816e545ff7441
Author: Timothy Loh <timloh@chromium.org>
Date: Thu Nov 30 03:00:50 2017

Revert "Provide a new //base-level API for crash keys v2."

This reverts commit 5bf2df677f90493018b6bf27742fca29719c0b0d.

Reason for revert: The added test, CrashKeyStringTest.BaseSupport, fails on ASAN:

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/36434

Original change's description:
> Provide a new //base-level API for crash keys v2.
> 
> The new, preferred crash key API is located at
> //components/crash/core/common:crash_key, but not all clients of the
> crash key system can have a direct dependency on that.
> 
> In this CL, a new base/debug/crash_logging.h API is created to indirect
> to the new v2 API. It is less featured and flexible than the crash
> component API. This will fully replace the existing API still located
> in that file.
> 
> Bug:  598854 
> Change-Id: Ifabd12f80d1a858ff61b999eba956d6cd5113784
> Reviewed-on: https://chromium-review.googlesource.com/795230
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520333}

TBR=rsesek@chromium.org,mark@chromium.org

Change-Id: I876ae24d1e8a212e42188006ace4803c323338e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  598854 
Reviewed-on: https://chromium-review.googlesource.com/799010
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520401}
[modify] https://crrev.com/67651912f8d43be928b9b719def816e545ff7441/base/debug/crash_logging.cc
[modify] https://crrev.com/67651912f8d43be928b9b719def816e545ff7441/base/debug/crash_logging.h
[modify] https://crrev.com/67651912f8d43be928b9b719def816e545ff7441/base/debug/crash_logging_unittest.cc
[modify] https://crrev.com/67651912f8d43be928b9b719def816e545ff7441/components/crash/core/common/BUILD.gn
[delete] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/components/crash/core/common/crash_key_base_support.cc
[delete] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/components/crash/core/common/crash_key_base_support.h
[modify] https://crrev.com/67651912f8d43be928b9b719def816e545ff7441/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/67651912f8d43be928b9b719def816e545ff7441/components/crash/core/common/crash_key_crashpad.cc
[modify] https://crrev.com/67651912f8d43be928b9b719def816e545ff7441/components/crash/core/common/crash_key_unittest.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Nov 30 2017

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c334c65915ec312ae1e13c4da9285ee8c58735b

commit 9c334c65915ec312ae1e13c4da9285ee8c58735b
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Nov 30 22:03:00 2017

Reland "Provide a new //base-level API for crash keys v2."

This is a reland of 5bf2df677f90493018b6bf27742fca29719c0b0d
Original change's description:
> Provide a new //base-level API for crash keys v2.
> 
> The new, preferred crash key API is located at
> //components/crash/core/common:crash_key, but not all clients of the
> crash key system can have a direct dependency on that.
> 
> In this CL, a new base/debug/crash_logging.h API is created to indirect
> to the new v2 API. It is less featured and flexible than the crash
> component API. This will fully replace the existing API still located
> in that file.
> 
> Bug:  598854 
> Change-Id: Ifabd12f80d1a858ff61b999eba956d6cd5113784
> Reviewed-on: https://chromium-review.googlesource.com/795230
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520333}

Bug:  598854 
Change-Id: Ic2f82fdb887b9950c52f3fb768b0e12498ba792f
Reviewed-on: https://chromium-review.googlesource.com/801070
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520708}
[modify] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/base/debug/crash_logging.cc
[modify] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/base/debug/crash_logging.h
[modify] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/base/debug/crash_logging_unittest.cc
[modify] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/components/crash/core/common/BUILD.gn
[add] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/components/crash/core/common/crash_key_base_support.cc
[add] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/components/crash/core/common/crash_key_base_support.h
[modify] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/components/crash/core/common/crash_key_crashpad.cc
[modify] https://crrev.com/9c334c65915ec312ae1e13c4da9285ee8c58735b/components/crash/core/common/crash_key_unittest.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Dec 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97461ea219a24a5bf9ffe51cf4a7eb1d1633aeb3

commit 97461ea219a24a5bf9ffe51cf4a7eb1d1633aeb3
Author: Robert Sesek <rsesek@chromium.org>
Date: Sun Dec 03 20:22:45 2017

crash_keys: Remove old "bad_histogram" key.

Bug:  598854 
Change-Id: I380ef1cb8bf2de2a72d52091b619b374b4dc3c33
Reviewed-on: https://chromium-review.googlesource.com/804338
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521231}
[modify] https://crrev.com/97461ea219a24a5bf9ffe51cf4a7eb1d1633aeb3/base/metrics/histogram.cc
[modify] https://crrev.com/97461ea219a24a5bf9ffe51cf4a7eb1d1633aeb3/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/97461ea219a24a5bf9ffe51cf4a7eb1d1633aeb3/chrome/common/crash_keys.cc

Project Member

Comment 44 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f13a6c3b0292632fd0e202b64735bcc616673ea

commit 6f13a6c3b0292632fd0e202b64735bcc616673ea
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Dec 04 17:53:06 2017

Make //components/crash/core/common:crash_key a component when using Breakpad.

With Breakpad, the crash key storage is stored in a static global, and
having the target be a static_library resulted in having multiple copies
existing in the component build.

This also changes the Breakpad crash key storage to be lazily
initialized, which matches what Crashpad does after
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/793981.
The storage is still initialized deterministically in the static release
build, but is done to support unit tests.

Bug:  598854 
Change-Id: Ic6f100fd0310545fe2697152bd076846153f16d2
Reviewed-on: https://chromium-review.googlesource.com/802274
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521382}
[modify] https://crrev.com/6f13a6c3b0292632fd0e202b64735bcc616673ea/components/crash/core/common/BUILD.gn
[modify] https://crrev.com/6f13a6c3b0292632fd0e202b64735bcc616673ea/components/crash/core/common/crash_export.h
[modify] https://crrev.com/6f13a6c3b0292632fd0e202b64735bcc616673ea/components/crash/core/common/crash_key.h
[modify] https://crrev.com/6f13a6c3b0292632fd0e202b64735bcc616673ea/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/6f13a6c3b0292632fd0e202b64735bcc616673ea/components/crash/core/common/crash_key_internal.h

Project Member

Comment 45 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7be49f33afa3174281ad1617d5d1ba5dfa423175

commit 7be49f33afa3174281ad1617d5d1ba5dfa423175
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Dec 04 22:39:09 2017

crash_keys: Convert several Cocoa/Mac keys to the new API.

- {"firstexception","lastexception"}{,"_bt"}
- "toolbar-nib_info"
- "sendaction"
- "nsevent"

Bug:  598854 
Change-Id: Id5ea8c7dbdd328452234763c065f946908fcea15
Reviewed-on: https://chromium-review.googlesource.com/804214
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521495}
[modify] https://crrev.com/7be49f33afa3174281ad1617d5d1ba5dfa423175/chrome/browser/chrome_browser_application_mac.mm
[modify] https://crrev.com/7be49f33afa3174281ad1617d5d1ba5dfa423175/chrome/browser/mac/exception_processor.mm
[modify] https://crrev.com/7be49f33afa3174281ad1617d5d1ba5dfa423175/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/7be49f33afa3174281ad1617d5d1ba5dfa423175/chrome/common/crash_keys.cc
[modify] https://crrev.com/7be49f33afa3174281ad1617d5d1ba5dfa423175/chrome/common/crash_keys.h

Project Member

Comment 47 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a998b89e6946aebfdd52488de43e41d95a581fd

commit 8a998b89e6946aebfdd52488de43e41d95a581fd
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 05 22:45:58 2017

Skip CrashKeyStringTest.SetStackTrace in official builds if there are no unwind tables.

In this configuration, StackTrace may produce an empty result,
which causes the is_set() assertion to fail.

Bug: 791223,  598854 
Change-Id: I4c4cabf2eb1176def431cd5798a2c80808bf8074
Reviewed-on: https://chromium-review.googlesource.com/809102
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521870}
[modify] https://crrev.com/8a998b89e6946aebfdd52488de43e41d95a581fd/components/crash/core/common/crash_key_unittest.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/017ed3912ed15a7269aea2a4703d8fa25f67d685

commit 017ed3912ed15a7269aea2a4703d8fa25f67d685
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Dec 06 13:05:24 2017

crash_keys: Convert "num-users" to the new API.

Bug:  598854 
Change-Id: Icb9b7586a8b14772dded0b4c1c323a3668dba371
Reviewed-on: https://chromium-review.googlesource.com/804350
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522075}
[modify] https://crrev.com/017ed3912ed15a7269aea2a4703d8fa25f67d685/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/017ed3912ed15a7269aea2a4703d8fa25f67d685/chrome/common/crash_keys.cc
[modify] https://crrev.com/017ed3912ed15a7269aea2a4703d8fa25f67d685/chrome/common/crash_keys.h

Project Member

Comment 49 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5799f48f4759cc4e47125f35310d266253f659f6

commit 5799f48f4759cc4e47125f35310d266253f659f6
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Dec 06 18:46:16 2017

Add base::debug::ScopedCrashKeyString.

This is the new version of base::debug::ScopedCrashKey.

Bug:  598854 
Change-Id: Idfea07f414c4c68fb51909de467c8e666acd841d
Reviewed-on: https://chromium-review.googlesource.com/811287
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522145}
[modify] https://crrev.com/5799f48f4759cc4e47125f35310d266253f659f6/base/debug/crash_logging.cc
[modify] https://crrev.com/5799f48f4759cc4e47125f35310d266253f659f6/base/debug/crash_logging.h

Project Member

Comment 50 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1419427e917eb6110885aafbe64966585287c1d4

commit 1419427e917eb6110885aafbe64966585287c1d4
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Dec 07 15:01:32 2017

crash_keys: Convert keys in //content to the new API.

- "ax_tree_error"
- "ax_tree_update"
- "bad_message_reason"
- "font_key_name"
- "input-event-filter-send-failure"
- "mojo-message-error"
- "ppapi_path"
- "text-input-context-client"

Bug:  598854 
Change-Id: Ia5d033e828ffb4341d43085a906551bb1c354e62
Reviewed-on: https://chromium-review.googlesource.com/811896
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522426}
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/chrome/common/crash_keys.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/chrome/common/crash_keys.h
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/browser/bad_message.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/browser/bad_message.h
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/content/renderer/input/input_event_filter.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d732922f0cae73302eb54c3d5d02ead04c711342

commit d732922f0cae73302eb54c3d5d02ead04c711342
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Dec 08 15:31:08 2017

crash_keys: Convert keys in //gpu to the new API.

Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ied530be6146866340290abff1df5d9f6227e3668
Reviewed-on: https://chromium-review.googlesource.com/812525
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522785}
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/android_webview/BUILD.gn
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chrome/BUILD.gn
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chrome/common/BUILD.gn
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chrome/common/crash_keys.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chrome/test/BUILD.gn
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chrome_elf/BUILD.gn
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chromecast/crash/BUILD.gn
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/config/BUILD.gn
[add] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/config/DEPS
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/config/gpu_crash_keys.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/config/gpu_crash_keys.h
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/config/gpu_util.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/ipc/service/gles2_command_buffer_stub.cc
[modify] https://crrev.com/d732922f0cae73302eb54c3d5d02ead04c711342/gpu/ipc/service/raster_command_buffer_stub.cc

Project Member

Comment 53 by bugdroid1@chromium.org, Dec 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e07e37414646ddf071a796092fefb5b552227d3

commit 1e07e37414646ddf071a796092fefb5b552227d3
Author: Robert Sesek <rsesek@chromium.org>
Date: Sat Dec 09 01:34:42 2017

crash_keys: Convert site isolation keys to the new API.

- "killed_process_origin_lock"
- "requested_origin"
- "requested_site_url"
- "site_isolation_mode"

Bug:  598854 
Change-Id: I7fd8c2762806ea7d46f42dbcc8e26381d98544cd
Reviewed-on: https://chromium-review.googlesource.com/817685
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522955}
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/chrome/common/crash_keys.cc
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/content/browser/bad_message.cc
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/content/browser/bad_message.h
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/1e07e37414646ddf071a796092fefb5b552227d3/content/browser/site_instance_impl.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fa5d0c67b6bb99cde6ecb4db3c69448e984a9dc

commit 0fa5d0c67b6bb99cde6ecb4db3c69448e984a9dc
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 12 02:06:54 2017

Provide an explicit constructor for C array initialization of CrashKeyString.

This mirrors
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/807645 in
Crashpad.

Bug:  598854 
Change-Id: I1b98dab78df7a30d913be3a476c8b373063e6065
Reviewed-on: https://chromium-review.googlesource.com/820160
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523302}
[modify] https://crrev.com/0fa5d0c67b6bb99cde6ecb4db3c69448e984a9dc/components/crash/core/common/crash_key.h
[modify] https://crrev.com/0fa5d0c67b6bb99cde6ecb4db3c69448e984a9dc/components/crash/core/common/crash_key_unittest.cc

Project Member

Comment 56 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b9c33918c6246c59397807bd1380d96faa40bee

commit 7b9c33918c6246c59397807bd1380d96faa40bee
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 12 16:32:02 2017

Expand the documentation in crash_key.h.

Bug:  598854 
Change-Id: Ifb15b66ced051591cbcaf4e28691abc9267fe7a7
Reviewed-on: https://chromium-review.googlesource.com/817794
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523446}
[modify] https://crrev.com/7b9c33918c6246c59397807bd1380d96faa40bee/components/crash/core/common/crash_key.h

Project Member

Comment 57 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/236e058375ef3b2d8ca7b26f1391c48c7a5d0379

commit 236e058375ef3b2d8ca7b26f1391c48c7a5d0379
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 12 19:30:02 2017

crash_keys: Convert keys in //android_webview to the new API.

Bug:  598854 
Change-Id: I0f2ad410d87e27bac5686091b31fbbab311acf14
Reviewed-on: https://chromium-review.googlesource.com/820855
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523508}
[modify] https://crrev.com/236e058375ef3b2d8ca7b26f1391c48c7a5d0379/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/236e058375ef3b2d8ca7b26f1391c48c7a5d0379/android_webview/lib/aw_main_delegate.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Dec 12 2017

Project Member

Comment 59 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/182487c4a11abec8d4510ef54c90bb120177713d

commit 182487c4a11abec8d4510ef54c90bb120177713d
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 12 21:47:33 2017

When chunking crash keys with Breakpad, let the collector re-stitch the values.

After internal cl/170262399, the crash collector will automatically stitch
together values named "key__1"..."key__N". Chromium's existing "key-1".."key-N"
syntax is special-cased in the processor on a per-key basis.

By switching to the key syntax handled by the collector, it will make converting
to the new crash key API easier for values that have to be chunked in Breakpad
(like the active URL and variations hashes). When the crash key reaches the
processor, it will already be assembled into a single value, rather than needing
to be joined by the processor.

Bug:  598854 
Change-Id: I393cc621bab61aafa4ea08602653807f448ff125
Reviewed-on: https://chromium-review.googlesource.com/822293
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523564}
[modify] https://crrev.com/182487c4a11abec8d4510ef54c90bb120177713d/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/182487c4a11abec8d4510ef54c90bb120177713d/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/182487c4a11abec8d4510ef54c90bb120177713d/components/crash/core/common/crash_key_breakpad_unittest.cc

Project Member

Comment 61 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0232eb54cff5578b3a4365a58e5db788368c6251

commit 0232eb54cff5578b3a4365a58e5db788368c6251
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Dec 13 16:09:27 2017

crash_keys: Convert keys in //components/discardable_memory to the new API.

Bug:  598854 
Change-Id: I4a8aef73b405d4e4f1c557a9eaad2c3fb02c8f24
Reviewed-on: https://chromium-review.googlesource.com/823943
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523782}
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/chrome/common/crash_keys.cc
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/components/discardable_memory/DEPS
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/components/discardable_memory/client/BUILD.gn
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/components/discardable_memory/client/client_discardable_shared_memory_manager.cc
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/components/discardable_memory/service/BUILD.gn
[modify] https://crrev.com/0232eb54cff5578b3a4365a58e5db788368c6251/components/discardable_memory/service/discardable_shared_memory_manager.cc

Project Member

Comment 63 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99cf160577f906ccd6b669f6704b179dcefeec4c

commit 99cf160577f906ccd6b669f6704b179dcefeec4c
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Dec 13 23:56:42 2017

crash_keys: Convert "seccomp-sigsys" to the new API.

Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: I9aae58daee5ba3eedbfc4601e1fabdab18013912
Reviewed-on: https://chromium-review.googlesource.com/822953
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523935}
[modify] https://crrev.com/99cf160577f906ccd6b669f6704b179dcefeec4c/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/99cf160577f906ccd6b669f6704b179dcefeec4c/chrome/common/crash_keys.cc
[modify] https://crrev.com/99cf160577f906ccd6b669f6704b179dcefeec4c/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc
[modify] https://crrev.com/99cf160577f906ccd6b669f6704b179dcefeec4c/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc
[modify] https://crrev.com/99cf160577f906ccd6b669f6704b179dcefeec4c/sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h

Project Member

Comment 64 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d54411f1adccb400bed8374c5f2d05441b12b8e

commit 3d54411f1adccb400bed8374c5f2d05441b12b8e
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Dec 14 17:17:46 2017

crash_keys: Convert "user-cloud-policy-manager-connect-trace" to the new API.

Bug:  598854 
Change-Id: I9cfe27590794d63903347f50daa1698ee6961bb1
Reviewed-on: https://chromium-review.googlesource.com/826442
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524096}
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/chrome/common/crash_keys.cc
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/chrome/common/crash_keys.h
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/components/policy/core/common/BUILD.gn
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/components/policy/core/common/DEPS
[modify] https://crrev.com/3d54411f1adccb400bed8374c5f2d05441b12b8e/components/policy/core/common/cloud/user_cloud_policy_manager.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7776d543f6dc862198f22d6e79b9616ea851a603

commit 7776d543f6dc862198f22d6e79b9616ea851a603
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon Dec 18 19:57:14 2017

crash_keys: Convert "switches-N", "channel", and client ID to the new API.

Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibb9031d4597d4c09bb6105f26aa02103f34b46a8
Reviewed-on: https://chromium-review.googlesource.com/822833
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524771}
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chrome/common/crash_keys.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chrome/common/crash_keys_unittest.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chrome/installer/setup/installer_crash_reporter_client.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chrome/installer/setup/installer_crash_reporting.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chrome/installer/setup/installer_crash_reporting.h
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/content/app/breakpad_linux.h
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/DEPS
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/BUILD.gn
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_key.h
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_key_breakpad_ios.mm
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_key_crashpad.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_key_stubs.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_keys.h
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/components/crash/core/common/crash_keys_unittest.cc
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/ios/chrome/app/chrome_exe_main.mm
[modify] https://crrev.com/7776d543f6dc862198f22d6e79b9616ea851a603/ios/chrome/browser/crash_report/crash_keys.cc

Project Member

Comment 67 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70184cd66f51db59fc2b5d3ff726e193a90f61a

commit b70184cd66f51db59fc2b5d3ff726e193a90f61a
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Mon Dec 18 22:06:25 2017

Revert "crash_keys: Convert "switches-N", "channel", and client ID to the new API."

This reverts commit 7776d543f6dc862198f22d6e79b9616ea851a603.

Reason for revert: Breaking the Linux (dbg) Testers, 32 and 64-bit:
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/46786
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/69045

Original change's description:
> crash_keys: Convert "switches-N", "channel", and client ID to the new API.
> 
> Bug:  598854 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Ibb9031d4597d4c09bb6105f26aa02103f34b46a8
> Reviewed-on: https://chromium-review.googlesource.com/822833
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524771}

TBR=thestig@chromium.org,sdefresne@chromium.org,pkl@chromium.org,rsesek@chromium.org,mark@chromium.org

Change-Id: I8077379ba565c8464acbb4bddba6458b94766b50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/832522
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524824}
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chrome/common/crash_keys.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chrome/common/crash_keys_unittest.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chrome/installer/setup/installer_crash_reporter_client.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chrome/installer/setup/installer_crash_reporting.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chrome/installer/setup/installer_crash_reporting.h
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/content/app/breakpad_linux.h
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/DEPS
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/BUILD.gn
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_key.h
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_key_breakpad_ios.mm
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_key_crashpad.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_key_stubs.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_keys.h
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/components/crash/core/common/crash_keys_unittest.cc
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/ios/chrome/app/chrome_exe_main.mm
[modify] https://crrev.com/b70184cd66f51db59fc2b5d3ff726e193a90f61a/ios/chrome/browser/crash_report/crash_keys.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b71aa96b30f8168c7f116e809f105d16efeae3c6

commit b71aa96b30f8168c7f116e809f105d16efeae3c6
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 18 23:49:56 2017

Revert "crash_keys: Convert "switches-N", "channel", and client ID to the new API."

This reverts commit 7776d543f6dc862198f22d6e79b9616ea851a603.

Reason for revert:
Looks like this is breaking following tests on the Linux Tests (dbg) bot:

- CrashKeysTest.Switches
- CrashKeysTest.FilterFlags
- CrashKeysTest.VariationsCapacity

See https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/46786

Original change's description:
> crash_keys: Convert "switches-N", "channel", and client ID to the new API.
> 
> Bug:  598854 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Ibb9031d4597d4c09bb6105f26aa02103f34b46a8
> Reviewed-on: https://chromium-review.googlesource.com/822833
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524771}

TBR=thestig@chromium.org,sdefresne@chromium.org,pkl@chromium.org,rsesek@chromium.org,mark@chromium.org

Change-Id: Id0c1151b78514e083e36f88e2fd1bd87e364de63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/833467
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524866}

Reg c#68: Sorry, please ignore this revert. It was no-op. I didn't notice that CL was already reverted.
Project Member

Comment 70 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abcdd842642df0d041790d7fa8a1865c582a4933

commit abcdd842642df0d041790d7fa8a1865c582a4933
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 19 02:34:14 2017

Reland "crash_keys: Convert "switches-N", "channel", and client ID to the new API."

This is a reland of 7776d543f6dc862198f22d6e79b9616ea851a603
Original change's description:
> crash_keys: Convert "switches-N", "channel", and client ID to the new API.
> 
> Bug:  598854 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Ibb9031d4597d4c09bb6105f26aa02103f34b46a8
> Reviewed-on: https://chromium-review.googlesource.com/822833
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524771}

Bug:  598854 
Change-Id: I7223c14d3a874f132300342b2cd9c1fa003f3259
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/832769
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524923}
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chrome/common/crash_keys.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chrome/common/crash_keys_unittest.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chrome/installer/setup/installer_crash_reporter_client.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chrome/installer/setup/installer_crash_reporting.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chrome/installer/setup/installer_crash_reporting.h
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/content/app/breakpad_linux.h
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/DEPS
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/BUILD.gn
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_key.h
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_key_breakpad_ios.mm
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_key_crashpad.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_key_stubs.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_keys.h
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/components/crash/core/common/crash_keys_unittest.cc
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/ios/chrome/app/chrome_exe_main.mm
[modify] https://crrev.com/abcdd842642df0d041790d7fa8a1865c582a4933/ios/chrome/browser/crash_report/crash_keys.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f93c5824ef35969cfb81a0064e1acabca7dd853

commit 0f93c5824ef35969cfb81a0064e1acabca7dd853
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 19 15:13:43 2017

crash_keys: Convert some keys in //chrome to the new API.

- "browser-unpin-trace"
- "extension-N"
- "num-extensions"
- "prn-info-N"
- "shutdown-type"
- "view-count"
- "zero-encode-details" (unused)

Bug:  598854 
Change-Id: I196772218e87e0deb4a4f14be4f6cd04a0136c56
Reviewed-on: https://chromium-review.googlesource.com/833196
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525037}
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/browser/browser_shutdown.cc
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/common/crash_keys.cc
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/common/crash_keys.h
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/common/crash_keys_unittest.cc
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/renderer/DEPS
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/0f93c5824ef35969cfb81a0064e1acabca7dd853/chromecast/crash/cast_crash_keys.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f88863f430c77b1261531cbc6c4320481d4caf3d

commit f88863f430c77b1261531cbc6c4320481d4caf3d
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 19 22:04:45 2017

crash_keys: Convert "url-chunk" to the new API.

Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id00c952881ef27f7383f537ecaad1b6fc8c369bb
Reviewed-on: https://chromium-review.googlesource.com/833790
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525153}
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/chrome/common/crash_keys.cc
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/chrome/common/crash_keys.h
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/components/viz/service/BUILD.gn
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/components/viz/service/gl/DEPS
[modify] https://crrev.com/f88863f430c77b1261531cbc6c4320481d4caf3d/components/viz/service/gl/gpu_service_impl.cc

Project Member

Comment 73 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b

commit a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Dec 19 23:50:31 2017

crash_keys: Covert "gl-context-set-current-stack-trace" to the new API.

Bug:  598854 , 724999
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3ccc320d8dbb6acb900cb7b31366d38e3fa809ac
Reviewed-on: https://chromium-review.googlesource.com/832710
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525187}
[modify] https://crrev.com/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b/chrome/common/crash_keys.cc
[modify] https://crrev.com/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b/ui/gl/BUILD.gn
[modify] https://crrev.com/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b/ui/gl/DEPS
[modify] https://crrev.com/a1ebddec3f21a2eb087b57c8f48d0fd9feccf02b/ui/gl/gl_context.cc

Project Member

Comment 74 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea3e79e5484d7e57fb746b5850bcbac9883fadc1

commit ea3e79e5484d7e57fb746b5850bcbac9883fadc1
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Dec 20 23:40:04 2017

crash_keys: Convert "variations" and "num-experiments" to the new API.

Tbr: pkl@chromium.org
Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia842c49d115bdbc3b9109039d6eaf6862fd82ff4
Reviewed-on: https://chromium-review.googlesource.com/836207
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525515}
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/chrome/common/crash_keys.cc
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/components/crash/core/common/crash_keys.h
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/components/crash/core/common/crash_keys_unittest.cc
[modify] https://crrev.com/ea3e79e5484d7e57fb746b5850bcbac9883fadc1/ios/chrome/browser/crash_report/crash_keys.cc

Project Member

Comment 76 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ac62ddadeeb52b41efe618ecfb29be1892bbff8

commit 0ac62ddadeeb52b41efe618ecfb29be1892bbff8
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Dec 21 23:35:32 2017

crash_keys: Use a non-chunked key name if the value fits in one slot.

When using the Breakpad implementation of crash keys, if the value's
max size is larger than a single storage slot, the value gets split into
keys named "name__1" to "name__N".

With this change, if the value fits within a single slot, the name will
just be "name" and not "name__1". This matches how LongStringDictionary
and the crash collector expect the keys to be named.

Bug:  598854 
Change-Id: Id7011b616e393ce0c13f9e944a9a84f64f2c72a7
Reviewed-on: https://chromium-review.googlesource.com/840221
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525853}
[modify] https://crrev.com/0ac62ddadeeb52b41efe618ecfb29be1892bbff8/components/crash/core/common/crash_key_breakpad.cc
[modify] https://crrev.com/0ac62ddadeeb52b41efe618ecfb29be1892bbff8/components/crash/core/common/crash_key_breakpad_unittest.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b68160a86147a185c21d45fbed7dd15a358ab2

commit a9b68160a86147a185c21d45fbed7dd15a358ab2
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Jan 02 20:12:23 2018

Remove the old base/debug/crash_logging.h API.

Bug:  598854 ,  568664 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I65e453144c9d465579101269e0963cd4319abc33
Reviewed-on: https://chromium-review.googlesource.com/838281
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526527}
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/android_webview/common/crash_reporter/crash_keys.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/base/debug/crash_logging.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/base/debug/crash_logging.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/base/debug/crash_logging_unittest.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/app/chrome_crash_reporter_client.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/app/chrome_crash_reporter_client_win.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/browser/metrics/metrics_reporting_state.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/common/child_process_logging_win.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/common/crash_keys.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/common/crash_keys.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/installer/setup/installer_crash_reporter_client.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chrome/installer/setup/installer_crash_reporter_client.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chromecast/app/android/cast_crash_reporter_client_android.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chromecast/app/android/cast_crash_reporter_client_android.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/chromecast/crash/cast_crash_keys.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/content/app/breakpad_linux.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/content/app/breakpad_win.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/content/app/crash_keys_win_unittest.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/content/app/crash_reporter_client.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/content/app/crashpad.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/components/crash/core/common/crash_keys.h
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/ios/chrome/app/chrome_exe_main.mm
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/ios/chrome/browser/crash_report/BUILD.gn
[modify] https://crrev.com/a9b68160a86147a185c21d45fbed7dd15a358ab2/ios/chrome/browser/crash_report/breakpad_helper.mm
[delete] https://crrev.com/aa85f190a8942a819ca1aa54a67dc7abd512c96d/ios/chrome/browser/crash_report/crash_keys.cc
[delete] https://crrev.com/aa85f190a8942a819ca1aa54a67dc7abd512c96d/ios/chrome/browser/crash_report/crash_keys.h

Project Member

Comment 78 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63875916dcf6535282293bfe590db00125815316

commit 63875916dcf6535282293bfe590db00125815316
Author: Antoine Labour <piman@chromium.org>
Date: Thu Jan 04 02:49:44 2018

Merge //gpu/config:crash_keys into //gpu/config

After crrev.com/c/812525, crash_keys doesn't need to be a separate
source_set duplicated in many components. Just make it part of the gpu
component.

Bug:  598854 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibaa2e994087401f267a685e0a3c3c7a8f930656d
Reviewed-on: https://chromium-review.googlesource.com/849492
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526905}
[modify] https://crrev.com/63875916dcf6535282293bfe590db00125815316/chrome/test/BUILD.gn
[modify] https://crrev.com/63875916dcf6535282293bfe590db00125815316/gpu/config/BUILD.gn
[modify] https://crrev.com/63875916dcf6535282293bfe590db00125815316/gpu/config/gpu_crash_keys.h
[modify] https://crrev.com/63875916dcf6535282293bfe590db00125815316/gpu/ipc/BUILD.gn
[modify] https://crrev.com/63875916dcf6535282293bfe590db00125815316/gpu/ipc/service/BUILD.gn

Project Member

Comment 79 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21f5a441f9d8a37d167c34777f2540b093297259

commit 21f5a441f9d8a37d167c34777f2540b093297259
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Jan 05 19:43:32 2018

Move crash keys documentation from Sites into the tree as Markdown.

This also updates it for the new crash keys v2 API.

The documentation previously lived at
https://dev.chromium.org/developers/debugging-with-crash-keys.

No-Try: True
Bug:  598854 
Change-Id: I9b672bb40bc6cf7e396644ed3af6de5a90f0478e
Reviewed-on: https://chromium-review.googlesource.com/848538
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527345}
[add] https://crrev.com/21f5a441f9d8a37d167c34777f2540b093297259/docs/debugging_with_crash_keys.md

Project Member

Comment 80 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cff9f91ff4bad55dff176fceebd32784c956153

commit 8cff9f91ff4bad55dff176fceebd32784c956153
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Jan 10 22:39:19 2018

Stop allocating a SimpleStringDictionary for Crashpad clients.

Bug:  598854 ,  749970 
Change-Id: I1886528b886b14f5151842de486a058d726f8ace
Reviewed-on: https://chromium-review.googlesource.com/850952
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528451}
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/chrome_elf/chrome_elf_x64.def
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/chrome_elf/chrome_elf_x86.def
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crash_export_stubs.cc
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crash_export_thunks.cc
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crash_export_thunks.h
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crashpad.cc
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crashpad.h
[modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crashpad_mac.mm

Status: Fixed (was: Started)
All done.
I'm working on migrating the Brave browser to the new crash keys API, unfortunately, there are some calls that happen from Javascript and this was performed with a generic SetCrashKeyValue(string, string) method: https://github.com/brave/muon/blob/master/muon/app/muon_crash_reporter_client.cc#L145

The requirement of using static storage variables makes this use case much harder. Any ideas on how to do this?
I would also be interested in the answer to comment #82 since CEF currently supports dynamic registration of crash keys at startup using the old InitCrashKeys/SetCrashKeyValue API.
Please see (and continue if necessary) the discussion here: https://groups.google.com/a/chromium.org/forum/#!topic/crashpad-dev/O40ZixLBV6A

Sign in to add a comment