Quirks Post-release code cleanup |
|||||||
Issue descriptionAfter the Quirks code has been in the wild for a release or two, there is some code cleanup that should be done: 1) Remove experimental flag #enable-quirks-client 2) Remove random delay for initial Quirks Server check. See https://code.google.com/p/chromium/codesearch#chromium/src/components/quirks/quirks_manager.cc&l=225 3) At present, if the server returns a 5XX error, the Client will recheck the server with exponential backoff. Add code so that, after a certain amount of time or checks, we give up and mark that file as checked, so that we don't look again for 30 days. 4) There are still 7 icc files hard-coded into all Chromebooks at /usr/share/color/icc/. Consider removing these files, and the code to look for them. See https://code.google.com/p/chromium/codesearch#chromium/src/components/quirks/quirks_manager.cc&l=49
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b commit b207f7a5c9cd60d4c68fe207b9b8b1949c46362b Author: glevin <glevin@chromium.org> Date: Fri Jun 03 14:50:02 2016 Remove Quirks flag, limit server retries BUG= 598841 TEST=Check that disable-quirks-client is no longer on the experimental flags list. This removes the disable-quirks-client command line flag, and places a limit of 10 on the number of times (with exponential backoff) that Chrome OS will attempt to contact the Quirks server in one session. Review-Url: https://codereview.chromium.org/2016883003 Cr-Commit-Position: refs/heads/master@{#397704} [modify] https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b/ash/display/display_color_manager_chromeos_unittest.cc [modify] https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b/chrome/browser/about_flags.cc [modify] https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b/components/quirks.gypi [modify] https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b/components/quirks/BUILD.gn [modify] https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b/components/quirks/quirks_client.cc [modify] https://crrev.com/b207f7a5c9cd60d4c68fe207b9b8b1949c46362b/components/quirks/quirks_manager.cc [delete] https://crrev.com/6b4478c2f9878f15543c62119e39f1e4b424a156/components/quirks/switches.cc [delete] https://crrev.com/6b4478c2f9878f15543c62119e39f1e4b424a156/components/quirks/switches.h
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bbe13103a5a5ce3940a529d986f68ded2e19ac6 commit 0bbe13103a5a5ce3940a529d986f68ded2e19ac6 Author: glevin <glevin@chromium.org> Date: Mon Jul 11 01:15:02 2016 Remove first check random delay on older devices BUG= 598841 TEST=Not easily testable, as this CL removes code that is no longer active after a first Quirks server check; we expect nearly all devices should have made a server check as of M-54, if they're ever going to. Review-Url: https://codereview.chromium.org/2006143011 Cr-Commit-Position: refs/heads/master@{#404587} [modify] https://crrev.com/0bbe13103a5a5ce3940a529d986f68ded2e19ac6/ash/display/display_color_manager_chromeos_unittest.cc [modify] https://crrev.com/0bbe13103a5a5ce3940a529d986f68ded2e19ac6/chrome/browser/chromeos/display/quirks_manager_delegate_impl.cc [modify] https://crrev.com/0bbe13103a5a5ce3940a529d986f68ded2e19ac6/chrome/browser/chromeos/display/quirks_manager_delegate_impl.h [modify] https://crrev.com/0bbe13103a5a5ce3940a529d986f68ded2e19ac6/components/quirks/quirks_manager.cc [modify] https://crrev.com/0bbe13103a5a5ce3940a529d986f68ded2e19ac6/components/quirks/quirks_manager.h
,
Jul 13 2016
Status of items in initial report: 1) Remove #enable-quirks-client - Done (first CL, M-53) 2) Remove random delay - Done (second CL, M-54) (note: link no longer valid) 3) Limit server rechecks per session - Done (first CL, M-53) 4) Decision about 7 hard-coded files - 5 removed for bad data, 2 left as is
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by glevin@chromium.org
, May 27 2016