New issue
Advanced search Search tips

Issue 598820 link

Starred by 2 users
Status: Fixed
Owner:
rohitrao@chromium.org
Closed: Mar 2016
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 554298



Sign in to add a comment

Convert ios internal code to use std::unique_ptr instead of scoped_ptr

Project Member Reported by rohitrao@chromium.org, Mar 29 2016 
The two classes are equivalent (scoped_ptr is actually just a typedef now), so we can go through and update all uses on ios.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/be960ddd20d6c1d3e1ebea63dff889e38310eb44

commit be960ddd20d6c1d3e1ebea63dff889e38310eb44
Author: rohitrao <rohitrao@google.com>
Date: Tue Mar 29 20:40:44 2016
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d2d1bf3b7b9c8c506a829c8b5b415bf5eb7e4edf

commit d2d1bf3b7b9c8c506a829c8b5b415bf5eb7e4edf
Author: rohitrao <rohitrao@google.com>
Date: Tue Mar 29 21:07:16 2016
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8c89f2b63e4c133b08255f90e033c7a1e3a5a6b8

commit 8c89f2b63e4c133b08255f90e033c7a1e3a5a6b8
Author: rohitrao <rohitrao@google.com>
Date: Tue Mar 29 21:36:22 2016
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d189ed2cbe7270a9c7ed10bab2b6124080a7660c

commit d189ed2cbe7270a9c7ed10bab2b6124080a7660c
Author: rohitrao <rohitrao@google.com>
Date: Wed Mar 30 11:44:20 2016
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d189ed2cbe7270a9c7ed10bab2b6124080a7660c

commit d189ed2cbe7270a9c7ed10bab2b6124080a7660c
Author: rohitrao <rohitrao@google.com>
Date: Wed Mar 30 11:44:20 2016
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/360e99a89813da277db639626221bc3182cf1780

commit 360e99a89813da277db639626221bc3182cf1780
Author: rohitrao <rohitrao@google.com>
Date: Wed Mar 30 13:26:43 2016
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/360e99a89813da277db639626221bc3182cf1780

commit 360e99a89813da277db639626221bc3182cf1780
Author: rohitrao <rohitrao@google.com>
Date: Wed Mar 30 13:26:43 2016
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/cafc8c64a6ce8ebdefd1fa64ba2518aa20eca446

commit cafc8c64a6ce8ebdefd1fa64ba2518aa20eca446
Author: rohitrao <rohitrao@google.com>
Date: Thu Mar 31 04:17:26 2016
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3a9f932612d131af7b28fc845ef98649755a03d1

commit 3a9f932612d131af7b28fc845ef98649755a03d1
Author: rohitrao <rohitrao@google.com>
Date: Thu Mar 31 04:17:51 2016
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ed5569882c0edfb125d251834ac550bb44b79df1

commit ed5569882c0edfb125d251834ac550bb44b79df1
Author: rohitrao <rohitrao@google.com>
Date: Thu Mar 31 13:50:41 2016
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0bbb67dca6fe73af8e00cc4cfb0cdff02fe0f379

commit 0bbb67dca6fe73af8e00cc4cfb0cdff02fe0f379
Author: rohitrao <rohitrao@google.com>
Date: Thu Mar 31 14:16:24 2016

Comment 12 by rohitrao@chromium.org, Mar 31 2016

Status: Fixed (was: Started)
Cleanup was done with the following commands:

/Users/Shared/Chrome/ios/src/tools/git/mffr.py "make_scoped_ptr" "base::WrapUnique"
# Add #include "base/memory/ptr_util.h" to all files
git commit -a

/Users/Shared/Chrome/ios/src/tools/git/mffr.py '#import "base/memory/scoped_ptr.h"' '#include <memory>'
# Fix header sort order manually
git commit -a --amend
/Users/Shared/Chrome/ios/src/tools/git/mffr.py '#include "base/memory/scoped_ptr.h"' '#include <memory>'
emacs $(git diff --name-only)
git commit -a --amend

git show --name-only
pbpaste | xargs /Users/Shared/Chrome/ios/src/tools/sort-headers.py -f
git commit -a --amend

/Users/Shared/Chrome/ios/src/tools/git/mffr.py "scoped_ptr" "std::unique_ptr"
git commit -a --amend
►

Sign in to add a comment