New issue
Advanced search Search tips

Issue 598808 link

Starred by 2 users
Status: Fixed
Owner:
scottmg@chromium.org
Closed: Jun 2016
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

git_drover.py failed as a result of a ginormous command line?

Project Member Reported by grt@chromium.org, Mar 29 2016 
Looks like I'm gonna drover the old fashioned way. What am I, a farmer?

C:\src\chrome\shared\src>git drover --cherry-pick a349cae3d63e650588498b5b9f298e25f6053903 --branch 2623
Going to cherry-pick
...
Junction created for c:\users\grt\appdata\local\temp\drover_2623_aalyid\.git\refs <<===>> C:\src\chrome\shared\src\.git\refs
Junction created for c:\users\grt\appdata\local\temp\drover_2623_aalyid\.git\logs\refs <<===>> C:\src\chrome\shared\src\.git\logs\refs
Junction created for c:\users\grt\appdata\local\temp\drover_2623_aalyid\.git\objects <<===>> C:\src\chrome\shared\src\.git\objects
Junction created for c:\users\grt\appdata\local\temp\drover_2623_aalyid\.git\hooks <<===>> C:\src\chrome\shared\src\.git\hooks
Error: Command 'update-index --skip-worktree -- ...'failed: [Error 206] The filename or extension is too long

Comment 1 by scottmg@chromium.org, Mar 29 2016 

I ran into this trying to drover with pkasting a few days ago too. I think it's probably specific to the change-delta from HEAD to 2623.

From a quick look, it looked like it was working "correctly", but just not well-suited to Windows. I didn't have a chance to try to rework drover to use a file for the command line though.

Another workaround which may or may not be easier than FarmerDrover is using a Mac or Linux box where it's likely to be OK.

Comment 2 by scottmg@chromium.org, Jun 13 2016

Cc: pkasting@chromium.org
Fix to drover posted at https://codereview.chromium.org/2067653002/.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/0205656321a66c2d2af5b71fad0caaa0f6391c27

commit 0205656321a66c2d2af5b71fad0caaa0f6391c27
Author: scottmg <scottmg@chromium.org>
Date: Thu Jun 16 00:21:04 2016

drover win: Use --stdin so update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG= 598808 

Review-Url: https://codereview.chromium.org/2067653002

[modify] https://crrev.com/0205656321a66c2d2af5b71fad0caaa0f6391c27/git_drover.py
[modify] https://crrev.com/0205656321a66c2d2af5b71fad0caaa0f6391c27/tests/git_drover_test.py

Comment 4 by scottmg@chromium.org, Jun 16 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/a54265971ed8380214881f80b8d44942b99a2ec4

commit a54265971ed8380214881f80b8d44942b99a2ec4
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jun 16 00:25:30 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/f3c688bf2ccbd54a302f69846b97e51c3e2fcc82 Fix presubmit checkout test after git 2.9.0 (scottmg@chromium.org)
  https://crrev.com/0205656321a66c2d2af5b71fad0caaa0f6391c27 drover win: Use --stdin so update-index doesn't fail on long cmdline (scottmg@chromium.org)

R=tandrii@chromium.org,iannucci@chromium.org,scottmg@chromium.org
BUG= 598808 , 619959 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2073653002

[modify] https://crrev.com/a54265971ed8380214881f80b8d44942b99a2ec4/infra/config/recipes.cfg
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b3af2b14e935491432f01f9625be093994c77af6

commit b3af2b14e935491432f01f9625be093994c77af6
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jun 16 00:46:03 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/a54265971ed8380214881f80b8d44942b99a2ec4 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/f3c688bf2ccbd54a302f69846b97e51c3e2fcc82 Fix presubmit checkout test after git 2.9.0 (scottmg@chromium.org)
  https://crrev.com/0205656321a66c2d2af5b71fad0caaa0f6391c27 drover win: Use --stdin so update-index doesn't fail on long cmdline (scottmg@chromium.org)

R=tandrii@chromium.org,iannucci@chromium.org,scottmg@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org,recipe-roller@chromium.org
BUG= 598808 , 619959 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2068073003

[modify] https://crrev.com/b3af2b14e935491432f01f9625be093994c77af6/infra/config/recipes.cfg
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/f372357a8eadf462ca07a546a8e0793db6a177d9

commit f372357a8eadf462ca07a546a8e0793db6a177d9
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jun 16 00:28:39 2016
►

Sign in to add a comment