New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 598802 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Eliminate verifier profile from sync_integration_tests

Project Member Reported by sh...@chromium.org, Mar 29 2016 
sync_integration_tests has a default verifier profile. Most of the use of this profile is redundant especially in two clients tests. It adds complexity to the tests and maintenance cost. 

The plan is to completely get rid of the verifier profile in steps:
1- disable verifier profile from two client tests
2- disable verifier profile from one client tests
3- explicitly enable verifier profile if there is a good reason why some tests *do need* it (versus being enabled by default).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4

commit d2ab74fab3dee525cadb6838bb65eb6b3580b4d4
Author: shadi <shadi@chromium.org>
Date: Fri Apr 01 01:17:04 2016

[Sync] Eliminate verifier profile from sync_integration_tests

This is one of a series of changes to get rid of verifier profile in two client
sync integration tests.

This CL affects apps and app_list two client tests only.

BUG= 598802 

Review URL: https://codereview.chromium.org/1834323004

Cr-Commit-Position: refs/heads/master@{#384462}

[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/apps_helper.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/apps_helper.h
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/autofill_helper.h
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/extensions_helper.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/single_client_apps_sync_test.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/sync_app_list_helper.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/sync_app_list_helper.h
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/sync_test.h
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
[modify] https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884face55032f7e2e30276f633f95f8e8126ac28

commit 884face55032f7e2e30276f633f95f8e8126ac28
Author: lukasza <lukasza@chromium.org>
Date: Fri Apr 01 18:21:47 2016

Revert of [Sync] Eliminate verifier profile from sync_integration_tests (patchset #3 id:60001 of https://codereview.chromium.org/1834323004/ )

Reason for revert:
This CL has resulted in test flakiness - please see  https://crbug.com/599787 

Original issue's description:
> [Sync] Eliminate verifier profile from sync_integration_tests
>
> This is one of a series of changes to get rid of verifier profile in two client
> sync integration tests.
>
> This CL affects apps and app_list two client tests only.
>
> BUG= 598802 
>
> Committed: https://crrev.com/d2ab74fab3dee525cadb6838bb65eb6b3580b4d4
> Cr-Commit-Position: refs/heads/master@{#384462}

TBR=zea@chromium.org,shadi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 598802 

Review URL: https://codereview.chromium.org/1850253002

Cr-Commit-Position: refs/heads/master@{#384634}

[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/apps_helper.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/apps_helper.h
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/autofill_helper.h
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/extensions_helper.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/single_client_apps_sync_test.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/sync_app_list_helper.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/sync_app_list_helper.h
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/sync_test.h
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
[modify] https://crrev.com/884face55032f7e2e30276f633f95f8e8126ac28/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/302d0ea71f818208bb2cded1a7a61f77ca7d083c

commit 302d0ea71f818208bb2cded1a7a61f77ca7d083c
Author: shadi <shadi@chromium.org>
Date: Mon Apr 04 21:14:48 2016

[Sync] Eliminate verifier profile from sync_integration_tests

This is one of a series of changes to get rid of verifier profile in two client
sync integration tests.

This CL affects apps and app_list two client tests only.

BUG= 598802 

Review URL: https://codereview.chromium.org/1851243002

Cr-Commit-Position: refs/heads/master@{#385006}

[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/apps_helper.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/apps_helper.h
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/autofill_helper.h
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/extensions_helper.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/single_client_apps_sync_test.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/sync_app_list_helper.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/sync_app_list_helper.h
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/sync_test.h
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
[modify] https://crrev.com/302d0ea71f818208bb2cded1a7a61f77ca7d083c/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc

Comment 4 by sh...@chromium.org, May 23 2016

Owner: ----
Status: Available (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, May 24 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by pnoland@chromium.org, Jan 17 2018

Status: WontFix (was: Untriaged)
►

Sign in to add a comment