New issue
Advanced search Search tips

Issue 598798 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove canScroll code paths from Blink

Project Member Reported by dtapu...@chromium.org, Mar 29 2016

Issue description

With the move to gesture based mouse wheel scrolling the canScroll event code path can be removed from blink.
 
See  issue 568183  for the mouse wheel gesture scrolling enabling.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/256b95a4dce8f1e57e69ff0032ee16d4c76e580b

commit 256b95a4dce8f1e57e69ff0032ee16d4c76e580b
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Jun 08 18:09:12 2016

Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

Also remove the WebSetting for wheel gesture support.

BUG= 598798 

Review-Url: https://codereview.chromium.org/2049493002
Cr-Commit-Position: refs/heads/master@{#398618}

[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/content/renderer/render_view_impl.cc
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/web/WebSettingsImpl.cpp
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/web/WebSettingsImpl.h
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b/third_party/WebKit/public/web/WebSettings.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f5cea527647ebc8c505b1932d680854e162d82f

commit 3f5cea527647ebc8c505b1932d680854e162d82f
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Jun 08 22:59:17 2016

Remove enable/disable wheel gestures setting.

Since wheel gesture based scrolling has shipped and the code has been
removed from blink we can remove the runtime setting.

BUG= 598798 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2047093002
Cr-Commit-Position: refs/heads/master@{#398716}

[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/cc/proto/layer_tree_settings.proto
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/cc/trees/layer_tree_settings.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/components/test_runner/event_sender.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/components/test_runner/event_sender.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/components/test_runner/web_test_proxy.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/components/test_runner/web_test_proxy.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/input/mouse_wheel_event_queue.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/overscroll_controller.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[delete] https://crrev.com/f1c093508327909789e7f4ef322a9c391fadf93a/content/common/input/input_event_utils.cc
[delete] https://crrev.com/f1c093508327909789e7f4ef322a9c391fadf93a/content/common/input/input_event_utils.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/content_common.gypi
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/public/common/content_switches.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/public/common/content_switches.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/renderer/input/input_handler_wrapper.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/renderer/render_view_impl.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f/ui/events/blink/input_handler_proxy_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8

commit 463485dabfd8526d0d2a65ad9a42e0c28d5bffb8
Author: scheib <scheib@chromium.org>
Date: Thu Jun 09 00:11:53 2016

Revert of Remove enable/disable wheel gestures setting. (patchset #3 id:40001 of https://codereview.chromium.org/2047093002/ )

Reason for revert:
Caused RenderWidgetHostViewMacTest.IgnoreEmptyUnhandledWheelEventWithWheelGestures failure on build:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/25325

See
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/25325

Test output:
"""
[ RUN      ] RenderWidgetHostViewMacTest.IgnoreEmptyUnhandledWheelEventWithWheelGestures
../../content/browser/renderer_host/render_widget_host_view_mac_unittest.mm:966: Failure
Value of: view_delegate.get().unhandledWheelEventReceived
  Actual: ''
Expected: __objc_yes
Which is: '?' (1)
[3372:1287:0608/164121:1128775946716:FATAL:surface_manager.cc(43)] Check failed: namespace_client_map_.size() == 0u (1 vs. 0)
"""

Original issue's description:
> Remove enable/disable wheel gestures setting.
>
> Since wheel gesture based scrolling has shipped and the code has been
> removed from blink we can remove the runtime setting.
>
> BUG= 598798 
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f
> Cr-Commit-Position: refs/heads/master@{#398716}

TBR=aelias@chromium.org,rbyers@chromium.org,creis@chromium.org,dtapuska@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 598798 

Review-Url: https://codereview.chromium.org/2050033002
Cr-Commit-Position: refs/heads/master@{#398746}

[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/cc/proto/layer_tree_settings.proto
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/cc/trees/layer_tree_settings.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/components/test_runner/event_sender.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/components/test_runner/event_sender.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/components/test_runner/web_test_proxy.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/components/test_runner/web_test_proxy.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/input/mouse_wheel_event_queue.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/overscroll_controller.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[add] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/common/input/input_event_utils.cc
[add] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/common/input/input_event_utils.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/content_common.gypi
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/public/common/content_switches.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/public/common/content_switches.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/renderer/input/input_handler_wrapper.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/renderer/render_view_impl.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8/ui/events/blink/input_handler_proxy_unittest.cc

 Issue 618519  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c

commit e7dd21de6085f5cdc0cfe4eaeeda56f27006761c
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Jun 09 13:41:56 2016

Remove enable/disable wheel gestures setting.

Since wheel gesture based scrolling has shipped and the code has been
removed from blink we can remove the runtime setting.

BUG= 598798 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f
Review-Url: https://codereview.chromium.org/2047093002
Cr-Original-Commit-Position: refs/heads/master@{#398716}
Cr-Commit-Position: refs/heads/master@{#398862}

[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/proto/layer_tree_settings.proto
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_settings.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/event_sender.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/event_sender.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/web_test_proxy.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/web_test_proxy.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/mouse_wheel_event_queue.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/overscroll_controller.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[delete] https://crrev.com/ec94e403759a6bda791259c83f8cc7ed46b2857b/content/common/input/input_event_utils.cc
[delete] https://crrev.com/ec94e403759a6bda791259c83f8cc7ed46b2857b/content/common/input/input_event_utils.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/content_common.gypi
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/public/common/content_switches.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/public/common/content_switches.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_wrapper.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/render_view_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/ui/events/blink/input_handler_proxy_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c

commit e7dd21de6085f5cdc0cfe4eaeeda56f27006761c
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Jun 09 13:41:56 2016

Remove enable/disable wheel gestures setting.

Since wheel gesture based scrolling has shipped and the code has been
removed from blink we can remove the runtime setting.

BUG= 598798 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f
Review-Url: https://codereview.chromium.org/2047093002
Cr-Original-Commit-Position: refs/heads/master@{#398716}
Cr-Commit-Position: refs/heads/master@{#398862}

[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/proto/layer_tree_settings.proto
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_settings.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/event_sender.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/event_sender.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/web_test_proxy.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/components/test_runner/web_test_proxy.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/mouse_wheel_event_queue.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/overscroll_controller.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[delete] https://crrev.com/ec94e403759a6bda791259c83f8cc7ed46b2857b/content/common/input/input_event_utils.cc
[delete] https://crrev.com/ec94e403759a6bda791259c83f8cc7ed46b2857b/content/common/input/input_event_utils.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/content_common.gypi
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/public/common/content_switches.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/public/common/content_switches.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/input/input_handler_wrapper.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/renderer/render_view_impl.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c/ui/events/blink/input_handler_proxy_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8b21416f450a43606e6195b8628b4a903ea439b

commit b8b21416f450a43606e6195b8628b4a903ea439b
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Jun 16 11:09:14 2016

Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG= 598798 
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2052663004
Cr-Commit-Position: refs/heads/master@{#400129}

[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/components/test_runner/event_sender.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/browser/renderer_host/web_input_event_aura.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/common/input/web_input_event_traits.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/common/input/web_input_event_traits.h
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/common/input/web_input_event_traits_unittest.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/mojo/converters/blink/blink_input_events_type_converters.cc
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/Source/core/events/WheelEvent.cpp
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/Source/core/events/WheelEvent.h
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/Source/platform/PlatformWheelEvent.h
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/third_party/WebKit/public/web/WebInputEvent.h
[modify] https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b/ui/events/blink/input_handler_proxy.cc

Labels: Hotlist-Fixit-PE2016
Status: Fixed (was: Assigned)

Sign in to add a comment