New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598775 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Lots of suspicious-looking V8 Proxy Resolver utility processes

Project Member Reported by w...@chromium.org, Mar 29 2016

Issue description

Version: 50.0.2661.32 
OS: ChromeOS

What steps will reproduce the problem?
No idea what will repro this, but I noticed it while checked the number of leaked file-descriptors via Task Manager, for issue 598770.

What is the expected output?

Expect that there is at most a single V8 Proxy Resolver utility process.

What do you see instead?

There are nine such processes listed in Task Manager, eight of which look suspiciously like zombie processes.

Please use labels and text to provide additional information.

 
Cc: eroman@chromium.org amistry@chromium.org
Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Is M50 when the out-of-process resolver started getting used more? If so, looks like there might be an issue hence marking P1.
Cc: -amistry@chromium.org
Owner: amistry@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by w...@chromium.org, Mar 29 2016

FWIW shortly before I noticed things were in this state I appeared to have a ~520MB V8 Proxy Resolver utility process running, according to Task Manager.
Sounds like we might not be cleaning up the UtilityProcessHost in some cases. I'm on it.

And if anyone else sees this, can you go to chrome://system and look at the output of "ps" to see if there are actually any zombie processes (which will have a "Z" in the stat column).
I'm seeing this on my Pixel now. I've got one extra proxy resolver process in the task manager, but according to ps, the process doesn't exist at all.
This is a task manager bug. I can reliably reproduce this and there are no leaked processes or UtilityProcessHost. What's happening is that when there's no pac script, the resolver utility process will be shut down after a 5 second timeout. However, when a utility process (or anything that uses BrowserChildProcessHostImpl) is shut down from the browser process, there's no notification that the process is gone, and so the task manager remembers it.

Comment 7 by w...@chromium.org, Mar 30 2016

Cc: afakhry@chromium.org
Cc: nick@chromium.org
The task manager uses BrowserChildProcessObserver::BrowserChildProcessHostDisconnected() to watch for the termination of a browser child process. If this doesn't get called, there's no way the task manager will be notified to remove the task.
BrowserChildProcessHostDisconnected doesn't get called when the process is shut down by the browser. I have a fix that I'm testing.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/012289f7b6689dff062785907d2475ab4d9b9496

commit 012289f7b6689dff062785907d2475ab4d9b9496
Author: amistry <amistry@chromium.org>
Date: Fri Apr 01 00:56:37 2016

Notify observers if a running browser child process is shut down by deleting the BrowserChildProcessHostImpl.

BUG= 598775 

Review URL: https://codereview.chromium.org/1843663003

Cr-Commit-Position: refs/heads/master@{#384454}

[modify] https://crrev.com/012289f7b6689dff062785907d2475ab4d9b9496/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/012289f7b6689dff062785907d2475ab4d9b9496/content/browser/browser_child_process_host_impl.h

Status: Fixed (was: Assigned)
Tested 51.0.2699.0 and issue is gone.
Status: Verified (was: Fixed)
bulk verify (M50 clean up)

Sign in to add a comment