Bug droid should update chromium bug when catapult changes link the bug with BUG=chromium:... |
||||
Issue descriptionContext: Speed-infra team maintains a github repo (https://github.com/catapult-project/catapult) for our tooling & framework (e.g: telemetry). Quite often, a bug in chromium is addressed by commits land into catapult (e.g: issue 598359 ). Since people who commit code to catapult also use rietveld and have the practice of specifying BUG=chromium:<zyz> in the CL description, it would be great if bug droid can update crbug once those catapult CLs (e.g: https://codereview.chromium.org/1839713002/) are committed just like chromium CLs.
,
Mar 29 2016
+borenet: Is it possible for the skia roller to pick up "BUG= chromium:12345 " lines from the CLs it autorolls and update those chromium bugs?
,
Mar 29 2016
Sure, that should be doable.
,
Mar 29 2016
@borenet: can we assign you to make the change to skia roller?
,
Mar 29 2016
Yep, I'll do it.
,
Apr 4 2016
The following revision refers to this bug: https://skia.googlesource.com/buildbot.git/+/2fb6667166f94531c6fd0df13570f5d1b650922a commit 2fb6667166f94531c6fd0df13570f5d1b650922a Author: borenet <borenet@chromium.org> Date: Mon Apr 04 16:51:16 2016 AutoRolls include Chromium bug links BUG= 598773 Review URL: https://codereview.chromium.org/1849283002 [modify] https://crrev.com/2fb6667166f94531c6fd0df13570f5d1b650922a/autoroll/go/repo_manager/repo_manager.go [modify] https://crrev.com/2fb6667166f94531c6fd0df13570f5d1b650922a/go/util/util.go [modify] https://crrev.com/2fb6667166f94531c6fd0df13570f5d1b650922a/go/util/util_test.go
,
Apr 5 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/74f047b58b70935f21cc08d30b7cc789b22bc7cf commit 74f047b58b70935f21cc08d30b7cc789b22bc7cf Author: borenet <borenet@chromium.org> Date: Tue Apr 05 12:57:46 2016 Whitespace change to test Bugdroid+AutoRoll BUG= 598773 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003 Review URL: https://codereview.chromium.org/1856373003 [modify] https://crrev.com/74f047b58b70935f21cc08d30b7cc789b22bc7cf/whitespace.txt
,
Apr 5 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/cd76ae50e9bba22282a283eb18d092291b1f98ad commit cd76ae50e9bba22282a283eb18d092291b1f98ad Author: borenet <borenet@google.com> Date: Tue Apr 05 15:25:38 2016 Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1856373003/ ) Reason for revert: Try again. Original issue's description: > Whitespace change to test Bugdroid+AutoRoll > > BUG= 598773 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003 > > Committed: https://skia.googlesource.com/skia/+/74f047b58b70935f21cc08d30b7cc789b22bc7cf TBR=borenet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 598773 Review URL: https://codereview.chromium.org/1861713002 [modify] https://crrev.com/cd76ae50e9bba22282a283eb18d092291b1f98ad/whitespace.txt
,
Apr 5 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/fea7de6c1459cb26c9e0a0c72033e9ccaea56530 commit fea7de6c1459cb26c9e0a0c72033e9ccaea56530 Author: borenet <borenet@google.com> Date: Tue Apr 05 17:12:56 2016 Reland of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1861713002/ ) Reason for revert: Retry again Original issue's description: > Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1856373003/ ) > > Reason for revert: > Try again. > > Original issue's description: > > Whitespace change to test Bugdroid+AutoRoll > > > > BUG= 598773 > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003 > > > > Committed: https://skia.googlesource.com/skia/+/74f047b58b70935f21cc08d30b7cc789b22bc7cf > > TBR=borenet@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 598773 > > Committed: https://skia.googlesource.com/skia/+/cd76ae50e9bba22282a283eb18d092291b1f98ad TBR=borenet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 598773 Review URL: https://codereview.chromium.org/1864573002 [modify] https://crrev.com/fea7de6c1459cb26c9e0a0c72033e9ccaea56530/whitespace.txt
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34e4ba3991a0c4d3949e179d8b281d9bc8df3b23 commit 34e4ba3991a0c4d3949e179d8b281d9bc8df3b23 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Tue Apr 05 17:21:35 2016 Roll src/third_party/skia/ 5c5cfe24e..b8797bb7b (4 commits). https://chromium.googlesource.com/skia.git/+log/5c5cfe24efe4..b8797bb7b74a $ git log 5c5cfe24e..b8797bb7b --date=short --no-merges --format='%ad %ae %s' 2016-04-05 bsalomon Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003 2016-04-05 rmistry Add valgrind suppression file to infrabots.isolate 2016-04-05 borenet Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1856373003/ ) 2016-04-05 rmistry Do not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind BUG= 598773 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=caryclark@google.com Review URL: https://codereview.chromium.org/1861003002 Cr-Commit-Position: refs/heads/master@{#385204} [modify] https://crrev.com/34e4ba3991a0c4d3949e179d8b281d9bc8df3b23/DEPS
,
Apr 5 2016
The following revision refers to this bug: https://skia.googlesource.com/buildbot.git/+/fc5350e7edf9fc2fa6aa463230c76d1f1e99e9ea commit fc5350e7edf9fc2fa6aa463230c76d1f1e99e9ea Author: borenet <borenet@chromium.org> Date: Tue Apr 05 17:28:10 2016 Fix AutoRoll+Bugdroid BUG= 598773 Review URL: https://codereview.chromium.org/1865503002 [modify] https://crrev.com/fc5350e7edf9fc2fa6aa463230c76d1f1e99e9ea/autoroll/go/repo_manager/repo_manager.go
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/094dc3bda268baf192d237fa77d11880489f22ac commit 094dc3bda268baf192d237fa77d11880489f22ac Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Tue Apr 05 18:39:05 2016 Roll src/third_party/skia/ b8797bb7b..fea7de6c1 (3 commits). https://chromium.googlesource.com/skia.git/+log/b8797bb7b74a..fea7de6c1459 $ git log b8797bb7b..fea7de6c1 --date=short --no-merges --format='%ad %ae %s' 2016-04-05 borenet Reland of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1861713002/ ) 2016-04-05 msarett Delete SkFlattenable::Type (part 1) 2016-04-05 robertphillips Update SkMorphology ImageFilters to sk_sp BUG= 598773 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=caryclark@google.com Review URL: https://codereview.chromium.org/1857243003 Cr-Commit-Position: refs/heads/master@{#385237} [modify] https://crrev.com/094dc3bda268baf192d237fa77d11880489f22ac/DEPS
,
Apr 5 2016
This seems to be working. Please re-open if there are any issues. |
||||
►
Sign in to add a comment |
||||
Comment 1 by kbr@chromium.org
, Mar 29 2016