New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598752 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit 16 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Security



Sign in to add a comment

kMainSRTDownloadURL is HTTP

Project Member Reported by nparker@chromium.org, Mar 29 2016

Issue description

Comment 1 by mad@chromium.org, Mar 30 2016

Cc: mad@chromium.org
Owner: macourteau@chromium.org
Marc-Antoine, can you take care of this please?

Comment 2 by mad@chromium.org, Apr 20 2016

 Issue 603609  has been merged into this issue.

Comment 3 by mad@chromium.org, Apr 20 2016

Cc: -mad@chromium.org macourteau@chromium.org
Owner: mad@chromium.org
I'll do it... I'm there now...
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff7b8097333f0abd117606334dc925b09a2b247f

commit ff7b8097333f0abd117606334dc925b09a2b247f
Author: mad <mad@chromium.org>
Date: Wed Apr 20 19:39:45 2016

Explicitly use HTTPS to download the CCT binary

TBR=mattm@chromium.org
BUG= 598752 

Review URL: https://codereview.chromium.org/1908613002

Cr-Commit-Position: refs/heads/master@{#388555}

[modify] https://crrev.com/ff7b8097333f0abd117606334dc925b09a2b247f/chrome/browser/safe_browsing/srt_field_trial_win.cc

Comment 5 by wfh@chromium.org, Apr 20 2016

Labels: -Type-Bug Type-Bug-Security
does this need a merge?

Comment 6 by wfh@chromium.org, Apr 20 2016

Labels: reward-topanel
This was already reported internally before the external report in  issue 603609  so I'm passing this to the VRP panel to decide if we can reward this or not.
wfh@ does it mean no reward for my  issue 603609 ? 

Comment 8 by wfh@chromium.org, Apr 20 2016

re: #7 that will be up to the VRP panel to decide.

Comment 9 by vakh@chromium.org, Apr 20 2016

Components: Services>Safebrowsing
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 21 2016

Labels: M-50

Comment 11 by mad@chromium.org, Apr 21 2016

Status: Fixed (was: Assigned)

Comment 12 by mad@chromium.org, Apr 21 2016

Labels: Merge-Request-51 Merge-Request-50

Comment 13 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M50), manual review required.

Comment 14 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Cc: tinazh@chromium.org
Labels: OS-Windows
OS-Windows by the looks of it.  Up to the desktop folks.
Before we approve merge to M50, Could you please confirm whether this bug is baked/verified in Canary and safe to merge? 
Please merge your change to M51 branch 2704 before 5:00 PM PST Monday (04/25/16) so we can take it for next week M51 Beta candidate cut. Thank you.
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 25 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2cb81025e77fc6ba0b8c0019a34d44aa8f9a00e

commit e2cb81025e77fc6ba0b8c0019a34d44aa8f9a00e
Author: Marc-Andre (MAD) Decoste <mad@google.com>
Date: Mon Apr 25 21:11:32 2016

Explicitly use HTTPS to download the CCT binary

TBR=mattm@chromium.org
BUG= 598752 

Review URL: https://codereview.chromium.org/1908613002

Cr-Commit-Position: refs/heads/master@{#388555}
(cherry picked from commit ff7b8097333f0abd117606334dc925b09a2b247f)

Review URL: https://codereview.chromium.org/1919043002 .

Cr-Commit-Position: refs/branch-heads/2704@{#229}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/e2cb81025e77fc6ba0b8c0019a34d44aa8f9a00e/chrome/browser/safe_browsing/srt_field_trial_win.cc

Comment 19 by mad@chromium.org, Apr 25 2016

Cc: jsc...@chromium.org wfh@chromium.org
Labels: -Security_Severity-High Security_Severity-Low
About the merge to M50, this bug is baked/verified in Canary and safe to merge.

But there's another discussion about on duplicate  issue 603609  where the security severity label was set to low (as I just did on this bug) so it might not be important enough to merge up to stable.

Opinions?

Comment 20 Deleted

Labels: -M-50 -Hotlist-Merge-review -Merge-Review-50 M-51 Release-0-M51
FWIW, we don't merge Sec-Sev-Low to stable, so this can roll in with the initial M51 release unless there's a strong objection.

Updating labels for M-51. If you want this to go in an M-50 patch, remove the "release" label and please add "Merge-triage"

Comment 22 Deleted

Tim - Thanks for the reward could you please credit me as "Khalil Zhani" not "jackwillzac"and Cc "chromium.khalil@gmail.com" as the right reporter.

Labels: -reward-topanel CVE-2016-1693 reward-unpaid Reward-500
Updated:

As you've already seen, the reward was $500 :) CVE-ID is CVE-2016-1693.

I'll add your payment into next wee's payment process. Thanks Khalil (and I'll note this email address as yours for future reference)
Also, just to note that we'd usually not reward this issue as your report is a duplicate of an existing issue. That said, we used our discretion to pay you anyway as your report sped up the resolution and brought more attention to this issue.
Labels: reward-inprocess
Labels: -reward-unpaid
Project Member

Comment 28 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 29 by sheriffbot@chromium.org, Oct 1 2016

Labels: Restrict-View-SecurityNotify
Project Member

Comment 30 by sheriffbot@chromium.org, Oct 2 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic
Labels: CVE_description-submitted
Project Member

Comment 33 by sheriffbot@chromium.org, Jul 28

Labels: -Pri-1 Pri-2

Sign in to add a comment