New issue
Advanced search Search tips

Issue 598705 link

Starred by 2 users
Status: Archived
Owner:
sullivan@chromium.org
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Re-enable dromaeo.jslibmodifyjquery.reference for windows once ref build is past M51

Project Member Reported by sullivan@chromium.org, Mar 29 2016 
Ned, this is really weird. The logs look like a crash, but the red/green pattern lines up with the reverts/relands of https://codereview.chromium.org/1830253003/

https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf%20%283%29?numbuilds=200

Any ideas? I think it is okay to just disable the ref build here, especially if we can restrict the ref disable to win10.

Comment 1 by nedngu...@google.com, Mar 29 2016 

It was specified to be disabled on win7 & win8 before:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/benchmarks/dromaeo.py&l=241

We just need to change those all to 'win'.

Comment 2 by nedngu...@google.com, Mar 29 2016 

Actually change this to 'reference-win' because dromeao.jslibmodifyjquery seems to be passing now.

Comment 3 by sullivan@chromium.org, Mar 29 2016

Owner: sullivan@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3546e1ba20748c743ad2736c6567ec65666b62

commit fb3546e1ba20748c743ad2736c6567ec65666b62
Author: sullivan <sullivan@chromium.org>
Date: Tue Mar 29 18:02:35 2016

Disable windows reference for dromaeo.jslibmodifyjquery

TBR=nednguyen@google.com
BUG= 598705 

Review URL: https://codereview.chromium.org/1836233003

Cr-Commit-Position: refs/heads/master@{#383768}

[modify] https://crrev.com/fb3546e1ba20748c743ad2736c6567ec65666b62/tools/perf/benchmarks/dromaeo.py

Comment 5 by sullivan@chromium.org, Mar 29 2016

Summary: Re-enable dromaeo.jslibmodifyjquery.reference for windows once ref build is past M51 (was: dromaeo.jslibmodifyjquery.reference failure on win10 with windowsCurrentVersionNumber change)
Assuming the above CL sticks, the action item now is to re-enable the ref build.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/713021d91d801229b6ed7920a28c30c253f444e2

commit 713021d91d801229b6ed7920a28c30c253f444e2
Author: sullivan <sullivan@chromium.org>
Date: Wed Mar 30 14:16:53 2016

Fix dromaeo ref disable

BUG= 598705 
TBR=nednguyen@google.com
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1842563005

Cr-Commit-Position: refs/heads/master@{#383972}

[modify] https://crrev.com/713021d91d801229b6ed7920a28c30c253f444e2/tools/perf/benchmarks/dromaeo.py
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/713021d91d801229b6ed7920a28c30c253f444e2

commit 713021d91d801229b6ed7920a28c30c253f444e2
Author: sullivan <sullivan@chromium.org>
Date: Wed Mar 30 14:16:53 2016

Fix dromaeo ref disable

BUG= 598705 
TBR=nednguyen@google.com
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1842563005

Cr-Commit-Position: refs/heads/master@{#383972}

[modify] https://crrev.com/713021d91d801229b6ed7920a28c30c253f444e2/tools/perf/benchmarks/dromaeo.py

Comment 8 by dtu@chromium.org, Apr 14 2016

Labels: OS-Windows

Comment 9 by qyears...@chromium.org, May 4 2016

Labels: -Pri-1 Pri-2
Status: Assigned (was: Untriaged)

Comment 10 by eakuefner@chromium.org, Jul 18 2016

Labels: Performance-Sheriff-BotHealth

Comment 11 by benhenry@google.com, Dec 21 2016

Labels: -Performance-BotHealth

Comment 12 by martiniss@chromium.org, Aug 4 2017

Status: Archived (was: Assigned)
This benchmark has been deleted
►

Sign in to add a comment