New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 674593



Sign in to add a comment
link

Issue 598704: Remove |remote| and |readonly| members of MediaStreamTrack

Reported by mcasas@chromium.org, Mar 29 2016 Project Member

Issue description

Comment 1 by mcasas@chromium.org, Mar 29 2016

This issue is basically a to-do-later-post-it kind -- :)  
Also a good first bug for a new Chrome dev.

Comment 2 by jansson@chromium.org, Mar 29 2016

Status: Available (was: Unconfirmed)

Comment 3 by cbiesin...@chromium.org, Mar 29 2016

Components: -Blink Blink>Media

Comment 4 by taylor.h...@gmail.com, Apr 3 2016

I would like to take this. It looks interesting for me.

Comment 5 by mcasas@chromium.org, Apr 4 2016

Cc: guidou@chromium.org hta@chromium.org
@taylor.hoon: absolutely! Any schedule for it?
Adding guidou@ and hta@ in case they want to indicate
some potential timing for it.

Comment 6 by hta@chromium.org, Apr 4 2016

Owner: hta@chromium.org
Taylor, feel free to grab it if you want to start!

As usual, there are a few steps involved, since we can't break users' code:
- Add UMA counters for how much they're used
- File an intent-to-deprecate-and-remove, citing the numbers found
- Change the counters to deprecation warnings (which also count)
- Wait for a revision or two, or until usage is reasonably low
- Remove
Happy to see someone starting this!

Comment 7 by taylor.h...@gmail.com, Apr 6 2016

@hta, that's very interesting idea not to break users' code. But it's hard to follow the steps because I'm newbie in chromium community even though I've handled chromium browser on the embedded products for several years. Could you tell me in more detail? 

[Questions]
1. What is UMA counters?? And how can I change the counters to deprecation warnings??
2. Is it file name "intent-to-deprecate-and-remove"? And where should I put it in chromium directory?
3. I got it that removing |remote| and |readonly| members after waiting until usage is reasonably low. Then who decides "reasonably low"?? And how do we measure degree of use??

Sorry for too many questions at a time.

Comment 8 by hta@chromium.org, Apr 6 2016

1. UMA counters are generated from calls to the UseCounter class.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/frame/UseCounter.h&sq=package:chromium&type=cs&q=UseCounter&l=58

2. See this procedure:
http://www.chromium.org/blink#TOC-Launch-Process:-Deprecation

3. See above. People will tell you once you have numbers.

It's a relatively simple process, but it can be a bit tedious to execute, and does require getting signoffs from a number of people.

Comment 9 by taylor.h...@gmail.com, Apr 14 2016

@hta, I just upload a patch to add UMA counters in following URL. Please take a look.
https://codereview.chromium.org/1888023002

Comment 11 by hta@chromium.org, Apr 21 2016

The "readonly" attribute is present in the C++, but is not surfaced in the IDL. I think we can safely remove that part from the code.

Comment 12 by taylor.h...@gmail.com, Apr 24 2016

@hta, You're right.
I've removed the "readonly" attribute of MediaStreamTrack and related codes.
https://codereview.chromium.org/1915793002/

Comment 13 by bugdroid1@chromium.org, May 9 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7

commit d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7
Author: Taylor.Hoon <Taylor.Hoon@gmail.com>
Date: Mon May 09 18:29:26 2016

Remove a |readonly| member of MediaStreamTrack

Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 - removal was in the April 6 editors' draft.

The attribute was never exposed in our IDL files.

BUG= 598704 

Review-Url: https://codereview.chromium.org/1915793002
Cr-Commit-Position: refs/heads/master@{#392373}

[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/components/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/components/test_runner/mock_webrtc_peer_connection_handler.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/audio_track_recorder_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/canvas_capture_handler.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/media_stream_video_source_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/remote_media_stream_impl.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/media/webrtc_local_audio_track_unittest.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/content/renderer/pepper/pepper_media_stream_video_track_host.cc
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h
[modify] https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7/third_party/WebKit/public/platform/WebMediaStreamSource.h

Comment 14 by mlamouri@chromium.org, Aug 2 2016

Components: -Blink>Media

Comment 15 by mcasas@chromium.org, Aug 2 2016

Components: Blink>MediaStream

Comment 16 by lafo...@chromium.org, Sep 29 2016

Components: -Blink>Webrtc>GetUserMedia Blink>GetUserMedia

Comment 17 by foolip@chromium.org, Feb 16 2017

Blocking: 674593
Labels: Hotlist-Interop

Comment 18 by bugdroid1@chromium.org, Feb 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a72385a6addeb6194d3568beda3f352e07c97260

commit a72385a6addeb6194d3568beda3f352e07c97260
Author: peary2 <peary2@gmail.com>
Date: Fri Feb 24 16:52:59 2017

Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG= 598704 

Review-Url: https://codereview.chromium.org/2425703002
Cr-Commit-Position: refs/heads/master@{#452851}

[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/public/renderer/media_stream_utils.h
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/capturefromelement/canvas_capture_handler.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/capturefromelement/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/external_media_stream_audio_source.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/external_media_stream_audio_source.h
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/media_stream_audio_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/media_stream_video_source_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/remote_media_stream_impl.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/media_recorder/audio_track_recorder_unittest.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/pepper/pepper_media_stream_video_track_host.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/shell/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/content/shell/test_runner/mock_webrtc_peer_connection_handler.cc
[delete] https://crrev.com/7ad84acdb570f8879cab458545b75f603fa1e884/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt
[delete] https://crrev.com/7ad84acdb570f8879cab458545b75f603fa1e884/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h
[modify] https://crrev.com/a72385a6addeb6194d3568beda3f352e07c97260/third_party/WebKit/public/platform/WebMediaStreamSource.h

Comment 19 by bugdroid1@chromium.org, Feb 24 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/705b13eab5b3969e6f351cd23bb536ec204a78fc

commit 705b13eab5b3969e6f351cd23bb536ec204a78fc
Author: mathp <mathp@chromium.org>
Date: Fri Feb 24 17:45:38 2017

Revert of Remove |remote| and |readonly| members of MediaStreamTrack (patchset #10 id:200001 of https://codereview.chromium.org/2425703002/ )

Reason for revert:
Failure on webkit_tests:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/23714

external/wpt/mediacapture-streams/MediaStreamTrack-init.https.html

Original issue's description:
> Remove |remote| and |readonly| members of MediaStreamTrack.
>
> Spec reference:
> http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1
>
> removal was in the February 22, 2016'.
> [#321] Remove track attributes "remote" and "readonly" :
> https://github.com/w3c/mediacapture-main/pull/321
>
> Intent to Deprecate and Remove :
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI
>
> BUG= 598704 
>
> Review-Url: https://codereview.chromium.org/2425703002
> Cr-Commit-Position: refs/heads/master@{#452851}
> Committed: https://chromium.googlesource.com/chromium/src/+/a72385a6addeb6194d3568beda3f352e07c97260

TBR=jochen@chromium.org,bbudge@chromium.org,drott@chromium.org,esprehn@chromium.org,hongchan@chromium.org,hta@chromium.org,mcasas@chromium.org,miu@chromium.org,peter@chromium.org,scottmg@chromium.org,peary2@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 598704 

Review-Url: https://codereview.chromium.org/2710213005
Cr-Commit-Position: refs/heads/master@{#452862}

[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/public/renderer/media_stream_utils.h
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/capturefromelement/canvas_capture_handler.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/capturefromelement/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/external_media_stream_audio_source.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/external_media_stream_audio_source.h
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/media_stream_audio_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/media_stream_video_source_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/remote_media_stream_impl.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/media_recorder/audio_track_recorder_unittest.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/pepper/pepper_media_stream_video_track_host.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/shell/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/content/shell/test_runner/mock_webrtc_peer_connection_handler.cc
[add] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt
[add] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h
[modify] https://crrev.com/705b13eab5b3969e6f351cd23bb536ec204a78fc/third_party/WebKit/public/platform/WebMediaStreamSource.h

Comment 20 by guidou@chromium.org, Mar 6 2017

Status: Assigned (was: Available)

Comment 21 by foolip@chromium.org, Mar 9 2017

Cc: foolip@chromium.org

Comment 22 by bugdroid1@chromium.org, Mar 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672

commit 27c39dbef0b07b7cd62fb2476d0f0836115fe672
Author: peary2 <peary2@gmail.com>
Date: Tue Mar 14 06:43:39 2017

Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG= 598704 

Review-Url: https://codereview.chromium.org/2723433002
Cr-Commit-Position: refs/heads/master@{#456639}

[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/public/renderer/media_stream_utils.h
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/external_media_stream_audio_source.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/external_media_stream_audio_source.h
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/media_stream_audio_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/media_stream_video_source_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/remote_media_stream_impl.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media_capture_from_element/canvas_capture_handler.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/media_recorder/audio_track_recorder_unittest.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/pepper/pepper_media_stream_video_track_host.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/shell/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/content/shell/test_runner/mock_webrtc_peer_connection_handler.cc
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https.html
[delete] https://crrev.com/4d775162580774ccfaed86a8dcf2ac6564198d93/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt
[delete] https://crrev.com/4d775162580774ccfaed86a8dcf2ac6564198d93/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h
[modify] https://crrev.com/27c39dbef0b07b7cd62fb2476d0f0836115fe672/third_party/WebKit/public/platform/WebMediaStreamSource.h

Comment 23 by taylor.h...@gmail.com, Mar 20 2017

@hta, I don't know why the following message is made by bugdroid1@chromium.org.
"The following revision refers to this bug"

What am I supposed to do for it?

Comment 24 by phistuck@gmail.com, Mar 20 2017

#23 - it documents that some code changes that are relevant to this issue were made in Chromium by someone.
Since you starred the issue, you get it as an e-mail notification, like any other comment.
You do not need to do anything.

Comment 25 by bugdroid1@chromium.org, Mar 23 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad1bc7494fbd31e58569ae50362563e87306e5f5

commit ad1bc7494fbd31e58569ae50362563e87306e5f5
Author: guidou <guidou@chromium.org>
Date: Thu Mar 23 15:54:49 2017

Revert of Remove |remote| and |readonly| members of MediaStreamTrack. (patchset #5 id:80001 of https://codereview.chromium.org/2723433002/ )

Reason for revert:
Temporarily reverting this CL because it causes a perf regression. See  http://crbug.com/703605 .

Will reland once we understand why the regression occurred.

Original issue's description:
> Remove |remote| and |readonly| members of MediaStreamTrack.
>
> Spec reference:
> http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1
>
> removal was in the February 22, 2016'.
> [#321] Remove track attributes "remote" and "readonly" :
> https://github.com/w3c/mediacapture-main/pull/321
>
> Intent to Deprecate and Remove :
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI
>
> BUG= 598704 
>
> Review-Url: https://codereview.chromium.org/2723433002
> Cr-Commit-Position: refs/heads/master@{#456639}
> Committed: https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672

TBR=tkent@chromium.org,aelias@chromium.org,alexmos@chromium.org,bbudge@chromium.org,dpranke@chromium.org,drott@chromium.org,esprehn@chromium.org,haraken@chromium.org,hongchan@chromium.org,hta@chromium.org,mcasas@chromium.org,mkwst@chromium.org,peter@chromium.org,rdevlin.cronin@chromium.org,sergeyu@chromium.org,peary2@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 598704 

Review-Url: https://codereview.chromium.org/2767963002
Cr-Commit-Position: refs/heads/master@{#459096}

[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/public/renderer/media_stream_utils.h
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/external_media_stream_audio_source.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/external_media_stream_audio_source.h
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/media_stream_audio_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/media_stream_video_source_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/remote_media_stream_impl.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media_capture_from_element/canvas_capture_handler.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/media_recorder/audio_track_recorder_unittest.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/pepper/pepper_media_stream_video_track_host.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/shell/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/content/shell/test_runner/mock_webrtc_peer_connection_handler.cc
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https.html
[add] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt
[add] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h
[modify] https://crrev.com/ad1bc7494fbd31e58569ae50362563e87306e5f5/third_party/WebKit/public/platform/WebMediaStreamSource.h

Comment 26 by guidou@chromium.org, Mar 23 2017

Cc: -guidou@chromium.org pea...@gmail.com dalecur...@chromium.org
Owner: guidou@chromium.org
+dalecurtis, who authored the smoothness algorithm according to git.

peary2@'s CL was reverted because it caused a performance regression.

The original code applies a smoothness algorithm to remote video tracks. After removing the remote attribute, the algorithm was applied to local tracks as well, which caused the performance regression.

I think a solution is to keep the attributes in the content layer and just not expose them to Blink. Dale, what do you think?

Comment 27 by dalecur...@chromium.org, Mar 23 2017

Cc: qiangchen@chromium.org
No idea :) +qiangchen who worked on the MediaStream version. The metric increased from 15 to 59, which I guess is bad, but can't seem to find details on the calculation to confirm that. Why do we not want smooth remote tracks? Did this make the remote ones not-smooth?

Comment 28 by guidou@chromium.org, Mar 23 2017

We do want smooth remote tracks. 
The question would be if we also want smooth local ones, which is what caused the regression. :)

Comment 29 by qiangchen@chromium.org, Mar 23 2017

Yes, I noticed the issue when doing the smoothness project, the problem on smoothing local preview is that

1. Smoothing algorithm requires queuing several (for most cases, just 2) frames for selection.
2. We have only 3 capture buffers. 

So if the smoothing algorithm applies to local preview, it would hold 2 buffers, then allow only 1 buffer in commuting, then from time to time the camera is waiting for buffer, and un-smoothness occurs.

Comment 30 by guidou@chromium.org, Mar 28 2017

Based on #29, I think the best way to proceed with this bug is to remove the |remote| and |readonly| attributes from the Blink layer, but leave them in content so as to not affect the smoothness algorithm.
peary2: Do you want to amend your CL to reflect this?

Comment 31 by pea...@gmail.com, Mar 29 2017

yes, I will check it and upload patch with new CL. :)

Comment 32 by pea...@gmail.com, Mar 29 2017

mcasas@, miu@, guidou@,

IMHO, if |remote| is removed, the part that is causing the current problem is always false.
https://cs.chromium.org/chromium/src/content/renderer/media/webmediaplayer_ms_compositor.cc?rcl=8b97a74f58c8b45a85de5c5521a58a54a0935700&l=154

Can we delete this?

Comment 33 by phistuck@gmail.com, Mar 29 2017

#32 - probably not, I think you just need not to expose this in the IDL, the C++ object should still have that field.

Comment 34 by bugdroid1@chromium.org, Mar 30 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcc6621834abbd8f95c4d36e18d691ac495b0aa1

commit bcc6621834abbd8f95c4d36e18d691ac495b0aa1
Author: peary2 <peary2@gmail.com>
Date: Thu Mar 30 15:11:35 2017

Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG= 598704 

Review-Url: https://codereview.chromium.org/2788593002
Cr-Commit-Position: refs/heads/master@{#460756}

[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/content/public/renderer/media_stream_utils.h
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/content/shell/renderer/layout_test/blink_test_runner.cc
[delete] https://crrev.com/bbb00c3bef1374d4590acaa8ed59f5838103acc2/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt
[delete] https://crrev.com/bbb00c3bef1374d4590acaa8ed59f5838103acc2/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/bcc6621834abbd8f95c4d36e18d691ac495b0aa1/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl

Comment 35 by guidou@chromium.org, Apr 11 2017

Status: Fixed (was: Assigned)

Sign in to add a comment