New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598629 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

codesearch no longer supports search by URL

Project Member Reported by jochen@chromium.org, Mar 29 2016

Issue description

e.g. https://cs.chromium.org/ScriptWrappable.h now gives me a 404 error instead of searching for ScriptWrappable.h
 
Labels: Infra-Troopers
+troopers in case someone knows in MTV how to undo the latest push to production. 
Dave gave me direcitons to roll back some internal CL http://cl/118446279 which should be deployed soon (~1hr) automatically.

Dave also said:
> Rolling it back will make the new probers fail, but you can silence them.
So, troopers beware!
So the previous behavior probably relied on cs.chromium.org being a redirect to code.google.com/p/chromium/codesearch. Now cs.chromium.org directly points to the new instance.
If you try code.google.com/p/chromium/codesearch/ScriptWrappable.h it will also not work.
If you want to directly search, you should use URLs like this:
https://cs.chromium.org/#search/&q=ScriptWrappable.h
Cc: dsansome@chromium.org
Labels: Infra-Labs
Owner: pschmidt@chromium.org
So, this has to wait for labs, who are owners, to approve in order to land. Assigning to pschmidt@ as on-duty admin.

Expect ~6 more hours of downtime. Sorry for this.

Comment 6 by jochen@chromium.org, Mar 29 2016

nah, I shouldn't memorize URLs with hashes and queries in them. Internally, cs/foo also works.
i'm taking myself out of the loop here - I'm not even a trooper. FTR, i don't have an opinion whether this feature should or shouldn't stay, but I think rollback should proceed until at least a PSA is sent as to why breakage is necessary.
Cc: -tandrii@chromium.org
> nah, I shouldn't memorize URLs with hashes and queries in them.

Of course not, but you can create a custom search engine for it so you'd just have to type "ccs<space>foo" or whatever.

Just to clarify, where are these https://cs.chromium.org/ScriptWrappable.h URLs?  Are they in code or documentation somewhere, or just something you're used to typing in the address bar to quickly search?
I can't do custom search engines on Android for example.

I use such URLs extensively in codereview comments and bugs, as well as typing them in manually.
Ok, it might be possible to configure this if it works for internal codesearch. I guess the old config redirected to the url https://cs.chromium.org/#search/&q= if you had anything after cs.chromium.org/. Maybe something similar can be done to redirect cs.chromium.org/* to the search url.
In any case, Dave probably knows better what can be done here.
But since there is a workaround, would it make sense to make this a P1?
Of course I meant the old config redirected to https://code.google.com/p/chromium/codesearch/#search/&q=
Also, I am going to stop commenting here, as essentially its not my business anymore after I left the team :)
I'm not up to date with what the different priorities mean for infra, so if P1 is more appropriate here, that's fine by me
Any status updates in the last 5 hours? I'm also not trooper, but Dave will still be asleep for the next 6/7 hours.

tandrii@'s CL got approvals, but didn't land, so the rollback didn't happen. Why didn't it land? Are we waiting for something else?
Cc: tandrii@chromium.org
Cc: -tandrii@chromium.org pschmidt@chromium.org
Owner: tandrii@chromium.org
Ah, crossed streams. tandrii@, are you going to land the CL? Assigning to you because no one else can land it for you.

Comment 19 by d...@chromium.org, Mar 29 2016

Cc: tandrii@chromium.org
Owner: d...@chromium.org
tandrii - You can abandon your CL, I've patched it and. I've got a new one out: http://cr/118470659

I'll have to get traffic-team approval to submit this CL as well as it touches something outside of our OWNERS.

Comment 20 by d...@chromium.org, Mar 29 2016

CL passes. Now waiting on traffic to pick it up and approve.

Comment 21 by d...@chromium.org, Mar 29 2016

CL submitted. Looks like we just missed a push window, push should happen in about 30 minutes, so about an hour or so until the changes hit.

Comment 22 by d...@chromium.org, Mar 29 2016

 Issue 598780  has been merged into this issue.

Comment 23 by d...@chromium.org, Mar 29 2016

dns updates look to be live now.
Status: Verified (was: Assigned)
yay, thanks!
Components: Infra>Codesearch
Labels: -Infra-Codesearch
Components: Infra>Labs
Labels: -Infra-Labs

Sign in to add a comment