codesearch no longer supports search by URL |
|||||||||
Issue descriptione.g. https://cs.chromium.org/ScriptWrappable.h now gives me a 404 error instead of searching for ScriptWrappable.h
,
Mar 29 2016
Dave gave me direcitons to roll back some internal CL http://cl/118446279 which should be deployed soon (~1hr) automatically. Dave also said: > Rolling it back will make the new probers fail, but you can silence them. So, troopers beware!
,
Mar 29 2016
So the previous behavior probably relied on cs.chromium.org being a redirect to code.google.com/p/chromium/codesearch. Now cs.chromium.org directly points to the new instance. If you try code.google.com/p/chromium/codesearch/ScriptWrappable.h it will also not work.
,
Mar 29 2016
If you want to directly search, you should use URLs like this: https://cs.chromium.org/#search/&q=ScriptWrappable.h
,
Mar 29 2016
So, this has to wait for labs, who are owners, to approve in order to land. Assigning to pschmidt@ as on-duty admin. Expect ~6 more hours of downtime. Sorry for this.
,
Mar 29 2016
nah, I shouldn't memorize URLs with hashes and queries in them. Internally, cs/foo also works.
,
Mar 29 2016
i'm taking myself out of the loop here - I'm not even a trooper. FTR, i don't have an opinion whether this feature should or shouldn't stay, but I think rollback should proceed until at least a PSA is sent as to why breakage is necessary.
,
Mar 29 2016
,
Mar 29 2016
> nah, I shouldn't memorize URLs with hashes and queries in them. Of course not, but you can create a custom search engine for it so you'd just have to type "ccs<space>foo" or whatever. Just to clarify, where are these https://cs.chromium.org/ScriptWrappable.h URLs? Are they in code or documentation somewhere, or just something you're used to typing in the address bar to quickly search?
,
Mar 29 2016
I can't do custom search engines on Android for example. I use such URLs extensively in codereview comments and bugs, as well as typing them in manually.
,
Mar 29 2016
Ok, it might be possible to configure this if it works for internal codesearch. I guess the old config redirected to the url https://cs.chromium.org/#search/&q= if you had anything after cs.chromium.org/. Maybe something similar can be done to redirect cs.chromium.org/* to the search url. In any case, Dave probably knows better what can be done here. But since there is a workaround, would it make sense to make this a P1?
,
Mar 29 2016
Of course I meant the old config redirected to https://code.google.com/p/chromium/codesearch/#search/&q=
,
Mar 29 2016
Also, I am going to stop commenting here, as essentially its not my business anymore after I left the team :)
,
Mar 29 2016
I'm not up to date with what the different priorities mean for infra, so if P1 is more appropriate here, that's fine by me
,
Mar 29 2016
Just approved https://critique.corp.google.com/#review/118446279
,
Mar 29 2016
Any status updates in the last 5 hours? I'm also not trooper, but Dave will still be asleep for the next 6/7 hours. tandrii@'s CL got approvals, but didn't land, so the rollback didn't happen. Why didn't it land? Are we waiting for something else?
,
Mar 29 2016
,
Mar 29 2016
Ah, crossed streams. tandrii@, are you going to land the CL? Assigning to you because no one else can land it for you.
,
Mar 29 2016
tandrii - You can abandon your CL, I've patched it and. I've got a new one out: http://cr/118470659 I'll have to get traffic-team approval to submit this CL as well as it touches something outside of our OWNERS.
,
Mar 29 2016
CL passes. Now waiting on traffic to pick it up and approve.
,
Mar 29 2016
CL submitted. Looks like we just missed a push window, push should happen in about 30 minutes, so about an hour or so until the changes hit.
,
Mar 29 2016
Issue 598780 has been merged into this issue.
,
Mar 29 2016
dns updates look to be live now.
,
Mar 29 2016
yay, thanks!
,
Apr 27 2016
,
Apr 27 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tandrii@chromium.org
, Mar 29 2016