New issue
Advanced search Search tips

Issue 598624 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chrome fails on deqp/functional/gles3/shaderstatequery.html

Project Member Reported by qiankun....@intel.com, Mar 29 2016

Issue description

What steps will reproduce the problem?
(1) open chrome with command line: --enable-unsafe-es3-apis
(2) go to https://www.khronos.org/registry/webgl/sdk/tests/deqp/functional/gles3/shaderstatequery.html?webglVersion=2

What is the expected output?
All tests should pass.

What do you see instead?
shader.transform_feedback test fails.


This test is simple:
first it create a program: var shaderProg = gl.createProgram();
then it check default transform feedback buffer mode is INTERLEAVED_ATTRIBS:
this.check(glsStateQuery.verifyProgram(shaderProg, gl.TRANSFORM_FEEDBACK_BUFFER_MODE, gl.INTERLEAVED_ATTRIBS));

This fails at the following command buffer client code:
gpu/command_buffer/client/gles2_implementation_impl_autogen.h
GLES2Implementation::GetTexParameteriv() {
...
  result->SetNumResults(0);                                                                                                                                                                
  helper_->GetTexParameteriv(target, pname, GetResultShmId(),
                             GetResultShmOffset());
  WaitForCmd();
  result->CopyResult(params);
...
}

result->data do get the query data from GetTexParameteriv, but the number of results is set to 0 by "result->SetNumResults(0); ", so "result->CopyResult(params);" doesn't copy data to params.

Any reasons for setting number of the reuslts to 0?
 

Comment 1 by zmo@chromium.org, Mar 29 2016

The service side should update the number of results once it successfully gets the param.  If that's not the case, then we will need to fix it on the service side.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5247589044b9e2a51cf350577dc6df459958d7f4

commit 5247589044b9e2a51cf350577dc6df459958d7f4
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Thu Apr 07 01:30:54 2016

Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE

BUG= 598624 
TEST=deqp/functional/gles3/shaderstatequery.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1844113003

Cr-Commit-Position: refs/heads/master@{#385613}

[modify] https://crrev.com/5247589044b9e2a51cf350577dc6df459958d7f4/gpu/command_buffer/common/gles2_cmd_utils.cc

Status: Fixed (was: Untriaged)
This is fixed by above patch. Close it now.

Sign in to add a comment