New issue
Advanced search Search tips

Issue 598613 link

Starred by 1 user
Status: Verified
Owner:
fukino@chromium.org
Closed: Mar 2016
Cc:
hsiangc@chromium.org
rohi...@chromium.org
avkodipelli@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Video Player: The button to enable/disable subtitles doesn't have proper label for spoken feedback.

Project Member Reported by fukino@chromium.org, Mar 29 2016 
Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Store attached files in the same location in Downloads.
(2) Open upc-tobymanley.ogv using video player. (You can see the subtitles button in the toolbar)
(3) Check the aria-label of subtitles button.

What is the expected output?
aria-label should have proper string.

What do you see instead?
the aria-label is 'undefined'

Please use labels and text to provide additional information.
upc-tobymanley.ogv
2.2 MB Download
upc-tobymanley.vtt
763 bytes Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bad01e0d4f1de8fde606a30d07739917e4be1e05

commit bad01e0d4f1de8fde606a30d07739917e4be1e05
Author: fukino <fukino@chromium.org>
Date: Tue Mar 29 12:55:14 2016

Video Player: Set proper aria-label to the toggle button for subtitles.

This CL fixes following problems about aria-label of subtitles button.
- VIDEO_PLAYER_SUBTITLES_BUTTON_LABEL was used, but it actually is undefined.
- The button has two states since it is toggle button, but it couldn't be distinguished by the aria-label (and spoken feedback)

BUG= 598613 
TEST=manually enable/disable subtitles button and check the aria-label using inspector.

Review URL: https://codereview.chromium.org/1840983002

Cr-Commit-Position: refs/heads/master@{#383705}

[modify] https://crrev.com/bad01e0d4f1de8fde606a30d07739917e4be1e05/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/bad01e0d4f1de8fde606a30d07739917e4be1e05/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/bad01e0d4f1de8fde606a30d07739917e4be1e05/ui/file_manager/video_player/js/media_controls.js

Comment 2 by fukino@chromium.org, Mar 31 2016

Labels: OS-Chrome
Status: Fixed (was: Assigned)

Comment 3 by patricia@chromium.org, Apr 11 2016

Labels: VerifyIn-51

Comment 4 by patricia@chromium.org, May 23 2016

Labels: VerifyIn-52

Comment 5 by avkodipelli@chromium.org, May 26 2016

Cc: rohi...@chromium.org avkodipelli@chromium.org hsiangc@chromium.org
Status: Verified (was: Fixed)
Verified on 8172.45.0, 51.0.2704.64
►

Sign in to add a comment