New issue
Advanced search Search tips

Issue 598608 link

Starred by 0 users
Status: Fixed
Owner:
nhiroki@chromium.org
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----

Blocked on:
issue 543198


Sign in to add a comment

Ship ExtendableMessageEvent

Project Member Reported by nhiroki@chromium.org, Mar 29 2016

Comment 1 by nhiroki@chromium.org, Mar 29 2016

Blockedon: 543198

Comment 2 by nhiroki@chromium.org, Mar 30 2016

Labels: -Pri-3 M-51 Pri-2
Status: Started (was: Assigned)
The feature was implemented behind a flag ( issue 543198 ).
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/176c229259929d70aef76c3ef284b0d1fd0d7037

commit 176c229259929d70aef76c3ef284b0d1fd0d7037
Author: nhiroki <nhiroki@chromium.org>
Date: Wed Mar 30 09:35:19 2016

ServiceWorker: Enable ExtendableMessageEvent by default

Before this change, ServiceWorker.postMessage() resulted in MessageEvent fired
on ServiceWorkerGlobalScope. After this change, the function call resulted in
ExtendableMessaegeEvent fired on the global scope.

ExtendableMessageEvent has the same interface/behavior with MessageEvent other
than waitUntil(), so this change must not break any existing web pages.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-section
Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fUPpDcnOi64

BUG= 598608 

Review URL: https://codereview.chromium.org/1840303002

Cr-Commit-Position: refs/heads/master@{#383939}

[modify] https://crrev.com/176c229259929d70aef76c3ef284b0d1fd0d7037/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/176c229259929d70aef76c3ef284b0d1fd0d7037/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/176c229259929d70aef76c3ef284b0d1fd0d7037

commit 176c229259929d70aef76c3ef284b0d1fd0d7037
Author: nhiroki <nhiroki@chromium.org>
Date: Wed Mar 30 09:35:19 2016

ServiceWorker: Enable ExtendableMessageEvent by default

Before this change, ServiceWorker.postMessage() resulted in MessageEvent fired
on ServiceWorkerGlobalScope. After this change, the function call resulted in
ExtendableMessaegeEvent fired on the global scope.

ExtendableMessageEvent has the same interface/behavior with MessageEvent other
than waitUntil(), so this change must not break any existing web pages.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-section
Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fUPpDcnOi64

BUG= 598608 

Review URL: https://codereview.chromium.org/1840303002

Cr-Commit-Position: refs/heads/master@{#383939}

[modify] https://crrev.com/176c229259929d70aef76c3ef284b0d1fd0d7037/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/176c229259929d70aef76c3ef284b0d1fd0d7037/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 5 by nhiroki@chromium.org, Mar 30 2016

Status: Fixed (was: Started)
Updated the feature dashboard.
►

Sign in to add a comment