some links from builders to autofiled bugs are broken |
||||||||
Issue descriptionExample: https://uberchromegw.corp.google.com/i/chromeos/builders/strago-c-release-group/builds/346 The link that reads "provision: new report, FAIL: Unhandled AutoservRunError: scp -rq -o ControlPath=/tmp/_autotmp_SrZbDJssh-master/socket -o StrictHostKeyChecking=no -o UserKnownHostsFile=/tmp/tmpFB_umu -P 22 root" is broken, tries to link to non existant URL "chromeos4-row8-rack8-host1:" Why? Well, turns out it's because it is confusing the buildbot waterfall annotation engine. The underlying log line is: @@@STEP_LINK@provision: new report, FAIL: Unhandled AutoservRunError: scp -rq -o ControlPath=/tmp/_autotmp_SrZbDJssh-master/socket -o StrictHostKeyChecking=no -o UserKnownHostsFile=/tmp/tmpFB_umu -P 22 root@chromeos4-row8-rack8-host1:"/var/log/messages /var/log/update_engine" '/usr/local/autotest/results/hosts/chromeos4-row8-rack8-host1/52993466-provision/sysinfo'@https://code.google.com/p/chromium/issues/detail?id=598464@@@ That has an @ in it, which buildbot is interpereting as a separator between link text and URL, but which is actually supposed to be part of the link text itself. +shuqianz@: Is this more detailed logging because of your update_engine change? +dnj@: Would it be possible to get buildbot to use the rightmost @ as its text/url delimiter, rather than the first one?
,
Apr 4 2016
@dnj, can you chime in? Would it be possible to get buildbot to use the rightmost @ as its text/url delimiter, rather than the first one?
,
Apr 4 2016
RE #2, No, definitely not. That notation is used by every master and is baked into so much logic all over the place that updating it is not going to happen.
,
Apr 5 2016
Ok. Hacky workaround. Let's modify (in the autotest repo) run_suite.py:GetBuildbotStepLink(...) so that it filters all "@" characters our of the anchor text. Maybe replacing them with "_AT_" or something.
,
Apr 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/80256e20cd7a25bccf0f1e296ca735665cf55c4a commit 80256e20cd7a25bccf0f1e296ca735665cf55c4a Author: Ningning Xia <nxia@chromium.org> Date: Tue Apr 05 22:52:32 2016 replace @ annotator in GetBuildbotStepLink replace '@' to '-AT-' in GetBuildbotStepLink to avoid breaking step_link generated by buildbot output. BUG= chromium:598550 TEST=local test in python evn Change-Id: I08d2bcd1a522decfdebbc4e859111fcda867cdcd Reviewed-on: https://chromium-review.googlesource.com/337331 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Sosa <sosa@chromium.org> [modify] https://crrev.com/80256e20cd7a25bccf0f1e296ca735665cf55c4a/site_utils/run_suite.py
,
Apr 6 2016
,
Apr 11 2016
,
Apr 27 2016
,
May 23 2016
Bulk verified |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by shuqianz@chromium.org
, Mar 29 2016