New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598549 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Sign in to add a comment

Add a layout test for issue 597127

Project Member Reported by noel@chromium.org, Mar 29 2016

Issue description

We should add a layout test for  issue 597127  to test progressive YUV decoding (on mobile where a <meta> tag is needed to enable --force-GPU-rasterization much like the proposal cin https://codereview.chromium.org/561363002).

 
Blocking: 598670

Comment 2 by noel@chromium.org, Mar 30 2016

Blocking: 598949

Comment 3 by noel@chromium.org, Mar 30 2016

Cc: xidac...@chromium.org msarett@chromium.org
Owner: noel@chromium.org
Status: Started (was: Untriaged)
Per https://bugs.chromium.org/p/chromium/issues/detail?id=597127#c28 some images that reproduced  bug 597127  would be useful for our testing.

Comment 4 by noel@chromium.org, Mar 31 2016

I provided red / green / blue square images from Blink to the reporter of  issue 597127 , and asked that they use their system to munge them into new images that exhibit the bug, and send them back to me.

Comment 5 by noel@chromium.org, Mar 31 2016

Cc: scroggo@chromium.org

Comment 6 by noel@chromium.org, Apr 1 2016

The reported used ImageMagik to create the test images, and they look fine to me.
  
Uploaded https://codereview.chromium.org/1845223005

Comment 7 by noel@chromium.org, Apr 4 2016

Blocking: 600087
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca359146de5ca000b3e6681b91a468435b4f4b7

commit dca359146de5ca000b3e6681b91a468435b4f4b7
Author: noel <noel@chromium.org>
Date: Mon Apr 04 09:55:36 2016

Add Progressive JPEG YUV decoding layout tests

See also  issue 597127 . Use a <meta> viewport tag to force
GPU rasterization on the Android bots where supported and
add test cases for images and for the <canvas> element:

  fast/images/jpeg-yuv-progressive-image.html
  fast/images/jpeg-yuv-progressive-canvas.html

Add new Progressive JPEG image resources: they were built
using the ImageMagik

  % convert -size <size> plasma:fractal -paint

command. Details of the JPEG image encodings are:

ycbcr-progressive-000.jpg

Progressive DCT, Huffman coding
Bits Per Sample	8
Color Components	3
Image Size	200 × 200
Y Cb Cr Sub Sampling	YCbCr 4:4:4 (1 1)

ycbcr-progressive-001.jpg

Progressive DCT, Huffman coding
Bits Per Sample	8
Color Components	3
Image Size	250 × 250
Y Cb Cr Sub Sampling	YCbCr 4:4:4 (1 1)

ycbcr-progressive-002.jpg

Progressive DCT, Huffman coding
Bits Per Sample	8
Color Components	3
Image Size	300 × 300
Y Cb Cr Sub Sampling	YCbCr 4:2:0 (2 2)

ycbcr-progressive-003.jpg

Progressive DCT, Huffman coding
Bits Per Sample	8
Color Components	3
Image Size	350 × 350
Y Cb Cr Sub Sampling	YCbCr 4:2:0 (2 2)

Note: the progressive images with YUV 4:2:0 encoding both
cause the bug reported in  issue 597127 .

The new tests added in this CL provide some test coverage
for  issue 597127  (run with --force-gpu-rasterization) but
more work is needed to automate that on the bots, such as
with a virtual test suite for this flag (it has none).

TBR=scroggo@chromium.org
BUG= 598549 

Review URL: https://codereview.chromium.org/1845223005

Cr-Commit-Position: refs/heads/master@{#384874}

[modify] https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7/third_party/WebKit/LayoutTests/fast/images/jpeg-yuv-progressive-canvas.html
[add] https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7/third_party/WebKit/LayoutTests/fast/images/jpeg-yuv-progressive-image.html
[add] https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-progressive-000.jpg
[add] https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-progressive-001.jpg
[add] https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-progressive-002.jpg
[add] https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7/third_party/WebKit/LayoutTests/fast/images/resources/ycbcr-progressive-003.jpg

Comment 9 by noel@chromium.org, Apr 4 2016

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd

commit beb4621c3e99a75a6df76b2b2e87ad37b4c56edd
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Apr 04 11:35:11 2016

Auto-rebaseline for r384874

https://chromium.googlesource.com/chromium/src/+/dca359146

BUG= 598549 
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/1855183003 .

Cr-Commit-Position: refs/heads/master@{#384882}

[modify] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/fast/images/jpeg-yuv-progressive-canvas-expected.png
[add] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/fast/images/jpeg-yuv-progressive-canvas-expected.txt
[add] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/fast/images/jpeg-yuv-progressive-image-expected.png
[add] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/fast/images/jpeg-yuv-progressive-image-expected.txt
[add] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/jpeg-yuv-progressive-image-expected.png
[add] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/jpeg-yuv-progressive-image-expected.png
[add] https://crrev.com/beb4621c3e99a75a6df76b2b2e87ad37b4c56edd/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/jpeg-yuv-progressive-image-expected.png

Sign in to add a comment