New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598541 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary Highlight is seen on "ALLOW" button on Infobars

Project Member Reported by mm00333...@techmahindra.com, Mar 29 2016

Issue description

Version:  51.0.2693.2
OS: Ubuntu 12.04,14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome -> Go to any Page(Ex:Chrome://Apps)
(2)Now Press F12 to open Dev tools -> press F1 to open settings page-> Click on "Workspace" -> Now click on "Add Folder"
(3)Add any folder -> Now observe "ALLOW" button on permission bubble

Expected: No  Highlight should be seen on "ALLOW" button
Actual: Unnecessary Highlight is seen on "ALLOW" button

Note:If it is an intended behavior please change font color of "ALLOW" button to dark

This is Regression Issue broken in M-51
Manual good and Bad Builds:
Good Build: 51.0.2692.0
Bad Build:  51.0.2693.2

Below is the Tool Bisect Info:

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/6a2b2b5dafce11505958fbb945088347540fb9f7..71dbc98da81b7d8a758a674b1971672bf1573556

Suspecting https://codereview.chromium.org/1831673002 from changelog

@estade: Please confirm whether the behavior is intended or not



 
Actual_Highlight.ogv
1.5 MB Download
Actual_Highlight.png
168 KB View Download
Expected_Button.ogv
1.5 MB Download
Expected_Button.png
168 KB View Download
Able to reproduce the issue on Linux Ubuntu 14.04 using chrome version 51.0.2693.2.Issue is not seen on Mac 10.11.3

Comment 2 by est...@chromium.org, Mar 29 2016

Labels: -OS-Windows -Pri-1 Pri-2
only affects linux. I agree the coloration is not ideal here, mainly because the text is hard to read on it.

Comment 3 by est...@chromium.org, Mar 30 2016

Cc: rdevlin....@chromium.org
Labels: -Pri-2 Pri-1
here's another issue Devlin uncovered.
Selection_317.png
23.2 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1552cd224ed227b7f2051b2756a9e13dc5a830ee

commit 1552cd224ed227b7f2051b2756a9e13dc5a830ee
Author: estade <estade@chromium.org>
Date: Thu Mar 31 01:03:16 2016

Fix text coloration for GTK-themed MdTextButtons.

BUG= 598541 

Review URL: https://codereview.chromium.org/1844193002

Cr-Commit-Position: refs/heads/master@{#384168}

[modify] https://crrev.com/1552cd224ed227b7f2051b2756a9e13dc5a830ee/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

Labels: Proj-MaterialDesign-NativeUI
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e11d95dbbbf692ac14617db7572aa0f87029f03

commit 1e11d95dbbbf692ac14617db7572aa0f87029f03
Author: estade <estade@chromium.org>
Date: Fri Apr 01 19:37:33 2016

Fix MdTextButton colors in incognito windows.

BUG= 598541 

Review URL: https://codereview.chromium.org/1844003003

Cr-Commit-Position: refs/heads/master@{#384662}

[modify] https://crrev.com/1e11d95dbbbf692ac14617db7572aa0f87029f03/ui/native_theme/native_theme_dark_aura.cc

Status: Fixed (was: Assigned)

Sign in to add a comment