replace paper-material with div styled via paper-material-shared-styles |
||||||||||||||||||
Issue descriptionin accordance with https://docs.google.com/spreadsheets/d/1m0SleaDfRTPzDvlnInip9x4FXT6O98M2W8jwZyHmNp8/edit#gid=1938185096 we should remove <paper-material> usage from WebUI, including settings-section. it's an unnecessary custom element that can be replaced with a styled <div> to gain performance.
,
Apr 15 2016
,
May 4 2016
#1: yep but you still have it thanks to <paper-button>. https://github.com/PolymerElements/paper-button/pull/114
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2477b855edc8e00fbeb180b0e6011b83bbaf94a5 commit 2477b855edc8e00fbeb180b0e6011b83bbaf94a5 Author: michaelpg <michaelpg@chromium.org> Date: Thu May 05 23:18:09 2016 MD Settings: replace paper-material with paper-material-shared-styles The cards don't need to be custom elements. BUG= 598516 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1949533003 Cr-Commit-Position: refs/heads/master@{#391942} [delete] https://crrev.com/538ae9a2b661a9b40ab259d0f34b41ddb668ec75/chrome/browser/resources/settings/settings_page/settings_section.css [modify] https://crrev.com/2477b855edc8e00fbeb180b0e6011b83bbaf94a5/chrome/browser/resources/settings/settings_page/settings_section.html [modify] https://crrev.com/2477b855edc8e00fbeb180b0e6011b83bbaf94a5/chrome/browser/resources/settings/settings_resources.grd
,
May 24 2016
,
Jul 21 2016
,
Dec 6 2016
un-assigning
,
Jan 6 2017
,
May 18 2017
There are two remaining occurrences of paper-material (only one of them in MD Settings), see https://cs.chromium.org/search/?q=%22%3Cpaper-material%22+-appengine+-catapult+-luci-go&type=cs.
,
May 18 2017
I think <paper-material> can generally be changed with something like <div> + @apply(--shadow-elevation-2dp);
,
May 18 2017
,
May 19 2017
It seems that our usage of paper-material is broken in Vulcanized mode, unfortunately. Applying elevation=1 attribute at [1] is supposed to trigger a box-shadow from paper-material-shared-styles at [2], but in Vulcanized mode, I don't see it being applied. Perhaps the problem is that at [2] we use two separate <style> tags and somehow the 1st one is being dropped from polymer-css-build? [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device_page/display_layout.html?l=64 [2] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-material/paper-material.html?l=31,32
,
May 19 2017
,
May 19 2017
Did some further investigation. The vulcanized output is correct if I merge the two <style> includes at [1]. I believe this is a bug either in polymer-css-build, or in vulcanize itself. Will try to come up with a minimal repro and forward accordingly. Having said that, we should audit all our elements (both Chrome and third_party/polymer) to see if there are more places where multiple <style> tags per-element are being used. [1] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-material/paper-material.html?l=31,32
,
May 20 2017
FYI, filed bug with minimal repro at https://github.com/Polymer/polymer-css-build/issues/13. It does not block the removal of paper-material though.
,
May 20 2017
CL https://codereview.chromium.org/2885363006 for removing the usage at https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device_page/display_layout.html?l=64 is in review, just FYI.
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43417886667f8c68d74056371a61845cdaddd4a9 commit 43417886667f8c68d74056371a61845cdaddd4a9 Author: dpapad <dpapad@chromium.org> Date: Tue May 23 01:51:57 2017 MD Settings: Remove usage of paper-material. Instead replace it with an appropriately styled div. As a fortunate side-effect, this CL makes the box-shadow effect work in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13 BUG= 598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885363006 Cr-Commit-Position: refs/heads/master@{#473781} [modify] https://crrev.com/43417886667f8c68d74056371a61845cdaddd4a9/chrome/browser/resources/settings/device_page/display_layout.html
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b67b20f22a94c5b47e1c1c18db39a7296f8b399 commit 0b67b20f22a94c5b47e1c1c18db39a7296f8b399 Author: Dan Beam <dbeam@chromium.org> Date: Fri Jun 02 03:40:05 2017 Polymer: update a couple node-based tools * polymer-css-build: 0.0.9 -> 0.1.2 * vulcanize: 1.15.2 -> 1.15.4 Updating vulcanize allows us to trim our local patch. I also renamed patch_vulcanize.diff to chromium_vulcanize.patch as "chromium.patch" seems like a more common file name for applying Chromium-specific changes to third_party code. BUG= 598516 R=dpapad@chromium.org Change-Id: Ib0b4234a1e497bad7ea930c1f14b841e723a60bc Reviewed-on: https://chromium-review.googlesource.com/521883 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#476552} [add] https://crrev.com/0b67b20f22a94c5b47e1c1c18db39a7296f8b399/third_party/node/chromium_vulcanize.patch [modify] https://crrev.com/0b67b20f22a94c5b47e1c1c18db39a7296f8b399/third_party/node/node_modules.tar.gz.sha1 [modify] https://crrev.com/0b67b20f22a94c5b47e1c1c18db39a7296f8b399/third_party/node/package.json [delete] https://crrev.com/38610ad5a07527b89be3116610c2c3bff822d5e8/third_party/node/patch_vulcanize.diff [modify] https://crrev.com/0b67b20f22a94c5b47e1c1c18db39a7296f8b399/third_party/node/update_npm_deps
,
Jun 3 2017
FYI, CL to remove remaining usage of paper-material is at https://codereview.chromium.org/2924443002.
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4689b08719e552c8f361a35ce0c3a31935606d7 commit c4689b08719e552c8f361a35ce0c3a31935606d7 Author: dpapad <dpapad@chromium.org> Date: Tue Jun 06 03:26:10 2017 WebUI: Remove last usage of <paper-material>. This CL also removes the last usage of paper-material-shared-styles, because it is not really needed. Instead its usage can be replaced with the already existing paper-styles/shadow.html BUG= 598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2924443002 Cr-Commit-Position: refs/heads/master@{#477177} [modify] https://crrev.com/c4689b08719e552c8f361a35ce0c3a31935606d7/chrome/browser/resources/chromeos/login/controller-pairing-screen.html [modify] https://crrev.com/c4689b08719e552c8f361a35ce0c3a31935606d7/chrome/browser/resources/settings/device_page/display_layout.html
,
Jun 7 2017
FYI, I have a CL attempting to remove <paper-material> from being shipped with Chrome at https://codereview.chromium.org/2925993002, since it seems that it is not being used anywhere anymore.
,
Jun 7 2017
,
Jun 7 2017
\o/
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93bd3b4b2f3930c82b0287b2f475594a8947f898 commit 93bd3b4b2f3930c82b0287b2f475594a8947f898 Author: dpapad <dpapad@chromium.org> Date: Wed Jun 07 23:22:42 2017 Polymer: Remove <paper-material> from polymer_resources.grdp file. BUG= 598516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2925993002 Cr-Commit-Position: refs/heads/master@{#477770} [modify] https://crrev.com/93bd3b4b2f3930c82b0287b2f475594a8947f898/third_party/polymer/v1_0/reproduce.sh [modify] https://crrev.com/93bd3b4b2f3930c82b0287b2f475594a8947f898/ui/webui/resources/polymer_resources.grdp
,
Jun 8 2017
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by dbeam@chromium.org
, Mar 29 2016