New issue
Advanced search Search tips

Issue 598511 link

Starred by 1 user
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Mar 2016
Cc:
noel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

webkit-patch pretty-diff doesn't work under cygwin

Project Member Reported by alancutter@chromium.org, Mar 29 2016 
When running "webkit-patch pretty-diff" in cygwin the browser opens up with an invalid local file path.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09bdf7f4b023dd3c71ab9012a4abead59c6d4472

commit 09bdf7f4b023dd3c71ab9012a4abead59c6d4472
Author: alancutter <alancutter@chromium.org>
Date: Tue Mar 29 05:29:14 2016

Make "webkit-patch pretty-diff" work under cygwin

Cygwin file paths are not compatible with regular Windows applications.
This patch uses cygstart to translate and open the appropriate local
HTML file path in the system browser.

This logic has not been upstreamed into a Port class due to the
security risk of exposing cygstart.

BUG= 598511 

Review URL: https://codereview.chromium.org/1837103002

Cr-Commit-Position: refs/heads/master@{#383670}

[modify] https://crrev.com/09bdf7f4b023dd3c71ab9012a4abead59c6d4472/third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py

Comment 2 by alancutter@chromium.org, Mar 30 2016

Status: Fixed (was: Assigned)

Comment 3 by tkent@chromium.org, Apr 11 2016

Components: -Blink>Tools Blink>ToolsTest

Comment 4 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest Blink>Infra
Blink>ToolsTest renamed to Blink>Infra
►

Sign in to add a comment