New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 598499 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Apr 2016
Cc:
█ nek...@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Items under the Zoom and Edit submenus are not accessible

Project Member Reported by nek...@chromium.org, Mar 29 2016 
Chrome 51.0.2692.0.
On the Mac and while VoiceOver is on:
1. Find the toolbar using ctrl-option-left/right.
2. Interact with it and find the Chrome menu button.
3. Press ctrl-option-space to open the menu.
4. Navigate up and down using ctrl-option-up/down and observe that for the Zoom and Edit menus you only hear "Zoom interactive" and "Edit interactive":
A) The items in these submenus, e.g. "Zoom in", "Cut" and "Paste" are not announced.
B) There is nothing "interactive" about these menus.

Comment 1 by ellyjo...@chromium.org, Apr 7 2016

Status: Assigned (was: Available)
I reproduced this locally. The issues with these menus are in MainMenu.xib.

Comment 2 by ellyjo...@chromium.org, Apr 7 2016 

Oh, to edit the XIB files, I need to use Xcode 5.1 and OS X 10.9.5, according to http://dev.chromium.org/developers/design-documents/mac-xib-files, so I'll have to hold off on fixing this for now.

Comment 3 by ellyjo...@chromium.org, Apr 7 2016 

Wait, I just chatted with lpalmaro@ and figured out how to use these:

1) ctrl-option-down through the menu to Zoom
2) ctrl-option-shift-down to Interact with it
3) ctrl-option-left/right to traverse the buttons

That said, the labels on them are all wrong: "zoom out" is called "Remove", and "zoom in" is called "Add". Oops.

Comment 4 by ellyjo...@chromium.org, Apr 15 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a29ffe1fea6e29b204665c52caa3e63d052ecd1c

commit a29ffe1fea6e29b204665c52caa3e63d052ecd1c
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Apr 15 22:35:35 2016

AppMenu: add accessibility descriptions to zoom buttons

Right now these inherit their descriptions from NSAddTemplate and
NSRemoveTemplate, which have generic "add" / "remove" alt text. This change
adds accessibility descriptions to the buttons to give more context to screen
reader users.

BUG= 598499 

Review URL: https://codereview.chromium.org/1884383003

Cr-Commit-Position: refs/heads/master@{#387731}

[modify] https://crrev.com/a29ffe1fea6e29b204665c52caa3e63d052ecd1c/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

Comment 6 by ellyjo...@chromium.org, Apr 18 2016

Status: Fixed (was: Started)
This is fixed in canary now.
►

Sign in to add a comment