RenderProcessHostImpl: Consider using base::DoNothing instead of DisableAecDumpOnFileThread() |
||
Issue descriptionBetter use base::DoNothing() [1] in base::Bind()s instead of DisableAecDumpOnFileThread() [2] since the former conveys the meaning better. [1] https://code.google.com/p/chromium/codesearch#chromium/src/base/bind_helpers.h&sq=package:chromium&type=cs&q=base::Donothing&l=622 [1] https://chromium.googlesource.com/chromium/src/+blame/master/content/browser/renderer_host/render_process_host_impl.cc#301
,
Mar 30 2016
I will fix it.
,
Mar 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d1d8643007866c852a5482653c9dfe254e15f2a commit 1d1d8643007866c852a5482653c9dfe254e15f2a Author: maksim.sisov <maksim.sisov@intel.com> Date: Thu Mar 31 04:56:51 2016 Using base::DoNothing() in base::Bind()s instead of DisableAecDumpOnFileThread() for better readability. BUG= 598498 Review URL: https://codereview.chromium.org/1841933003 Cr-Commit-Position: refs/heads/master@{#384196} [modify] https://crrev.com/1d1d8643007866c852a5482653c9dfe254e15f2a/content/browser/renderer_host/render_process_host_impl.cc
,
Mar 31 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by grunell@chromium.org
, Mar 30 2016Status: Assigned (was: Available)