shill: wake-on-WiFi D-Bus API methods succeed even if packet feature is disabled
Reported by
samueltan@chromium.org,
Mar 29 2016
|
|||
Issue descriptionshill's D-Bus API methods handling the adding and removing of whitelisted IP addresses (i.e. WakeOnWiFi::AddWakeOnPacketConnection, WakeOnWiFi::RemoveWakeOnPacketConnection, WakeOnWiFi::RemoveAllWakeOnPacketConnections) will update |wake_on_packet_connections_| and return success, even if the "packet" feature is disabled. This is misleading to the remote service that called any of these methods, since shill will not actually program the NIC to wake on any of the IP addresses registered in |wake_on_packet_connections_| during suspend. shill should instead explicitly return failure on these D-Bus calls if the packet feature is not enabled. This can be done by checking the return value of WakeOnWiFi::WakeOnWiFiPacketEnabledAndSupported(), instead of checking |wake_on_wifi_triggers_supported_| alone.
,
Mar 29 2016
crbug.com/548298 is closely related to this bug. Chrome unnecessarily calls shill's wake-on-WiFi D-Bus API methods even when the packet feature is not enabled, and shill silently accepts these calls.
,
Dec 27 2017
,
Aug 1
|
|||
►
Sign in to add a comment |
|||
Comment 1 by samueltan@chromium.org
, Mar 29 2016