New issue
Advanced search Search tips

Issue 598489 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

<td> parent background images are drawn incorrectly in colspan/rowspan

Project Member Reported by atotic@chromium.org, Mar 29 2016

Issue description

Version: 51?
OS: All

This bug will be valid once https://codereview.chromium.org/1819073004/ lands. Here now so I can refer to it inside a source-code comment.

What steps will reproduce the problem?
(1)Load the attached file

What is the expected output?
- what Firefox does

What do you see instead?
- Misaligned <tr> backgrounds.

There are 2 bugs here. All can be fixed by fiddling with TableCellPainter::paintParentBackgroundsBehindCell

When background-image-size is 100%, and cell has (rowspan || colspan) > 1, image in the background cell will be too wide/tall. The reason is that we are using union of cell rect and background rect to draw backgrond image, instead of using background rect to size the background image, and cell rect for drawing.

For this bug to be fixed, we need to extend BoxPainter functionality, so that paintFillLayer can use separate rectangles for image positioning and image painting.

The other bug is that background image origin is incorrect in vertical painting modes for rowspan/colspan cells. background origin should be the topleft corner of parent element (colgroup, etc), not the topleft corner of union of cell rect and background rect.

Workaround: specify image background width in units that are not a percentage.
Both bugs happen in the attached file.
 
xianzhu.html
694 bytes View Download

Comment 1 by atotic@chromium.org, Mar 29 2016

Components: Blink>Layout>Table

Comment 2 by e...@chromium.org, Mar 29 2016

Owner: atotic@chromium.org
Status: Available (was: Untriaged)

Comment 3 by atotic@chromium.org, Aug 16 2016

If you decide to work on this bug, I've tried to implement a fix, see initial checkin at:
https://codereview.chromium.org/1676933004/

I've failed to pass the code review, but it might be a good start. Ping me if you need to know more.

I am removing the "GoodFirstBug" label :)

Comment 4 by atotic@chromium.org, Aug 16 2016

Owner: ----

Comment 5 by e...@chromium.org, Aug 1 2017

This appears to be working as expected now. Could you please confirm?
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 1

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)

Sign in to add a comment