output_perf_value() appears to overwrite previous values
Reported by
bfreed@chromium.org,
Mar 29 2016
|
||||||||
Issue descriptionnetwork_WiFi_BluetoothStreamPerf.py calls output_perf_value() 16 times, and only the data from the last call ends up in the results-chart.json. Previous values are overwritten. So I appear to be calling output_perf_value() but the documentation at http://www.chromium.org/chromium-os/testing/perf-data has not (obviously) changed. Sample output is: { "ch006_mode11B_none": { "udp_rx_BT_disconnected_again": { "units": "Mbps", "type": "list_of_scalar_values", "values": [ 6.55, 6.5, 6.5 ], "improvement_direction": "up" } }, "ch006_mode11B_none_drop": { "udp_rx_BT_disconnected_again_drop": { "units": "percent_drop", "type": "scalar", "value": 0.0, "improvement_direction": "down" } } } but I have lost the previously written results for {tcp|udp}_{t|r}x_{BT_disconnected|BT_connected_but_not_streaming|BT_streaming_audiofile|BT_disconnected_again}
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/df2730bfeb42699fa9d88de7dd982db51502cd25 commit df2730bfeb42699fa9d88de7dd982db51502cd25 Author: Keith Haddow <haddowk@chromium.org> Date: Tue Mar 29 04:31:18 2016 Fix issue where different tests of the same graph overwrite each other. TEST=hand ran unittests BUG= chromium:598488 Change-Id: I1c641a9e487de67ba23284a804a7d30822272426 Reviewed-on: https://chromium-review.googlesource.com/335468 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Dan Shi <dshi@chromium.org> [modify] https://crrev.com/df2730bfeb42699fa9d88de7dd982db51502cd25/client/common_lib/test_unittest.py [modify] https://crrev.com/df2730bfeb42699fa9d88de7dd982db51502cd25/client/common_lib/test.py
,
Mar 31 2016
I see data flowing into chromeperf - can you confirm this is what you were expecting ? https://chromeperf.appspot.com/report?sid=7a179e2b5c1c88e1113f69b01a80629d1e94ea9ad3da70cf1bae0ccce9615823
,
Mar 31 2016
This looks great, Keith. Thanks!
,
Mar 31 2016
,
Mar 31 2016
,
Mar 31 2016
[Automated comment] Request affecting a post-stable build (M49), manual review required.
,
Mar 31 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Apr 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c4601a0e2eb542918c6bc473da2a89a5e909a871 commit c4601a0e2eb542918c6bc473da2a89a5e909a871 Author: Keith Haddow <haddowk@chromium.org> Date: Tue Mar 29 04:31:18 2016 Fix issue where different tests of the same graph overwrite each other. TEST=hand ran unittests BUG= chromium:598488 Change-Id: I1c641a9e487de67ba23284a804a7d30822272426 Previous-Reviewed-on: https://chromium-review.googlesource.com/335468 (cherry picked from commit 5703acd63985d5983a5843d65ab6a753e54305dd) Reviewed-on: https://chromium-review.googlesource.com/336714 Reviewed-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/c4601a0e2eb542918c6bc473da2a89a5e909a871/client/common_lib/test_unittest.py [modify] https://crrev.com/c4601a0e2eb542918c6bc473da2a89a5e909a871/client/common_lib/test.py
,
Apr 5 2016
This doesn't seem important enough to merge into M49 this late into its lifetime. We are just a couple weeks away from M50. Can this wait? Please remove the merge request if you agree.
,
Apr 6 2016
I'll make an executive decision that we don't need this for 49, but you can ping me if you disagree.
,
Apr 29 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 29 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 29 2016