New issue
Advanced search Search tips

Issue 598456 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 595076



Sign in to add a comment

Histogram VideoDecodeAccelerator errors for GpuVideoDecoder.

Project Member Reported by dalecur...@chromium.org, Mar 28 2016

Issue description

Important in helping to track down the video-only decode errors in issue 595076.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64739369777e41880b12fbbeb6ad2ddd31f40053

commit 64739369777e41880b12fbbeb6ad2ddd31f40053
Author: dalecurtis <dalecurtis@chromium.org>
Date: Tue Mar 29 00:55:36 2016

Add histogram entry for GpuVideoDecoder errors.

Not sure how we missed having these logged... Adding this also required
fixing the UMA enum name to match the media/ PRESUBMIT style: must end
with _MAX and that value must be equal to the last enum value.

BUG= 598456 
TEST=errors show up in chrome://histograms/Media.GpuVideoDecoderError.

Review URL: https://codereview.chromium.org/1839833002

Cr-Commit-Position: refs/heads/master@{#383640}

[modify] https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053/content/renderer/media/rtc_video_decoder.cc
[modify] https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053/content/renderer/pepper/pepper_video_decoder_host.cc
[modify] https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053/content/renderer/pepper/ppb_video_decoder_impl.cc
[modify] https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053/media/video/video_decode_accelerator.h
[modify] https://crrev.com/64739369777e41880b12fbbeb6ad2ddd31f40053/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment