New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598451 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Edit history background colors

Project Member Reported by bettes@chromium.org, Mar 28 2016

Issue description

Update colors to align with downloads page

title-bar: #3F5566
background: ##ECEFF1


 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by bettes@chromium.org, Mar 28 2016

Screen Shot 2016-03-28 at 3.37.05 PM.png
154 KB View Download

Comment 4 by dbeam@chromium.org, Mar 28 2016

Cc: tsergeant@chromium.org calamity@chromium.org dbeam@chromium.org
Owner: calamity@chromium.org
Status: Available (was: Untriaged)
Hmm. The title bar color isn't what's on MD downloads at the moment? It's currently #34495e. Should both be changed to #3F5566 or just have both as #34495e ?
mdh_mdd_color_compare.png
78.6 KB View Download

Comment 6 by bettes@chromium.org, Mar 30 2016

Apologies. Both at #34495E

Comment 7 by bettes@chromium.org, Apr 18 2016

Owner: dbeam@chromium.org

Comment 8 by dbeam@chromium.org, Apr 19 2016

Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ed64b085f382514999e686b62cb08d10968d18

commit f0ed64b085f382514999e686b62cb08d10968d18
Author: dbeam <dbeam@chromium.org>
Date: Thu Apr 21 17:22:10 2016

MD Downloads/History: unify page and toolbar background colors

R=dschuyler@chromium.org
BUG= 598451 

Review URL: https://codereview.chromium.org/1899043003

Cr-Commit-Position: refs/heads/master@{#388801}

[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/chrome/browser/resources/md_downloads/downloads.html
[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/chrome/browser/resources/md_downloads/manager.html
[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/chrome/browser/resources/md_downloads/toolbar.css
[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/chrome/browser/resources/md_history/history_toolbar.html
[add] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/ui/webui/resources/css/md_colors.css
[modify] https://crrev.com/f0ed64b085f382514999e686b62cb08d10968d18/ui/webui/resources/webui_resources.grd

Comment 10 by dbeam@chromium.org, Apr 21 2016

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06c83ed5cdabaa90e5473b157ac1f3e04235da1

commit b06c83ed5cdabaa90e5473b157ac1f3e04235da1
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Apr 22 03:51:11 2016

MD History: Fix toolbar selected color

Lowers the specificity of the selector which applies color to the
toolbar in history.html so that the selector for items-selected_ in
history-toolbar.html will take precedence.

BUG= 598451 

Review URL: https://codereview.chromium.org/1910343003

Cr-Commit-Position: refs/heads/master@{#389014}

[modify] https://crrev.com/b06c83ed5cdabaa90e5473b157ac1f3e04235da1/chrome/browser/resources/md_history/history.html

Sign in to add a comment