Issue 598424 link

Starred by 7 users

Issue metadata

Status:	Available
Owner:	----
Cc:	lucmult@chromium.org jsb...@chromium.org pwnall@chromium.org palmer@chromium.org
Components:	Blink>Storage
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri:	2
Type:	Feature
Hotlist-CodeHealth Hotlist-GoodFirstBug

Blocked on:
issue 496482
issue 591482

Use url::Origin rather than GURL for representing origins in storage back-ends

Project Member Reported by jsb...@chromium.org, Mar 28 2016

Issue description

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in  issue 591482  so we might as well do the back-ends as well.

Checklist:
[] Indexed DB
[] Cache Storage API
[] DOM Storage
[] FileSystem
[] WebSQL

And then these common subsystems:
[] Quota
[] Browsing data deletion

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in   issue 591482   so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB
[] Cache Storage API
[] DOM Storage
[] FileSystem
[] WebSQL

And then these common subsystems:
[] Quota
[] Browsing data deletion

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in    issue 591482    so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[ ] Cache Storage API (//content/browser/cache_storage)
[ ] DOM Storage (//content/browser/dom_storage)
[ ] FileSystem (//content/browser/fileapi)
[ ] WebSQL (//storage/browser/database)

And then these common subsystems:
[ ] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in     issue 591482     so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[ ] Cache Storage API (//content/browser/cache_storage)
[ ] DOM Storage (//content/browser/dom_storage) *
[ ] FileSystem (//content/browser/fileapi)
[ ] WebSQL (//storage/browser/database)

And then these common subsystems:
[ ] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

* = May be done as part of mojoification. Check with mek/dmurph first.

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in      issue 591482      so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[X] Cache Storage API (//content/browser/cache_storage)
[X] DOM Storage (//content/browser/dom_storage) *
[ ] FileSystem (//content/browser/fileapi)
[ ] WebSQL (//storage/browser/database)

And then these common subsystems:
[ ] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

* = May be done as part of mojoification. Check with mek/dmurph first.

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in       issue 591482       so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[X] Cache Storage API (//content/browser/cache_storage)
[X] DOM Storage (//content/browser/dom_storage)
[ ] FileSystem (//content/browser/fileapi)
[ ] WebSQL (//storage/browser/database)

And then these common subsystems:
[ ] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in        issue 591482        so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[X] Cache Storage API (//content/browser/cache_storage)
[X] DOM Storage (//content/browser/dom_storage)
[ ] AppCache (//content/browser/appcache)
[ ] FileSystem (//content/browser/fileapi)
[ ] WebSQL (//storage/browser/database)


And then these common subsystems:
[ ] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in        issue 591482        so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[X] Cache Storage API (//content/browser/cache_storage)
[X] DOM Storage (//content/browser/dom_storage)
[X] AppCache (//content/browser/appcache)
[ ] FileSystem (//content/browser/fileapi)
[ ] WebSQL (//storage/browser/database)


And then these common subsystems:
[ ] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in         issue 591482         so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[X] Cache Storage API (//content/browser/cache_storage)
[X] DOM Storage (//content/browser/dom_storage)
[X] AppCache (//content/browser/appcache)
[ ] FileSystem (//content/browser/fileapi and //storage/browser/fileapi)
[ ] WebSQL (//storage/browser/database)


And then these common subsystems:
[ ] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

Origins are lighter weight, first-class citizens in IPC, and map directly to SecurityOrigins in blink. We're converting IPC over in          issue 591482          so we might as well do the back-ends as well.

Checklist:
[X] Indexed DB (//content/browser/indexed_db)
[X] Cache Storage API (//content/browser/cache_storage)
[X] DOM Storage (//content/browser/dom_storage)
[X] AppCache (//content/browser/appcache)
[ ] FileSystem (//content/browser/fileapi and //storage/browser/fileapi)
[ ] WebSQL (//storage/browser/database)


And then these common subsystems:
[X] Quota (//storage/browser/quota)
[ ] Browsing data deletion (//content/browser/browsing_data)

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bebef3258b61d65b2400fa7c339f56d558e69288

commit bebef3258b61d65b2400fa7c339f56d558e69288
Author: jsbell <jsbell@chromium.org>
Date: Fri Apr 15 16:46:20 2016

IndexedDB: Use url::Origin rather than GURL for representing origins

This just updates the internals of Indexed DB. GURL is still used in
content/public/browser, storage/browser/quota, and
storage/browser/database so there are still conversions Origin<->GURL
conversions on those API boundaries.

R=michaeln@chromium.org
BUG=598424

Review URL: https://codereview.chromium.org/1841553002

Cr-Commit-Position: refs/heads/master@{#387621}

[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_active_blob_registry.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_browsertest.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_context_impl.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_dispatcher_host.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_factory.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_factory_impl.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_internals_ui.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_internals_ui.h
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_quota_client.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/mock_indexed_db_factory.cc
[modify] https://crrev.com/bebef3258b61d65b2400fa7c339f56d558e69288/content/browser/indexed_db/mock_indexed_db_factory.h

Comment 2 by jsb...@chromium.org, Jul 20 2016

Cc: jsb...@chromium.org
Owner: ----
Status: Available (was: Started)

Comment 3 by jsb...@chromium.org, Sep 8 2016

Blockedon: 496482

Project Member

Comment 4 by sheriffbot@chromium.org, Sep 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by jsb...@chromium.org, Sep 18 2017

Description: Show this description

Comment 6 by jsb...@chromium.org, Sep 18 2017

Description: Show this description

Comment 7 by jsb...@chromium.org, Sep 18 2017

Cc: pilgrim@chromium.org
Status: Available (was: Untriaged)

Comment 8 by jsb...@chromium.org, Sep 18 2017

Labels: -Hotlist-Recharge-Cold

Comment 9 by costan@google.com, Jan 19 2018

Cc: pwnall@chromium.org
Labels: Hotlist-GoodFirstBug

Comment 10 by jsb...@chromium.org, Jan 19 2018

Description: Show this description

Comment 11 by xunran.d...@samsung.com, Jan 30 2018

I'd like to take this.

Comment 12 by xunran.d...@samsung.com, Jan 30 2018

Hi, the front-end for content/browser/fileapi is not done in  issue 591482 .

Is it need to be done here?

Comment 13 by jsb...@chromium.org, Jan 30 2018

Cc: -pilgrim@chromium.org lucmult@chromium.org

Re: front end - lucmult@ is planning to tackle issue 787281 (mojoifying the filesystem/fileapi messages). That would be the easiest time to convert IPC from URL to Origin, although it could be done earlier.

It can be done in any order (converting IPC first, converting front-end first, or converting back-end first), it just needs temporary URL<->Origin conversions at the boundaries.

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50

commit b6a21896d9687ff8c7c6aa809e45b3efe2fefb50
Author: Xunran Ding <xunran.ding@samsung.com>
Date: Sat Feb 10 00:30:06 2018

CacheStorage: Use url::Origin rather than GURL for representing origins

This just updates the internals of CacheStorage. GURL is still used in
content/public/browser and storage/browser/quota. so there are still
conversions Origin<->GURL conversions on those API boundaries.

Bug: 598424
Change-Id: Ib2ada9245c3d77f9be33217380742e4c00a732af
Reviewed-on: https://chromium-review.googlesource.com/897231
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535897}
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/cache_storage/cache_storage_quota_client.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/b6a21896d9687ff8c7c6aa809e45b3efe2fefb50/content/browser/service_worker/service_worker_browsertest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/568b3e29e688c2bfbc795b9412f7e9e7a0babad0

commit 568b3e29e688c2bfbc795b9412f7e9e7a0babad0
Author: Xunran Ding <xunran.ding@samsung.com>
Date: Wed Feb 14 06:11:36 2018

DOMStorage: Use url::Origin rather than GURL for representing origins

GURL is still used in storage/browser/quota, content/public/browser and
DOMStorageHostMsg_OpenStorageArea. So there are still Origin<->GURL
conversions on those API boundaries.

Bug: 598424
Change-Id: I9e23ccf7abdbf06b62dcd9b44c4309397ee12d8a
Reviewed-on: https://chromium-review.googlesource.com/910731
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536661}
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_area.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_area.h
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_area_unittest.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_browsertest.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_context_impl.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_context_impl_unittest.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_host.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_host.h
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_message_filter.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_namespace.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/dom_storage_namespace.h
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/session_storage_database.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/session_storage_database.h
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/session_storage_database_adapter.cc
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/session_storage_database_adapter.h
[modify] https://crrev.com/568b3e29e688c2bfbc795b9412f7e9e7a0babad0/content/browser/dom_storage/session_storage_database_unittest.cc

Comment 16 by jsb...@chromium.org, Feb 14 2018

Description: Show this description

Comment 17 by jsb...@chromium.org, Feb 14 2018

Description: Show this description

Comment 18 by jsb...@chromium.org, Feb 14 2018

Related: issue 621724

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53a7cbb558c9e2991436e654b21a0572a3c6855a

commit 53a7cbb558c9e2991436e654b21a0572a3c6855a
Author: Joshua Bell <jsbell@chromium.org>
Date: Fri Feb 16 02:33:27 2018

Convert QuotaClient interface to use url::Origin instead of GURL

Quota operates in terms of origins, but the code is old. Update the
QuotaClient interface implemented by storage back-ends to use the
dedicated Origin type instead of URL.

For storage back-ends that have been internally converted from GURL to
Origin, this eliminates Origin<->URL at the API boundary: Indexed DB,
Cache Storage. For storage back-ends that have not been converted, this
introduces additional conversions which will go away: Service Workers,
File System, WebSQL.

The Quota system still uses GURLs internally, so it conversions are also
introduced there. Additional follow-on work includes using
BindOnce/OnceCallback, and converting the public interfaces that
chrome/browser/browsing_data uses to query usage over to use
url::Origin.

Bug: 598424
Change-Id: I4d2d5c5872e0d02307bb624b4e62b2b3d76b1052
Reviewed-on: https://chromium-review.googlesource.com/920782
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537117}
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/appcache/appcache_quota_client.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/appcache/appcache_quota_client.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/appcache/appcache_quota_client_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/cache_storage/cache_storage_quota_client.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/cache_storage/cache_storage_quota_client.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/indexed_db/indexed_db_browsertest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/indexed_db/indexed_db_context_impl.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/indexed_db/indexed_db_quota_client.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/indexed_db/indexed_db_quota_client.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/indexed_db/indexed_db_quota_client_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/service_worker/service_worker_quota_client.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/browser/service_worker/service_worker_quota_client.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/content/public/browser/indexed_db_context.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/database/database_quota_client.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/database/database_quota_client.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/database/database_quota_client_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/fileapi/file_system_quota_client.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/fileapi/file_system_quota_client.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/fileapi/file_system_quota_client_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/quota/client_usage_tracker.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/quota/client_usage_tracker.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/quota/quota_client.h
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/quota/quota_manager.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/quota/quota_manager_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/quota/storage_monitor_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/quota/usage_tracker_unittest.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/test/mock_storage_client.cc
[modify] https://crrev.com/53a7cbb558c9e2991436e654b21a0572a3c6855a/storage/browser/test/mock_storage_client.h

Comment 20 by xunran.d...@samsung.com, Feb 22 2018

Seems no work left for this bug.

Comment 21 by jsb...@chromium.org, Feb 22 2018

There are several systems left to convert:

* Internals of FileSystem back end
* Internals of WebSQL back end
* Interface of quota system (I'm done QuotaClient, but QuotaManager is in progress)
* Internals of quota system
* Interfaces used for browsing data deletion

These ones are more complicated; I'm working my way through some of them at the moment.

Comment 22 by jsb...@chromium.org, Feb 22 2018

Description: Show this description

Comment 23 by jsb...@chromium.org, Feb 22 2018

Oh, and AppCache still needs converting (content/browser/appcache) - that one would be good to tackle.

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be0d19aa5ed129ff7431a1559f0063614e1ffe89

commit be0d19aa5ed129ff7431a1559f0063614e1ffe89
Author: Joshua Bell <jsbell@chromium.org>
Date: Fri Feb 23 18:30:44 2018

Convert QuotaManagerProxy to use url::Origin instead of GURL

Storage back-ends notify the quota system about deltas in per-origin
usage via a QuotaManagerProxy, which will do sequence-hopping to get
to the right place to talk to the QuotaManager itself.

Convert the entry points to pass url::Origin instances along instead
of GURLs. For back-ends that are already converted to use url::Origin
internally (Cache API, Indexed DB) this deletes code. For the others
(AppCache, WebSQL, FileSystem), some conversions are necessary, mostly
in test logic.

(The QuotaManager itself is not yet updated, so the proxy itself
needs to do a type conversion. That'll get tidied up soon.)

Bug: 598424
Change-Id: I7e9eb04e974053ee6cc9172ee039aaa7cdec3d89
Reviewed-on: https://chromium-review.googlesource.com/927794
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538830}
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/appcache/appcache_host_unittest.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/appcache/appcache_storage.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/appcache/appcache_storage_unittest.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/renderer_host/web_database_host_impl.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/database/database_tracker.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/database/database_tracker_unittest.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/fileapi/quota/quota_backend_impl.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/fileapi/quota/quota_backend_impl_unittest.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/fileapi/sandbox_quota_observer.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/quota/quota_manager_proxy.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/quota/quota_manager_proxy.h
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/test/mock_quota_manager_proxy.cc
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/test/mock_quota_manager_proxy.h
[modify] https://crrev.com/be0d19aa5ed129ff7431a1559f0063614e1ffe89/storage/browser/test/mock_storage_client.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/498e1667ee82739a8d5af94a91385b980e55ece4

commit 498e1667ee82739a8d5af94a91385b980e55ece4
Author: Joshua Bell <jsbell@chromium.org>
Date: Mon Feb 26 20:55:32 2018

Teach DatabaseIdentifiers about url::Origin

Storage APIs (DOM Storage, WebSQL, FileSystem, Indexed DB,
Cache Storage API) use the DatabaseIdentifier type and helper
functions as a way to map origins to pathnames on disk. Add
overloads/additional methods to allow url::Origin to be used
without converting at each call site.

Bug: 598424
Change-Id: I61d0ee9881ff563d1ea693b88e3a9ce3acdff027
Reviewed-on: https://chromium-review.googlesource.com/935295
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539264}
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/content/browser/dom_storage/dom_storage_area.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/content/browser/indexed_db/indexed_db_internals_ui.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/content/browser/renderer_host/web_database_host_impl.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/content/renderer/web_database_observer_impl.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/browser/database/database_quota_client.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/browser/database/database_quota_client_unittest.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/browser/database/database_tracker.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/browser/database/database_tracker_unittest.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/browser/fileapi/obfuscated_file_util.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/common/database/database_identifier.cc
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/common/database/database_identifier.h
[modify] https://crrev.com/498e1667ee82739a8d5af94a91385b980e55ece4/storage/common/database/database_identifier_unittest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8baedad355469769616fcbf727fc51986235c7d

commit e8baedad355469769616fcbf727fc51986235c7d
Author: Xunran Ding <xunran.ding@samsung.com>
Date: Mon Mar 26 21:06:42 2018

Convert app cache to use url::Origin instead of GURL

As GURL is still used in content/public/browser/appcache_service.h,
and there are uses outside content/browser that needs updating,
Convertion is still needed for AppCacheInfoCollection::infos_by_origin.

Convertion is also needed for quota api(storage/browser/quota).

Bug: 598424
Change-Id: I51e8f308a5c12ed61168f68c0f94f1a1bfb8f48a
Reviewed-on: https://chromium-review.googlesource.com/977846
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545872}
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_database.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_database.h
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_database_unittest.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_histograms.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_histograms.h
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_host.h
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_quota_client.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_quota_client_unittest.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_service_impl.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_service_impl.h
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_service_unittest.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_storage.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_storage.h
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_storage_unittest.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_url_request_job.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_working_set.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/appcache_working_set.h
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/chrome_appcache_service_unittest.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/mock_appcache_service.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/browser/appcache/mock_appcache_service.h
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/test/appcache_test_helper.cc
[modify] https://crrev.com/e8baedad355469769616fcbf727fc51986235c7d/content/test/appcache_test_helper.h

Comment 27 by xunran.d...@gmail.com, Mar 27 2018

Will this bug end up with converting all the origin to url::Origin type?

Comment 28 by jsb...@chromium.org, Mar 27 2018

Description: Show this description

Comment 29 by jsb...@chromium.org, Mar 27 2018

Yes - for the storage back-ends and related systems (quota, browsing data deletion).

We can file bugs for each piece of work if desired and make this blocked on them, if it helps for tracking.

Project Member

Comment 30 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4c0469333488da63932dfc98d347796c186b902

commit e4c0469333488da63932dfc98d347796c186b902
Author: Xunran Ding <xunran.ding@samsung.com>
Date: Thu Mar 29 05:50:55 2018

Convert AppCacheService to use url::Origin instead of GURL

For AppCache, almost all of the 'origin' have been converted to url::Origin
type. Convertion to GURL is still needed at quota api boundary.

Bug: 598424
Change-Id: I6d0ae63127b497d475c01a7a3affbbc8759ad700
Reviewed-on: https://chromium-review.googlesource.com/981962
Commit-Queue: Xunran Ding <xunran.ding@samsung.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546739}
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/browsing_data_appcache_helper.h
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/cookies_tree_model.h
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/local_data_container.h
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/chrome/browser/browsing_data/site_data_size_collector.h
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/content/browser/appcache/appcache_internals_ui.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/content/browser/appcache/appcache_service_impl.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/content/browser/appcache/appcache_service_unittest.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/content/public/browser/appcache_service.h
[modify] https://crrev.com/e4c0469333488da63932dfc98d347796c186b902/content/test/appcache_test_helper.cc

Comment 31 by xunran.d...@samsung.com, Jul 6

Hi， it seems that there is no work for //content/browser/fileapi.

Does //storage/browser/fileapi need to be changed to using url::Origin ?

There are lots of code depend on this directory.

Comment 32 by pwnall@chromium.org, Jul 6

Welcome back! (Haven't seen you in a while)

I think you're right on both counts.
https://cs.chromium.org/search/?q=GURL.*origin+case:yes+file:src/storage/browser/fileapi

On a related note, the following code health issues might be interesting to you --  https://crbug.com/855465  https://crbug.com/714018

Feel free to reassign  Issue 855465  away from me and to yourself if you're interested in it. Issue 714018 might be more contended, but there's so much work to be done (over 25k base::Bind references in the whole codebase) that I'm sure more help would be welcome.

Comment 33 by pwnall@chromium.org, Jul 6

Description: Show this description

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3345842e3e3249d01482375a4276ed48b7ed00b1

commit 3345842e3e3249d01482375a4276ed48b7ed00b1
Author: Xunran Ding <xunran.ding@samsung.com>
Date: Wed Jul 11 17:05:33 2018

Convert storage/browser/fileapi/quota to use url::Origin

Update the code directory to use the dedicated Origin type instead of URL.
The next step would be storage/browser/fileapi.

Bug: 598424
Change-Id: I5dab8c9b7c097eb163d7565149b577f73850381d
Reviewed-on: https://chromium-review.googlesource.com/1128796
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574202}
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/content/browser/renderer_host/pepper/quota_reservation_unittest.cc
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_backend_impl.cc
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_backend_impl.h
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_backend_impl_unittest.cc
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_reservation.cc
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_reservation.h
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_reservation_buffer.cc
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_reservation_buffer.h
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_reservation_manager.cc
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_reservation_manager.h
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/quota/quota_reservation_manager_unittest.cc
[modify] https://crrev.com/3345842e3e3249d01482375a4276ed48b7ed00b1/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc

Comment 35 by palmer@chromium.org, Jul 12

Labels: -Pri-3 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows Pri-2

Comment 36 by jsb...@chromium.org, Sep 20

It looks like GURL is still used more than it should in storage/browser/quota so there's probably more to be done there.

Comment 37 by palmer@chromium.org, Sep 21

Cc: palmer@chromium.org

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa7287158e95abcb27331c6731b4b727f73b0f9a

commit aa7287158e95abcb27331c6731b4b727f73b0f9a
Author: Joshua Bell <jsbell@chromium.org>
Date: Fri Sep 28 20:59:46 2018

Change Quota internals to use url::Origin to represent origins

Update storage/browser/quota to use url::Origin to represent origins
rather than GURL. Various bits of chrome/ and content/ reach into
storage/browser, so update those minimally.

As in previous changes for this issue, any calls to origin.GetURL()
are data flowing into a system that needs similar updating. Calls to
url::Origin::Create (outside of tests) indicate data coming out of a
system that needs updating.

Bug: 598424
Change-Id: I8253ec84221c8e4aba50252c291457b28b692b3f
Reviewed-on: https://chromium-review.googlesource.com/1242035
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595210}
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/android_webview/browser/aw_quota_manager_bridge.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/browsing_data/browsing_data_quota_helper_impl.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/browsing_data/counters/site_data_counting_helper.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/browsing_data/counters/site_data_counting_helper.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/extensions/extension_special_storage_policy.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/extensions/extension_storage_monitor.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/chrome/browser/ui/webui/quota_internals/quota_internals_proxy.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/quota_dispatcher_host.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/fileapi/file_system_operation_impl.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/fileapi/file_system_operation_impl_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/fileapi/obfuscated_file_util_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/fileapi/sandbox_file_stream_writer.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/client_usage_tracker.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/client_usage_tracker.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_callbacks.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_database.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_database.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_database_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_manager.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_manager.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_manager_proxy.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_manager_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_temporary_storage_evictor.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_temporary_storage_evictor.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/quota_temporary_storage_evictor_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/storage_monitor.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/storage_monitor.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/storage_monitor_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/storage_observer.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/storage_observer.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/usage_tracker.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/usage_tracker.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/quota/usage_tracker_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/test/async_file_test_helper.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/test/async_file_test_helper.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/test/mock_quota_manager.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/test/mock_quota_manager.h
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/test/mock_quota_manager_proxy.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/test/mock_quota_manager_unittest.cc
[modify] https://crrev.com/aa7287158e95abcb27331c6731b4b727f73b0f9a/storage/browser/test/mock_storage_client.cc

Comment 39 by jsb...@chromium.org, Sep 28

Description: Show this description

Project Member

Comment 40 by bugdroid1@chromium.org, Jan 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f389fd6cfdf3a1d2d644b736de448244b0658464

commit f389fd6cfdf3a1d2d644b736de448244b0658464
Author: Raul Tambre <raul@tambre.ee>
Date: Tue Jan 01 18:41:29 2019

Convert DOMStorageContext to use url::Origin

Bug: 598424
Change-Id: I94a1409cdcd475ec8652a0872eb5be596e3ec284
Reviewed-on: https://chromium-review.googlesource.com/c/1392951
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619351}
[modify] https://crrev.com/f389fd6cfdf3a1d2d644b736de448244b0658464/chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
[modify] https://crrev.com/f389fd6cfdf3a1d2d644b736de448244b0658464/chrome/browser/sessions/session_data_deleter.cc
[modify] https://crrev.com/f389fd6cfdf3a1d2d644b736de448244b0658464/content/browser/dom_storage/dom_storage_browsertest.cc
[modify] https://crrev.com/f389fd6cfdf3a1d2d644b736de448244b0658464/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/f389fd6cfdf3a1d2d644b736de448244b0658464/content/browser/dom_storage/dom_storage_context_wrapper.h
[modify] https://crrev.com/f389fd6cfdf3a1d2d644b736de448244b0658464/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/f389fd6cfdf3a1d2d644b736de448244b0658464/content/public/browser/dom_storage_context.h

Project Member

Comment 41 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d51fbabd5ac66ca165c069130ca61c8662221c96

commit d51fbabd5ac66ca165c069130ca61c8662221c96
Author: Raul Tambre <raul@tambre.ee>
Date: Tue Jan 15 08:07:39 2019

Convert BrowsingDataFileSystemHelper to use url::Origin

Conversion done at API boundaries is minimal.
There are no functional changes.

Bug: 598424, 915773
Change-Id: I8d9ebc9dcce07724473d4c26e5acf3d93e7f9cc0
Reviewed-on: https://chromium-review.googlesource.com/c/1390039
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622779}
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/browsing_data/browsing_data_file_system_helper.cc
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/browsing_data/browsing_data_file_system_helper.h
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/browsing_data/mock_browsing_data_file_system_helper.cc
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/browsing_data/mock_browsing_data_file_system_helper.h
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/content_settings/local_shared_objects_container.cc
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/content_settings/tab_specific_content_settings.cc
[modify] https://crrev.com/d51fbabd5ac66ca165c069130ca61c8662221c96/chrome/browser/ui/webui/cookies_tree_model_util.cc

►

Issue 598424 link

Issue metadata

Use url::Origin rather than GURL for representing origins in storage back-ends

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 15 2016

Comment 1 Deleted

Comment 2 by jsb...@chromium.org, Jul 20 2016

Comment 2 Deleted

Comment 3 by jsb...@chromium.org, Sep 8 2016

Comment 3 Deleted

Comment 4 by sheriffbot@chromium.org, Sep 11 2017

Comment 4 Deleted

Comment 5 by jsb...@chromium.org, Sep 18 2017

Comment 5 Deleted

Comment 6 by jsb...@chromium.org, Sep 18 2017

Comment 6 Deleted

Comment 7 by jsb...@chromium.org, Sep 18 2017

Comment 7 Deleted

Comment 8 by jsb...@chromium.org, Sep 18 2017

Comment 8 Deleted

Comment 9 by costan@google.com, Jan 19 2018

Comment 9 Deleted

Comment 10 by jsb...@chromium.org, Jan 19 2018

Comment 10 Deleted

Comment 11 by xunran.d...@samsung.com, Jan 30 2018

Comment 11 Deleted

Comment 12 by xunran.d...@samsung.com, Jan 30 2018

Comment 12 Deleted

Comment 13 by jsb...@chromium.org, Jan 30 2018

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Feb 10 2018

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Feb 14 2018

Comment 15 Deleted

Comment 16 by jsb...@chromium.org, Feb 14 2018

Comment 16 Deleted

Comment 17 by jsb...@chromium.org, Feb 14 2018

Comment 17 Deleted

Comment 18 by jsb...@chromium.org, Feb 14 2018

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Feb 16 2018

Comment 19 Deleted

Comment 20 by xunran.d...@samsung.com, Feb 22 2018

Comment 20 Deleted

Comment 21 by jsb...@chromium.org, Feb 22 2018

Comment 21 Deleted

Comment 22 by jsb...@chromium.org, Feb 22 2018

Comment 22 Deleted

Comment 23 by jsb...@chromium.org, Feb 22 2018

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Feb 23 2018

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Feb 26 2018

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Mar 26 2018

Comment 26 Deleted

Comment 27 by xunran.d...@gmail.com, Mar 27 2018

Comment 27 Deleted

Comment 28 by jsb...@chromium.org, Mar 27 2018

Comment 28 Deleted

Comment 29 by jsb...@chromium.org, Mar 27 2018

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Mar 29 2018

Comment 30 Deleted

Comment 31 by xunran.d...@samsung.com, Jul 6

Comment 31 Deleted

Comment 32 by pwnall@chromium.org, Jul 6

Comment 32 Deleted

Comment 33 by pwnall@chromium.org, Jul 6

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Jul 11

Comment 34 Deleted

Comment 35 by palmer@chromium.org, Jul 12

Comment 35 Deleted

Comment 36 by jsb...@chromium.org, Sep 20

Comment 36 Deleted

Comment 37 by palmer@chromium.org, Sep 21

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Sep 28

Comment 38 Deleted