New issue
Advanced search Search tips

Issue 598416 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Mar 2016
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 598051



Sign in to add a comment

"Bonus" drawing display item in SVG clip-upon-clip-upon-clip test case.

Project Member Reported by wkorman@chromium.org, Mar 28 2016 
Breakout from  http://crbug.com/598051  --

svg/clip-path/clip-path-clipped-evenodd-twice.svg

We should not see two DrawingDisplayItems for the Rect in this case.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ddca928b60a3ee16c3ffe945dd6b3916883e2ea

commit 3ddca928b60a3ee16c3ffe945dd6b3916883e2ea
Author: pdr <pdr@chromium.org>
Date: Tue Mar 29 19:21:43 2016

Ensure display items are unique when multiple nested clip paths are used

This patch fixes a bug where nested clip paths (drawn as a mask) would
use the LayoutSVGResourceClipper as the display item client id. This
would crash when multiple elements referenced the same nested clip paths
because the LayoutSVGResourceClipper display item client would be
referenced multiple times.

This patch wraps clip path masks in a single display item.

BUG= 598416 

Review URL: https://codereview.chromium.org/1838983002

Cr-Commit-Position: refs/heads/master@{#383791}

[add] https://crrev.com/3ddca928b60a3ee16c3ffe945dd6b3916883e2ea/third_party/WebKit/LayoutTests/svg/clip-path/multiple-nested-clip-paths-crash-expected.html
[add] https://crrev.com/3ddca928b60a3ee16c3ffe945dd6b3916883e2ea/third_party/WebKit/LayoutTests/svg/clip-path/multiple-nested-clip-paths-crash.html
[modify] https://crrev.com/3ddca928b60a3ee16c3ffe945dd6b3916883e2ea/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
[modify] https://crrev.com/3ddca928b60a3ee16c3ffe945dd6b3916883e2ea/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h
[modify] https://crrev.com/3ddca928b60a3ee16c3ffe945dd6b3916883e2ea/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp
[modify] https://crrev.com/3ddca928b60a3ee16c3ffe945dd6b3916883e2ea/third_party/WebKit/Source/core/paint/SVGClipPainter.h

Comment 2 by pdr@chromium.org, Mar 29 2016

Status: Fixed (was: Assigned)
Confirmed this fixes clip-path-clipped-evenodd-twice.svg with wkorman's patch (https://codereview.chromium.org/1836063003) too.
►

Sign in to add a comment