Update timezone DB to 2016c from 2015g for M50 branch |
|||||
Issue descriptionIANA tz db update to 2016c from 2015g. What's new in 2016b and 2016c are found at http://mm.icann.org/pipermail/tz-announce/2016-January/000035.html (2016a) http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b) http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c) Changes were made for Chile (Mark think it's a mistake to go back to a seasonal DST :-)) , Azerbaijan, and several timezones in Russia. Some of changed affects March ~ May 2016. So, we'd better update the timezone DB in M50 branch. Because ToT has moved to ICU 56.1 while M50 branch is still in ICU 54.1. This update has to be made directly in ICU's chrome/m50 branch. (I just cut a chrome/m50 branch for ICU and made a CL on top of it. https://codereview.chromium.org/1836993003/ . Until we update DEPS for M50/2661, nothing will happen.) This will affect the time display in various places (download, history, Chrome OS clock display, file browser, etc) as well as various web Apps using Javascript. It might have a security implication (I'm not sure of this, though). Tina and Ketaki, this is a very safe change. There's no code change but just the timezone database portion of the ICU data.
,
Apr 2 2016
This is an odd merge-request. Because ToT Chrome and M50 Chrome use different versions of ICU (ICU 56.1 vs 54.1), a cherry-pick does not work even though logically it's still a cherry-pick/merge. https://chromereviews.googleplex.com/392937013 is a CL to roll ICU in M50 branch to a version with the latest timezone DB. ( the actual changes - 2 commits : https://chromium.googlesource.com/chromium/deps/icu.git/+log/e466f6ac..4558f7c2 ) Anyway, this change should be very safe. No code change but just the timezone data changes.
,
Apr 3 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Apr 4 2016
Please merge your change to M50 branch 2661 by 5:00 PM on Monday, 04/04/16 so we can take it for next week beta. Thank you.
,
Apr 4 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86110 ------------------------------------------------------------------ r86110 | jungshik@google.com | 2016-04-04T21:33:04.727453Z -----------------------------------------------------------------
,
Apr 4 2016
Thanks. Merged to 2661/M50 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by js...@chromium.org
, Mar 28 2016Below are tests. Timezones with changes in March/April this year are in Russia. d8> d20160622 = new Date("2016-06-22T00:00Z") Tue Jun 21 2016 17:00:00 GMT-0700 (PDT) d8> d20160622.toLocaleString("en-US", {timeZone: "Asia/Baku"}) Expected: "6/22/2016, 4:00:00 AM" Actual: "6/22/2016, 5:00:00 AM" d8> d20160622.toLocaleString("en-US", {timeZone: "America/Santiago"}) Expected: "6/21/2016, 8:00:00 PM" Actual: "6/21/2016, 9:00:00 PM" d8> d20160328 = new Date("2016-03-28T00:00Z") Sun Mar 27 2016 17:00:00 GMT-0700 (PDT) d8> d20160328.toLocaleString("en-US", {timeZone: "Asia/Sakhalin"}) Expected: "3/28/2016, 11:00:00 AM" Actual: "3/28/2016, 10:00:00 AM" d8> d20160326 = new Date("2016-03-26T00:00Z") Fri Mar 25 2016 17:00:00 GMT-0700 (PDT) d8> d20160326.toLocaleString("en-US", {timeZone: "Asia/Sakhalin"}) Both expected and actual: "3/26/2016, 10:00:00 AM"