Rework net/base/sniff_mime_type_fuzzer.cc |
||
Issue descriptionIt uses a fixed URL and assumes there's no content-type header. Both the extension of the URL and the content-type header affect which branches we take through the fuzzer, so they should be fuzzed as well. It's a bit unfortunate that this means we'll have to pass a fuzzed string through GURL's constructor, since that bloats up what the fuzzer considers the search space.
,
Mar 28 2016
I don't think limiting the length really helps us much - there's a ton of logic for escaping / unescaping characters, unicode sequences, query strings, flying goats (I didn't even realize those could appear in URLs, but I bet there's a unicode character for a flying goat emoticon now), etc.
,
Mar 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5552a6a020ac21565f4a92a36d545e8115c56132 commit 5552a6a020ac21565f4a92a36d545e8115c56132 Author: mmenke <mmenke@chromium.org> Date: Mon Mar 28 23:11:59 2016 Rework the mime sniffer fuzzer. In particular, make it fuzz the URL and content-type header, and make it check the other top level mime sniffing function. Also, rename it so it's more clearly associated with mime_sniffer.h. BUG= 598397 Review URL: https://codereview.chromium.org/1834303002 Cr-Commit-Position: refs/heads/master@{#383597} [modify] https://crrev.com/5552a6a020ac21565f4a92a36d545e8115c56132/net/BUILD.gn [add] https://crrev.com/5552a6a020ac21565f4a92a36d545e8115c56132/net/base/mime_sniffer_fuzzer.cc [delete] https://crrev.com/b541cf76bc983ee2d8b1c5c87d43d775303fa856/net/base/sniff_mime_type_fuzzer.cc
,
Mar 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by eroman@chromium.org
, Mar 28 2016