New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598387 link

Starred by 0 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add support on Chameleon to provide more signals to detect difference before frames

Project Member Reported by waihong@chromium.org, Mar 28 2016

Issue description

This tracks the features on Chameleon such that the test can have more knowledge to know the frame differences (more flexible than the existing checksum).

The goal is to give the test more flexibility to compare frame/video, and further to do more general automation.
 
Labels: Chameleon
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360

commit 8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Wed Mar 09 20:39:58 2016

Implement the utility to compute histograms of frames

This is a C program running on Chameleon board to compute the
histograms of sampled pixels from the Chameleon framebuffer.

A user should give the start addresses (support multiple)
of the framebuffer, the width and height of the screen.
Two configurable parameters, grid_num and sample_num,
makes it flexible for different scenarios.

The histograms are computed per 3 colors R, G, and B, using
4 buckets, i.e. values 0~63, 64~127, 128~191, and 192~255.

BUG=chromium:598387
TEST=Ran the histogram program
$ histogram 960 1080 -a 3221225472 -s 10 -g 3
$ histogram 960 1080 -a 3221225472 -a 3224338432 -s 5 -g 5

Change-Id: I4127cd054dfef2cb82999260fdf01a44da4c9ef2
Reviewed-on: https://chromium-review.googlesource.com/335334
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[add] https://crrev.com/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360/src/histogram.c
[modify] https://crrev.com/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360/Makefile
[modify] https://crrev.com/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360/MANIFEST.in

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360

commit 8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Wed Mar 09 20:39:58 2016

Implement the utility to compute histograms of frames

This is a C program running on Chameleon board to compute the
histograms of sampled pixels from the Chameleon framebuffer.

A user should give the start addresses (support multiple)
of the framebuffer, the width and height of the screen.
Two configurable parameters, grid_num and sample_num,
makes it flexible for different scenarios.

The histograms are computed per 3 colors R, G, and B, using
4 buckets, i.e. values 0~63, 64~127, 128~191, and 192~255.

BUG=chromium:598387
TEST=Ran the histogram program
$ histogram 960 1080 -a 3221225472 -s 10 -g 3
$ histogram 960 1080 -a 3221225472 -a 3224338432 -s 5 -g 5

Change-Id: I4127cd054dfef2cb82999260fdf01a44da4c9ef2
Reviewed-on: https://chromium-review.googlesource.com/335334
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[add] https://crrev.com/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360/src/histogram.c
[modify] https://crrev.com/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360/Makefile
[modify] https://crrev.com/8db3bf8c5c4de0b0ad857898a98e31dd3a1cc360/MANIFEST.in

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f

commit c89c4e82d78e58d0b8fb69d8bf78a57234688f4f
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Wed Mar 09 20:41:48 2016

Save histograms on Chameleond and add an API to get histograms

After starting video capturing, the monitoring child process should
save the histograms to the share memory, before these frames get
overwritten.

It also exposes a new API for the client to get the histograms.

BUG=chromium:598387
TEST=Call the new API to get historgrams.

Change-Id: I15bc85e3d23c424351fe61cbc6b5639f83355aeb
Reviewed-on: https://chromium-review.googlesource.com/335335
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/common.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/input_flow.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/system_tools.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/field_manager.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/drivers/fpga_tio.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/frame_manager.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/interface.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f

commit c89c4e82d78e58d0b8fb69d8bf78a57234688f4f
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Wed Mar 09 20:41:48 2016

Save histograms on Chameleond and add an API to get histograms

After starting video capturing, the monitoring child process should
save the histograms to the share memory, before these frames get
overwritten.

It also exposes a new API for the client to get the histograms.

BUG=chromium:598387
TEST=Call the new API to get historgrams.

Change-Id: I15bc85e3d23c424351fe61cbc6b5639f83355aeb
Reviewed-on: https://chromium-review.googlesource.com/335335
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/common.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/input_flow.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/system_tools.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/field_manager.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/drivers/fpga_tio.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/utils/frame_manager.py
[modify] https://crrev.com/c89c4e82d78e58d0b8fb69d8bf78a57234688f4f/chameleond/interface.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/3ce649c91d179833d1cad34067dda521ac39575b

commit 3ce649c91d179833d1cad34067dda521ac39575b
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Tue Mar 15 19:33:03 2016

Support scaling down thumbnails by a configurable ratio

This change adds an argument to scale down the thumbnails being
cached.

It modifies the pixeldump program to support skipping pixels (reading
one pixel and then skipping the next n pixels) and skipping lines
(reading one line and then skipping the next m lines).

BUG=chromium:598387
TEST=Call the API with different ratio, e.g. 2, 4, 6, 8, 10 (unaligned).

Change-Id: I592be16762372ca29192b1c4f5d049997ef8c564
Reviewed-on: https://chromium-review.googlesource.com/335337
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/3ce649c91d179833d1cad34067dda521ac39575b/src/pixeldump.c
[modify] https://crrev.com/3ce649c91d179833d1cad34067dda521ac39575b/Makefile
[modify] https://crrev.com/3ce649c91d179833d1cad34067dda521ac39575b/chameleond/utils/input_flow.py
[modify] https://crrev.com/3ce649c91d179833d1cad34067dda521ac39575b/chameleond/utils/field_manager.py
[modify] https://crrev.com/3ce649c91d179833d1cad34067dda521ac39575b/chameleond/drivers/fpga_tio.py
[modify] https://crrev.com/3ce649c91d179833d1cad34067dda521ac39575b/chameleond/utils/frame_manager.py
[modify] https://crrev.com/3ce649c91d179833d1cad34067dda521ac39575b/chameleond/interface.py

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/91afcfc5543e61f6e7055c4d5398026b846b0e51

commit 91afcfc5543e61f6e7055c4d5398026b846b0e51
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Thu Mar 10 23:26:41 2016

Add an API to cache the thumbnail of the previous frame

The buffer to store the frame is limitted, meaning the previous
frames are overwritten when the buffer gets full. Sending the
previous frames out may not fast enough before they get overwritten.
Adding this new API to cache the thumbnail (scaled down from a full
frame) to the RAM filesystem (/tmp) helps the client have more time.
Some buffer is now allowed.

The client can get the frames by downloading them via http protocal.

BUG=chromium:598387
TEST=Start chameleond, call the API to cache a thumbnail, and fetch it via http.

Change-Id: I28203e69d93f8645ebdb35c659bf8a38a72f759f
Reviewed-on: https://chromium-review.googlesource.com/335336
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[add] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/chameleond/utils/caching_server.py
[modify] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/chameleond/utils/input_flow.py
[modify] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/chameleond/chameleon_server.py
[modify] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/chameleond/utils/field_manager.py
[modify] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/utils/run_chameleond
[modify] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/chameleond/drivers/fpga_tio.py
[modify] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/chameleond/utils/frame_manager.py
[modify] https://crrev.com/91afcfc5543e61f6e7055c4d5398026b846b0e51/chameleond/interface.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/2c52518f21df56d845bc809484949da61d91d574

commit 2c52518f21df56d845bc809484949da61d91d574
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Thu Jun 02 22:43:30 2016

Support scaling down image in signal-pixel mode

It can be done by assigning proper arguments to pixeldump.

BUG=chromium:598387
TEST=Called the API CacheFrameThumbnail() in the single-pixel mode.

Change-Id: Ib2eb57f0864f3bc3d12a6570cf3a238e77908c06
Reviewed-on: https://chromium-review.googlesource.com/349263
Commit-Ready: Tom Tam <waihong@google.com>
Tested-by: Tom Tam <waihong@google.com>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/2c52518f21df56d845bc809484949da61d91d574/chameleond/utils/field_manager.py

Sign in to add a comment